From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: Re: [PATCH v5 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory Date: Wed, 24 Jul 2019 19:17:12 +0200 Message-ID: <2bb1f3ed-9daa-0499-6458-d5cda1b05696@suse.de> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0253291927==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Andrzej Pietrasiewicz , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: "Y.C. Chen" , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Sam Ravnborg , Neil Armstrong , David Airlie , Ramalingam C , Joonas Lahtinen , Douglas Anderson , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Benjamin Gaignard , kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Fabio Estevam , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "David (ChunMing) Zhou" , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joonyoung Shim , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Vincent Abriou , Rob Clark , Krzysztof List-Id: intel-gfx@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0253291927== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CzlbHGq4WhBkL4IV7XjoKzmobL2wuQ0qV" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CzlbHGq4WhBkL4IV7XjoKzmobL2wuQ0qV Content-Type: multipart/mixed; boundary="vx3UfqM6cm4tRt5G38ZnVYtCo9DNrd4Aq"; protected-headers="v1" From: Thomas Zimmermann To: Andrzej Pietrasiewicz , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , Dave Airlie , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Sean Paul , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , CK Hu , Matthias Brugger , Rob Clark , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Benjamin Gaignard , Vincent Abriou , Chen-Yu Tsai , Thierry Reding , Jonathan Hunter , Jyri Sarha , Tomi Valkeinen , Eric Anholt , Sam Ravnborg , Huang Rui , Gerd Hoffmann , "Y.C. Chen" , Douglas Anderson , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Chris Wilson , Shashank Sharma , Ramalingam C , Thomas Gleixner , Allison Randal , Mamta Shukla , Todor Tomov , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Message-ID: <2bb1f3ed-9daa-0499-6458-d5cda1b05696-l3A5Bk7waGM@public.gmane.org> Subject: Re: [PATCH v5 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory References: In-Reply-To: --vx3UfqM6cm4tRt5G38ZnVYtCo9DNrd4Aq Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. >=20 > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/m= gag200/mgag200_mode.c > index 822f2a13748f..5e778b5f1a10 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_mode.c > +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c > @@ -1678,18 +1678,19 @@ static struct drm_connector *mga_vga_init(struc= t drm_device *dev) > return NULL; > =20 > connector =3D &mga_connector->base; > + mga_connector->i2c =3D mgag200_i2c_create(dev); > + if (!mga_connector->i2c) > + DRM_ERROR("failed to add ddc bus\n"); > =20 > - drm_connector_init(dev, connector, > - &mga_vga_connector_funcs, DRM_MODE_CONNECTOR_VGA); > + drm_connector_init_with_ddc(dev, connector, > + &mga_vga_connector_funcs, > + DRM_MODE_CONNECTOR_VGA, > + &mga_connector->i2c->adapter); > =20 > drm_connector_helper_add(connector, &mga_vga_connector_helper_funcs);= > =20 > drm_connector_register(connector); > =20 > - mga_connector->i2c =3D mgag200_i2c_create(dev); > - if (!mga_connector->i2c) > - DRM_ERROR("failed to add ddc bus\n"); > - > return connector; > } > =20 >=20 Reviewed-by: Thomas Zimmermann --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --vx3UfqM6cm4tRt5G38ZnVYtCo9DNrd4Aq-- --CzlbHGq4WhBkL4IV7XjoKzmobL2wuQ0qV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl04kpgACgkQaA3BHVML eiMrlAgAqW3ABsZtizMm7MOSLBePvnTZDbTBLSTtBStovJOFYbbb66NZX0TCaUZA TL+JGx2F9H+EnTX5kvTyu04LT5Vu2L8OveVOKJAP0kdHebBi4QT/OBIT21ydVBbK ZiP9ZpiDG1L9cXbBCaKnOt6tVospLrAY0o02+MwX4g8ehIBqW7rfwP3n2zGzwc1m hI2pVIAaJNYduRwjBlq66ZMQVDBjKejpuSrQWD6axnun+OhHIOhlLYgdRW+ZuKGS pmDfwfSGoBAn+5ECcDH4KpXuUWBpce+9d4MaifBvjdbecw7if3aCP5QeV2IrThOY J29KC+t8MqUnfDZNsu5GWiZDQto9UA== =ezdZ -----END PGP SIGNATURE----- --CzlbHGq4WhBkL4IV7XjoKzmobL2wuQ0qV-- --===============0253291927== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRyZW5v IG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5v --===============0253291927==--