From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [RFC 04/14] drm/i915/pmu: Decouple uAPI engine ids Date: Wed, 26 Jul 2017 10:04:23 +0100 Message-ID: <2bfe1455-693c-1828-8ccd-7fa3d7c6e187@linux.intel.com> References: <20170718143618.12254-1-tvrtko.ursulin@linux.intel.com> <20170718143618.12254-5-tvrtko.ursulin@linux.intel.com> <20170725011817.GA4922@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AF686E678 for ; Wed, 26 Jul 2017 09:04:25 +0000 (UTC) In-Reply-To: <20170725011817.GA4922@intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky , Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI1LzA3LzIwMTcgMDI6MTgsIEJlbiBXaWRhd3NreSB3cm90ZToKPiBPbiAxNy0wNy0xOCAx NTozNjowOCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZyb206IFR2cnRrbyBVcnN1bGluIDx0 dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IEFzIGVsc2V3aGVyZSBpbiB0aGUgY29kZSB3 ZSBoYXZlIHRvIGRlY291cGxlIHRoZSBiaW5hcnkKPj4gZW5naW5lIGlkZW50aWZpZXJzIGZvciBl YXNpZXIgbWFpbnRlbmFuY2UuCj4+Cj4+IEFsc28gdGhlIHNhbXBsZXIgbWFzayB3YXMgaW5jb3Jy ZWN0IGluIHRoZSB0aW1lciBjYWxsYmFjay4KPj4KPiAKPiBJIGRvbid0IHF1aXRlIHVuZGVyc3Rh bmQgdGhlIHBvaW50IG9mIHRoaXMgcGF0Y2guLi4gY2FuIHlvdSBwZXJoYXBzIAo+IGVtYmVsbGlz aAo+IHRoZSBjb21taXQgbWVzc2FnZT8KCkl0IGlzIHRvIGRlY291cGxlIHRoZSBBQkkgbmFtZXNw YWNlIGZyb20gdGhlIGRyaXZlciBpbnRlcm5hbCBlbnVtZXJhdGlvbiAKb2YgZW5naW5lcyBhbmQg c28gYWxsb3cgdGhlIGxhdHRlciB0byBiZSByZWZhY3RvcmVkIGluIHRoZSBmdXR1cmUsIGFuZCAK YXQgdGhlIHNhbWUgdGltZSBmaXggdGhlIGZpc3QgcGF0Y2ggdG8gaW5kZXggZW5naW5lcyBvdGhl ciB0aGFuIFJDUyAKY29ycmVjdGx5LgoKSSBkaWQgbm90IGJvdGhlciB3aXRoIHNtYXJ0IGNvbW1p dCBtZXNzYWdlIGZvciB0aGUgZmlyc3QgZmV3IHBhdGNoZXMgCnNpbmNlIHRoZXkgcmVhbGx5IHNo b3VsZCBiZSBzcXVhc2hlZCB3aXRoIHRoZSBmaXJzdCBvbmUgZnJvbSBDaHJpcy4KClJlZ2FyZHMs CgpUdnJ0a28KCgo+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3Vs aW5AaW50ZWwuY29tPgo+PiAtLS0KPj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYyB8 IDQ0IAo+PiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+PiAxIGZp bGUgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMgCj4+IGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9wbXUuYwo+PiBpbmRleCBmMDNkZGFkNDRkYTYuLjlhODIwOGRiYTdhOSAx MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4+IEBAIC0xMCw2ICsxMCwyNSBAQAo+PiAj ZGVmaW5lIFJJTkdfTUFTSyAweGZmZmZmZmZmCj4+ICNkZWZpbmUgUklOR19NQVggMzIKPj4KPj4g KyNkZWZpbmUgRU5HSU5FX1NBTVBMRV9NQVNLICgweGYpCj4+ICsjZGVmaW5lIEVOR0lORV9TQU1Q TEVfQklUUyAoNCkKPj4gKwo+PiArc3RhdGljIGNvbnN0IHVuc2lnbmVkIGludCBlbmdpbmVfbWFw W0k5MTVfTlVNX0VOR0lORVNdID0gewo+PiArICAgIFtSQ1NdID0gSTkxNV9TQU1QTEVfUkNTLAo+ PiArICAgIFtCQ1NdID0gSTkxNV9TQU1QTEVfQkNTLAo+PiArICAgIFtWQ1NdID0gSTkxNV9TQU1Q TEVfVkNTLAo+PiArICAgIFtWQ1MyXSA9IEk5MTVfU0FNUExFX1ZDUzIsCj4+ICsgICAgW1ZFQ1Nd ID0gSTkxNV9TQU1QTEVfVkVDUywKPj4gK307Cj4+ICsKPj4gK3N0YXRpYyBjb25zdCB1bnNpZ25l ZCBpbnQgdXNlcl9lbmdpbmVfbWFwW0k5MTVfTlVNX0VOR0lORVNdID0gewo+PiArICAgIFtJOTE1 X1NBTVBMRV9SQ1NdID0gUkNTLAo+PiArICAgIFtJOTE1X1NBTVBMRV9CQ1NdID0gQkNTLAo+PiAr ICAgIFtJOTE1X1NBTVBMRV9WQ1NdID0gVkNTLAo+PiArICAgIFtJOTE1X1NBTVBMRV9WQ1MyXSA9 IFZDUzIsCj4+ICsgICAgW0k5MTVfU0FNUExFX1ZFQ1NdID0gVkVDUywKPj4gK307Cj4+ICsKPj4g c3RhdGljIHZvaWQgZW5naW5lc19zYW1wbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+PiB7Cj4+ICAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4+IEBAIC0y Niw5ICs0NSwxNiBAQCBzdGF0aWMgdm9pZCBlbmdpbmVzX3NhbXBsZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAKPj4gKmRldl9wcml2KQo+PiAgICAgICAgIHJldHVybjsKPj4KPj4gICAgIGZvcl9l YWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2LCBpZCkgewo+PiArICAgICAgICB1bnNpZ25lZCBp bnQgdXNlcl9lbmdpbmUgPSBlbmdpbmVfbWFwW2lkXTsKPj4gICAgICAgICB1MzIgdmFsOwo+Pgo+ PiAtICAgICAgICBpZiAoKGRldl9wcml2LT5wbXUuZW5hYmxlICYgKDB4NyA8PCAoNCppZCkpKSA9 PSAwKQo+PiArICAgICAgICBpZiAoV0FSTl9PTl9PTkNFKGlkID49IEFSUkFZX1NJWkUoZW5naW5l X21hcCkpKQo+PiArICAgICAgICAgICAgY29udGludWU7Cj4+ICsgICAgICAgIGVsc2UKPj4gKyAg ICAgICAgICAgIHVzZXJfZW5naW5lID0gZW5naW5lX21hcFtpZF07Cj4+ICsKPj4gKyAgICAgICAg aWYgKCEoZGV2X3ByaXYtPnBtdS5lbmFibGUgJgo+PiArICAgICAgICAgICAgKEVOR0lORV9TQU1Q TEVfTUFTSyA8PCAoRU5HSU5FX1NBTVBMRV9CSVRTICogdXNlcl9lbmdpbmUpKSkpCj4+ICAgICAg ICAgICAgIGNvbnRpbnVlOwo+Pgo+PiAgICAgICAgIGlmIChpOTE1X3NlcW5vX3Bhc3NlZChpbnRl bF9lbmdpbmVfZ2V0X3NlcW5vKGVuZ2luZSksCj4+IEBAIC0xMTIsNiArMTM4LDExIEBAIHN0YXRp YyBpbnQgZW5naW5lX2V2ZW50X2luaXQoc3RydWN0IHBlcmZfZXZlbnQgCj4+ICpldmVudCkKPj4g ICAgIGludCBlbmdpbmUgPSBldmVudC0+YXR0ci5jb25maWcgPj4gMjsKPj4gICAgIGludCBzYW1w bGUgPSBldmVudC0+YXR0ci5jb25maWcgJiAzOwo+Pgo+PiArICAgIGlmIChXQVJOX09OX09OQ0Uo ZW5naW5lID49IEFSUkFZX1NJWkUodXNlcl9lbmdpbmVfbWFwKSkpCj4+ICsgICAgICAgIHJldHVy biAtRU5PRU5UOwo+PiArICAgIGVsc2UKPj4gKyAgICAgICAgZW5naW5lID0gdXNlcl9lbmdpbmVf bWFwW2VuZ2luZV07Cj4+ICsKPj4gICAgIHN3aXRjaCAoc2FtcGxlKSB7Cj4+ICAgICBjYXNlIEk5 MTVfU0FNUExFX1FVRVVFRDoKPj4gICAgIGNhc2UgSTkxNV9TQU1QTEVfQlVTWToKPj4gQEAgLTEy NSw5ICsxNTYsNiBAQCBzdGF0aWMgaW50IGVuZ2luZV9ldmVudF9pbml0KHN0cnVjdCBwZXJmX2V2 ZW50IAo+PiAqZXZlbnQpCj4+ICAgICAgICAgcmV0dXJuIC1FTk9FTlQ7Cj4+ICAgICB9Cj4+Cj4+ IC0gICAgaWYgKGVuZ2luZSA+PSBJOTE1X05VTV9FTkdJTkVTKQo+PiAtICAgICAgICByZXR1cm4g LUVOT0VOVDsKPj4gLQo+PiAgICAgaWYgKCFpOTE1LT5lbmdpbmVbZW5naW5lXSkKPj4gICAgICAg ICByZXR1cm4gLUVOT0RFVjsKPj4KPj4gQEAgLTM2OSw3ICszOTcsMTMgQEAgc3RhdGljIHZvaWQg aTkxNV9wbXVfZXZlbnRfcmVhZChzdHJ1Y3QgcGVyZl9ldmVudCAKPj4gKmV2ZW50KQo+PiAgICAg aWYgKGV2ZW50LT5hdHRyLmNvbmZpZyA8IDMyKSB7Cj4+ICAgICAgICAgaW50IGVuZ2luZSA9IGV2 ZW50LT5hdHRyLmNvbmZpZyA+PiAyOwo+PiAgICAgICAgIGludCBzYW1wbGUgPSBldmVudC0+YXR0 ci5jb25maWcgJiAzOwo+PiAtICAgICAgICB2YWwgPSBpOTE1LT5lbmdpbmVbZW5naW5lXS0+cG11 X3NhbXBsZVtzYW1wbGVdOwo+PiArCj4+ICsgICAgICAgIGlmIChXQVJOX09OX09OQ0UoZW5naW5l ID49IEFSUkFZX1NJWkUodXNlcl9lbmdpbmVfbWFwKSkpIHsKPj4gKyAgICAgICAgICAgIC8qIERv IG5vdGhpbmcgKi8KPj4gKyAgICAgICAgfSBlbHNlIHsKPj4gKyAgICAgICAgICAgIGVuZ2luZSA9 IHVzZXJfZW5naW5lX21hcFtlbmdpbmVdOwo+PiArICAgICAgICAgICAgdmFsID0gaTkxNS0+ZW5n aW5lW2VuZ2luZV0tPnBtdV9zYW1wbGVbc2FtcGxlXTsKPj4gKyAgICAgICAgfQo+PiAgICAgfSBl bHNlIHN3aXRjaCAoZXZlbnQtPmF0dHIuY29uZmlnKSB7Cj4+ICAgICBjYXNlIEk5MTVfUE1VX0FD VFVBTF9GUkVRVUVOQ1k6Cj4+ICAgICAgICAgdmFsID0gaTkxNS0+cG11LnNhbXBsZVtfX0k5MTVf U0FNUExFX0ZSRVFfQUNUXTsKPj4gLS0gCj4+IDIuOS40Cj4+Cj4gCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=