Re: [PATCH 3/8] drm/i915: Connector info in HDCP debug msgs

Sean Paul
2018-02-02T14:15:02Z

On Fri, Feb 02, 2018 at 04:15:15PM +0530, Ramalingam C wrote:
> When HDCP authentication is triggered on multiple connector, having
> connector name and ID in debug message will be more informative.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index 182a3c8a4e4a..b3f407cef8b0 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -388,8 +388,10 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
> return -ENXIO;
> }
>
> - DRM_DEBUG_KMS("HDCP is enabled (%d downstream devices)\n",
> - num_downstream);
> + DRM_DEBUG_KMS("[%s:%d] HDCP is enabled (%d downstream devices)\n",
> + connector->base.name,
> + connector->base.base.id,
> + num_downstream);

Your alignment is off, should be:

DRM_DEBUG_KMS("[%s:%d] HDCP is enabled (%d downstream devices)\n",
connector->base.name, connector->base.base.id,
num_downstream);

Same for the rest of the patch. With that fixed,

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> return 0;
> }
>
> @@ -515,7 +517,9 @@ static int intel_hdcp_auth(struct intel_connector *connector)
> }
> }
>
> - DRM_DEBUG_KMS("HDCP is enabled (no repeater present)\n");
> + DRM_DEBUG_KMS("[%s:%d] HDCP is enabled (no repeater present)\n",
> + connector->base.name,
> + connector->base.base.id);
> return 0;
> }
>
> @@ -541,7 +545,8 @@ static int _intel_hdcp_disable(struct intel_connector *connector)
> return ret;
> }
>
> - DRM_DEBUG_KMS("HDCP is disabled\n");
> + DRM_DEBUG_KMS("[%s:%d] HDCP is disabled\n", connector->base.name,
> + connector->base.base.id);
> return 0;
> }
>
> @@ -743,7 +748,9 @@ int intel_hdcp_check_link(struct intel_connector *connector)
> goto out;
> }
>
> - DRM_DEBUG_KMS("HDCP link failed, retrying authentication\n");
> + DRM_DEBUG_KMS("[%s:%d] HDCP link failed, retrying authentication\n",
> + connector->base.name,
> + connector->base.base.id);
>
> ret = _intel_hdcp_disable(connector);
> if (ret) {
> --
> 2.7.4
>

--
Sean Paul, Software Engineer, Google / Chromium OS