From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Intel GFX discussion <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] lib: Pass I915_TILING_Y to the kernel if Yf or Ys
Date: Fri, 11 Nov 2016 10:27:18 +0000 [thread overview]
Message-ID: <2c36e6e0-04b7-6c05-693f-654f5fb4c015@linux.intel.com> (raw)
In-Reply-To: <ba8f79a8-cee5-cd8f-901b-6fb1abfab94c@linux.intel.com>
On 10/11/2016 16:18, Tvrtko Ursulin wrote:
> On 10/11/2016 10:15, Tomeu Vizoso wrote:
>> GEM_SET_TILING doesn't care about Yf or Ys, so just pass Y.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>> ---
>> lib/ioctl_wrappers.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
>> index 95bc5e268bcd..eabf3ee3abe6 100644
>> --- a/lib/ioctl_wrappers.c
>> +++ b/lib/ioctl_wrappers.c
>> @@ -158,6 +158,9 @@ int __gem_set_tiling(int fd, uint32_t handle,
>> uint32_t tiling, uint32_t stride)
>>
>> igt_require_intel(fd);
>>
>> + if (tiling == I915_TILING_Yf || tiling == I915_TILING_Ys)
>> + tiling = I915_TILING_Y;
>> +
>
> This is a bit nasty, breaks tests (or keeps them broken) and more so I
> can't really figure out why would you want to do this?
If I change the "tiling = I915_TILING_Y" to "I915_TILING_NONE" above
then kms_flip_tiling passes in all but two subtests. (And those two fail
with crc errors due broken watermarks, so not an IGT issue.)
So not going deeper into how IGT handles tiling nowadays, please
consider the above option to fix this. It is correct at least anyway for
i915 expectations.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-11-11 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 10:15 [PATCH i-g-t] lib: Pass I915_TILING_Y to the kernel if Yf or Ys Tomeu Vizoso
2016-11-10 16:18 ` Tvrtko Ursulin
2016-11-11 10:27 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c36e6e0-04b7-6c05-693f-654f5fb4c015@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).