* [PATCH] drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin
@ 2015-03-17 15:36 Tvrtko Ursulin
2015-03-18 9:05 ` Daniel Vetter
2015-03-18 16:18 ` shuang.he
0 siblings, 2 replies; 3+ messages in thread
From: Tvrtko Ursulin @ 2015-03-17 15:36 UTC (permalink / raw)
To: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
This makes the interface consistent to old i915_gem_obj_ggtt_pin.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index e150038..533ef37 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4292,7 +4292,7 @@ i915_gem_object_ggtt_pin(struct drm_i915_gem_object *obj,
return -EINVAL;
return i915_gem_object_do_pin(obj, i915_obj_to_ggtt(obj), view,
- alignment, flags);
+ alignment, flags | PIN_GLOBAL);
}
void
--
2.3.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin
2015-03-17 15:36 [PATCH] drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin Tvrtko Ursulin
@ 2015-03-18 9:05 ` Daniel Vetter
2015-03-18 16:18 ` shuang.he
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2015-03-18 9:05 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: Intel-gfx
On Tue, Mar 17, 2015 at 03:36:51PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> This makes the interface consistent to old i915_gem_obj_ggtt_pin.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Ok our naming of gem/vma pin/unpin/bind/unbind functions seems to be a
rather impressive mess now. We have lots of special-cases with devilishly
close names and distinct behaviour. This needs to be cleaned up once
rotated and partial views have landed.
Queued for -next meanwhile, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin
2015-03-17 15:36 [PATCH] drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin Tvrtko Ursulin
2015-03-18 9:05 ` Daniel Vetter
@ 2015-03-18 16:18 ` shuang.he
1 sibling, 0 replies; 3+ messages in thread
From: shuang.he @ 2015-03-18 16:18 UTC (permalink / raw)
To: shuang.he, ethan.gao, intel-gfx, tvrtko.ursulin
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5986
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -2 268/268 266/268
ILK -1 303/303 302/303
SNB 283/283 283/283
IVB 343/343 343/343
BYT 287/287 287/287
HSW 363/363 363/363
BDW 308/308 308/308
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
PNV igt_gem_userptr_blits_coherency-sync CRASH(1)PASS(3) CRASH(1)PASS(1)
PNV igt_gem_tiled_pread_pwrite FAIL(1)PASS(3) FAIL(1)PASS(1)
*ILK igt_gem_seqno_wrap PASS(2) DMESG_WARN(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-18 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-17 15:36 [PATCH] drm/i915: Turn on PIN_GLOBAL in i915_gem_object_ggtt_pin Tvrtko Ursulin
2015-03-18 9:05 ` Daniel Vetter
2015-03-18 16:18 ` shuang.he
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox