From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19702C433E1 for ; Thu, 21 May 2020 13:54:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9E33206B6 for ; Thu, 21 May 2020 13:54:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9E33206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 763C56E21C; Thu, 21 May 2020 13:54:54 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E9D96E21A for ; Thu, 21 May 2020 13:54:53 +0000 (UTC) IronPort-SDR: J4EAfnfLI/fTfZdFBKf3MFGRUnFI4MMvgCA55mZQogqimXccm9n1vndUukvHd6l+BvVeSQ7tKV YW03AF8N/X0A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2020 06:54:53 -0700 IronPort-SDR: bB3W45TBixXGkxFu1yyo53dNsYv1QhGMMTAf8+fYahRF32+WV1LSjWlG5js8BC39KF06MDPzq/ jw0HZDhHzqCw== X-IronPort-AV: E=Sophos;i="5.73,417,1583222400"; d="scan'208";a="412398442" Received: from cpinhasx-mobl.ger.corp.intel.com (HELO [10.254.152.79]) ([10.254.152.79]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2020 06:54:51 -0700 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20200521124304.3157692-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <2fb55543-c9fe-2b90-386e-4f98367f60aa@linux.intel.com> Date: Thu, 21 May 2020 14:54:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200521124304.3157692-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Flush the submission, not cancel it! X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 21/05/2020 13:43, Chris Wilson wrote: > Use intel_engine_flush_submission() when we want to ensure that the > tasklet is run. tasklet_kill(), while it may ensure that an ongoing > tasklet is completed, also prevents the tasklet from running if it's > already scheduled and hasn't yet been run. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1874 > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index ef38dd52945c..66f710b1b61e 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -332,7 +332,7 @@ static int live_unlite_restore(struct intel_gt *gt, int prio) > i915_request_put(rq[0]); > > err_ce: > - tasklet_kill(&engine->execlists.tasklet); /* flush submission */ > + intel_engine_flush_submission(engine); > igt_spinner_end(&spin); > for (n = 0; n < ARRAY_SIZE(ce); n++) { > if (IS_ERR_OR_NULL(ce[n])) > Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx