From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH v2] drm/i915: Allow MI_LOAD_REGISTER_REG between whitelisted registers. Date: Sat, 07 May 2016 00:02:56 -0700 Message-ID: <3000354.DiZY5DFo9c@eiger> References: <1462442809-1842-1-git-send-email-kenneth@whitecape.org> <1462521014-13595-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0944508998==" Return-path: Received: from smtp105.ord1c.emailsrvr.com (smtp105.ord1c.emailsrvr.com [108.166.43.105]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D8B06E1F5 for ; Sat, 7 May 2016 07:02:59 +0000 (UTC) In-Reply-To: <1462521014-13595-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0944508998== Content-Type: multipart/signed; boundary="nextPart2060681.z0diDuvZ1c"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPart2060681.z0diDuvZ1c Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, May 6, 2016 8:50:14 AM PDT Chris Wilson wrote: > From: Kenneth Graunke > > Allowing register copies where the source and destination are both > whitelisted should be safe, and is useful. For example, Mesa uses > this to load the command streamer math registers with data from the > pipeline statistics counters. > > v2: Reject writes to OACONTROL (and reads as well :( > > Signed-off-by: Kenneth Graunke > Reviewed-by: Chris Wilson # v1 > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_cmd_parser.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) Oh, probably a good call to disallow OACONTROL. Looks good to me. Thanks for fixing this up, Chris :) --nextPart2060681.z0diDuvZ1c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXLZMgAAoJEFtb2gcdScw4/WEQAIR8fXcysee1Dwb0IoVt3AFg Afh0If7DFLBQwxq+jd7ZDwZJ50TIAwjLGsx1+VOmMUOV2DrM8pZFgF71HpHKJIkg UdTHoFyIEH0NwiqVfHXE7E7lyjao5ltiYxPp30ZDbwiJp9FyoQUKw+Z8meC8Du5x 95MQX6g6mPF7zSUI0meHEkhsiay6BKl8qsyklcdkEPLTcx6mAqOCpUMmJ6Tdm/kJ se+Qru5lmaRuoEUfApJ80/wUQKzFNvsu1ZMubkUjZFv3VbxXrV4nds4J/MjU6R2R Aw3mwd00b5oVKZNPQ+kBNsxWEfvv6ff4vFFtRvkMZGp/Ga67GjN6UZDSHV0+B/od N/OMXPab1apBQM+CEq5m9XmMBx009m+Pheii73xdvV7Nsxozs2v3AOHp3/cm/uyO +kyz9yWbpRPnB//d9pW/c/oSU3toaTRnzRqzO+JD4Q2jrtx11ZohyVL3oW47LNjl 6X+/zZKYD6d2MHsjJPidXSdgP/80W+xcQH6C6vD22v5H+HieLdstzUnQN7ZInDCm /do/S4MBmSHDpbo3C0Zf14cgxiQXSvMCpbPCxGD9qzZNJB8vaDXwX2K/hFPEo22C Slts2+hFY8SdE/nY7CcsL64SaPgWOIM4Zrxu3S8Kz4NzGzds5Y6e/ZL1NjwbcbDk gn8ZwXU4ACfC7J1teSJD =ZhQb -----END PGP SIGNATURE----- --nextPart2060681.z0diDuvZ1c-- --===============0944508998== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0944508998==--