From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH] drm/i915: Reinstate error level message for non-simulated gpu hangs Date: Wed, 01 Oct 2014 01:52:20 -0700 Message-ID: <3131970.hs5t3utFuN@vakarian> References: <1412118259-4860-1-git-send-email-daniel.vetter@ffwll.ch> <20141001081950.GQ19278@nuc-i3427.alporthouse.com> <20141001082907.GL12343@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0378509716==" Return-path: Received: from smtp129.dfw.emailsrvr.com (smtp129.dfw.emailsrvr.com [67.192.241.129]) by gabe.freedesktop.org (Postfix) with ESMTP id A0D8D6E4F7 for ; Wed, 1 Oct 2014 01:57:14 -0700 (PDT) In-Reply-To: <20141001082907.GL12343@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Daniel Vetter , Intel Graphics Development , Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org --===============0378509716== Content-Type: multipart/signed; boundary="nextPart15518980.x6pNgXJDao"; micalg="pgp-sha1"; protocol="application/pgp-signature" --nextPart15518980.x6pNgXJDao Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Wednesday, October 01, 2014 10:29:07 AM Daniel Vetter wrote: > On Wed, Oct 01, 2014 at 09:19:50AM +0100, Chris Wilson wrote: > > On Wed, Oct 01, 2014 at 10:13:00AM +0200, Daniel Vetter wrote: > > > On Wed, Oct 01, 2014 at 07:28:39AM +0100, Chris Wilson wrote: > > > > On Wed, Oct 01, 2014 at 01:04:19AM +0200, Daniel Vetter wrote: > > > > > This seems to have been accidentally lost in > > > > >=20 > > > > > commit be62acb4cce1389a28296852737e3917d9cc5b25 > > > > > Author: Mika Kuoppala > > > > > Date: Fri Aug 30 16:19:28 2013 +0300 > > > > >=20 > > > > > drm/i915: ban badly behaving contexts > > > > >=20 > > > > > Without this real gpu hangs only log output at info level, wh= ich gets > > > > > filtered away by piglit's testrunner. > > > >=20 > > > > A successful GPU hang is not an error. Might be a warn or a not= ice, but > > > > it certainly isn't a driver error. > > >=20 > > > Well not of the kernel driver, but might very well be a bug in th= e > > > userspace driver. With this piglit marks tests that hung the gpu = as > > > dmesg-fail, without this they might even pass. Ken raised this on= irc and > > > I agree that it's a must-have feature for developers that their t= estsuite > > > can tell them when stuff broke. Provding this some other way is a= lot more > > > work and imo should be done in a separate patch, this here is jus= t the > > > minimal fix for this regression. > >=20 > > I strongly disagree that we should be working around self-imposed > > limitations of the test suite by making users believe their kernel = is > > broken. >=20 > So what else should piglit do then? > -Daniel Your GPU hanging is clearly more severe than "info" - it may impact you= r system stability, and likely represents a bug somewhere in the graphi= cs drivers (whether kernel or userspace). I think we all agree on that= . Piglit runs "dmesg --level emerg,alert,crit,err,warn,notice", which cov= ers everything except "info" and "debug". So anything other than info/= debug would be just fine. =2D-Ken --nextPart15518980.x6pNgXJDao Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABAgAGBQJUK8DHAAoJEFtb2gcdScw4up0P/0Py/9gky/xs0ABHDW86W0RL 03MH+CFoTFfrVhRSEwnA78jZEgdiO/e1moulHxkvNfJAq2qFm5SnJWxO+S/YrNaQ ulDAnwcFYvmS0qtR8YIR0L95vBB4mKNPsBUPzVnkg2c/C1uglg4fKgXiLn/3QWf3 0KGAQHsTVR0CbgfZtYsO01s+g+e7ijbzD4WSM/aV6KKFSVJ06iGuiaqJYJOzOhrD sx9V43/XDUsBseLamxzB5OuUiPt3NN6XGjsyDa+P8fcGsXFr1ab2vuJgQgzr9qMo c1tww812Rmag7nbim+D/tposNkIB1ALkRJaU+Al4Qm0TBNu1G9pk7Z12x+AxCrvg wvdy3UPC5BxxTj3TFx9feaonN7UR3PJPszzoqObV3RyxqytgbjsczXOjC4v1seeI WYo+AYha8vQOgdNC3TXbtiHv28MLptys8CShkI4yzkjleBG+TSQCUpzKKu/927IH M3KrYzmB8dQdlm+EZUGoH7sEtbhMUaRnHXNmFzy1GUIJyDK3vd4nqU1NT5wB1l3w 3SJB3V6Ie3AjX6dzdFc7gel8JQSgqUPrtWJF4RPRX69LIVxQMxWWYpjzqX12++ZZ iLwi3yGXTu/8Xg3TYOZqQg0DxwfYtz/vYcVaN4K0toYBpuMVb9RyjZWp73Ed52ox q1EAK71KVBVHPRUJf4zk =AxnV -----END PGP SIGNATURE----- --nextPart15518980.x6pNgXJDao-- --===============0378509716== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0378509716==--