From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 2/6] drm/atomic: Unconditionally call prepare_fb. Date: Mon, 19 Dec 2016 14:07:11 +0200 Message-ID: <3183202.995BmsCpkT@avalon> References: <1481204729-9058-1-git-send-email-maarten.lankhorst@linux.intel.com> <20161213171044.cg7ussvzmq7pvtaz@phenom.ffwll.local> <6d82f9b6-9d16-91d1-d176-4a37b09afc44@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <6d82f9b6-9d16-91d1-d176-4a37b09afc44@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgTWFhcnRlbiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDE5IERlYyAy MDE2IDEyOjA4OjE2IE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+IE9wIDEzLTEyLTE2IG9tIDE4 OjEwIHNjaHJlZWYgRGFuaWVsIFZldHRlcjoKPiA+IE9uIFR1ZSwgRGVjIDEzLCAyMDE2IGF0IDAz OjEzOjU0UE0gKzAxMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ID4+IE9wIDA5LTEyLTE2 IG9tIDA5OjI1IHNjaHJlZWYgRGFuaWVsIFZldHRlcjoKPiA+Pj4gT24gRnJpLCBEZWMgMDksIDIw MTYgYXQgMTI6NDI6MTlBTSArMDIwMCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4+IE9u IFRodXJzZGF5IDA4IERlYyAyMDE2IDE2OjQxOjA0IERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPj4+ Pj4gT24gVGh1LCBEZWMgMDgsIDIwMTYgYXQgMDI6NDU6MjVQTSArMDEwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4+Pj4+IEF0b21pYyBkcml2ZXJzIG1heSBzZXQgcHJvcGVydGllcyBs aWtlIHJvdGF0aW9uIG9uIHRoZSBzYW1lIGZiLCB3aGljaAo+ID4+Pj4+PiBtYXkgcmVxdWlyZSBh IGNhbGwgdG8gcHJlcGFyZV9mYiBldmVuIHdoZW4gZnJhbWVidWZmZXIgc3RheXMKPiA+Pj4+Pj4g aWRlbnRpY2FsLgo+ID4+Pj4+PiAKPiA+Pj4+Pj4gSW5zdGVhZCBvZiBoYW5kbGluZyBhbGwgdGhl IHNwZWNpYWwgY2FzZXMgaW4gdGhlIGNvcmUsIGxldCB0aGUgZHJpdmVyCj4gPj4+Pj4+IGRlY2lk ZSB3aGVuIHByZXBhcmVfZmIgYW5kIGNsZWFudXBfZmIgYXJlIG5vb3BzLgo+ID4+Pj4+PiAKPiA+ Pj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4KPiA+Pj4+PiAKPiA+Pj4+PiBJIHRoaW5rIHRoaXMgbWFrZXMgc2Vu c2UsIGJ1dCB3b3VsZCBiZSByZWFsbHkgZ29vZCB0byBnZXQgYSBwaWxlIG9mCj4gPj4+Pj4gYWNr cyBmcm9tIGRyaXZlciBtYWludGFpbmVycyBvbiB0aGlzIG9uZS4gUm9iLCBFcmljLCBMYXVyZW50 LCBvdGhlcnM/Cj4gPj4+PiAKPiA+Pj4+IFRoaXMgaXMgYWxsIHZlcnkgbmljZSwgYnV0IGl0IHdp bGwgaW50cm9kdWNlIGF0IGxlYXN0IGEgcGVyZm9ybWFuY2UKPiA+Pj4+IHJlZ3Jlc3Npb24sIGFu ZCBwb3NzaWJseSB3b3JzZSwgdW50aWwgZHJpdmVycyBnZXQgdXBkYXRlZC4gVGhlcmUgYXJlIDcK PiA+Pj4+IGRyaXZlcnMgaW1wbGVtZW50aW5nIHRoZSAucHJlcGFyZV9mYigpIGNhbGxiYWNrIChw bHVzIGEgYnVuY2ggb2YKPiA+Pj4+IGRyaXZlcnMgdGhhdCBwcm9iYWJseSBzaG91bGQgdXNlIGRy bV9mYl9jbWFfcHJlcGFyZV9mYigpIGJ1dCBkb24ndCBhdAo+ID4+Pj4gdGhlIG1vbWVudCkuIEkg Y2FuJ3QgYWNrIHRoaXMgcGF0Y2ggYmVmb3JlIHRoZXkgZ2V0IGZpeGVkLgo+ID4+PiAKPiA+Pj4g TWFhcnRlbidzIGNvbW1pdCBtZXNzYWdlIGlzIGluc3VmZmljaWVudCwgc2luY2UgdGhpcyBpcyBk ZWZhY3RvIGEgcmV2ZXJ0Cj4gPj4+IG9mCj4gPj4+IAo+ID4+PiBjb21taXQgZmNjNjBiNDEzZDE0 ZGQwNmRkYmQ3OWVjNTBlODNjNGZiMmEwOTdiYQo+ID4+PiBBdXRob3I6IEtlaXRoIFBhY2thcmQg PGtlaXRocEBrZWl0aHAuY29tPgo+ID4+PiBEYXRlOiAgIFNhdCBKdW4gNCAwMToxNjoyMiAyMDE2 IC0wNzAwCj4gPj4+IAo+ID4+PiAgICAgZHJtOiBEb24ndCBwcmVwYXJlIG9yIGNsZWFudXAgdW5j aGFuZ2luZyBmcmFtZSBidWZmZXJzIFt2M10KPiA+Pj4gCj4gPj4+IGJlY2F1c2UgdGhhdCBicmVh a3Mgc3R1ZmYuIFdlJ3JlIHNpbXBseSBnb2luZyBiYWNrIHRvIHdoZXJlIHdlJ3ZlIGJlZW4gYQo+ ID4+PiBmZXcgbW9udGhzIGFnby4gU2luY2UgdGhpcyBpcyBhIHJlZ3Jlc3Npb24gZml4LCBiYWNr IHRvIG9yaWdpbmFsCj4gPj4+IGJlaGF2aW91ciwgY2FuIHlvdSBhY2sgKGFzc3VtaW5nIE1hYXJ0 ZW4gdXBkYXRlcyB0aGUgY29tbWl0IG1lc3NhZ2UgdG8KPiA+Pj4gcmVmbGVjdCB0aGUgbmF0dXJl IG9mIHRoZSBjb21taXQgaGVyZSk/Cj4gPj4gCj4gPj4gV2FpdGluZyBvbiBhIHJlcGx5LCBidXQg d2hhdCBhYm91dCB0aGlzIGNvbW1pdCBtZXNzYWdlIGZvciB0aGlzIHBhdGNoPwo+ID4+IC0tLQo+ ID4+IEF0b21pYyBkcml2ZXJzIG1heSBzZXQgcHJvcGVydGllcyBsaWtlIHJvdGF0aW9uIG9uIHRo ZSBzYW1lIGZiLCB3aGljaAo+ID4+IG1heSByZXF1aXJlIGEgY2FsbCB0byBwcmVwYXJlX2ZiIGV2 ZW4gd2hlbiBmcmFtZWJ1ZmZlciBzdGF5cyBpZGVudGljYWwuCj4gPj4gCj4gPj4gSW5zdGVhZCBv ZiBoYW5kbGluZyBhbGwgdGhlIHNwZWNpYWwgY2FzZXMgaW4gdGhlIGNvcmUsIGxldCB0aGUgZHJp dmVyCj4gPj4gZGVjaWRlIHdoZW4gcHJlcGFyZV9mYiBhbmQgY2xlYW51cF9mYiBhcmUgbm9vcHMu Cj4gPj4gCj4gPj4gVGhpcyBpcyBhIHJldmVydCBvZjoKPiA+PiAKPiA+PiBjb21taXQgZmNjNjBi NDEzZDE0ZGQwNmRkYmQ3OWVjNTBlODNjNGZiMmEwOTdiYQo+ID4+IEF1dGhvcjogS2VpdGggUGFj a2FyZCA8a2VpdGhwQGtlaXRocC5jb20+Cj4gPj4gRGF0ZTogICBTYXQgSnVuIDQgMDE6MTY6MjIg MjAxNiAtMDcwMAo+ID4+IAo+ID4+ICAgICBkcm06IERvbid0IHByZXBhcmUgb3IgY2xlYW51cCB1 bmNoYW5naW5nIGZyYW1lIGJ1ZmZlcnMgW3YzXQo+ID4+IAo+ID4+IFRoZSBvcmlnaW5hbCBjb21t aXQgbWVudGlvbnMgdGhhdCB0aGlzIHByZXZlbnRzIHdhaXRpbmcgaW4gaTkxNSBvbiBhbGwKPiA+ PiBwcmV2aW91cyByZW5kZXJpbmcgZHVyaW5nIGN1cnNvciB1cGRhdGVzLCBidXQgdGhlcmUgYXJl IGJldHRlciB3YXlzIHRvCj4gPj4gZml4IHRoaXMuCj4gPj4gCj4gPj4gU2lnbmVkLW9mZi1ieTog TWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ IAo+ID4gWWVhaCBzb3VuZHMgZ29vZCB0byBtZS4gU2luY2Ugd2UgZG9uJ3Qgd2FudCB0byBiYWNr cG9ydCBhbGwgdGhlIGk5MTUKPiA+IGN1cnNvciBwYXRjaGVzIG5vIGNjOiBzdGFibGUgb24gdGhp cy4gQWxzbywgdGhpcyBpcyBvbmx5IGFuIGlzc3VlIGZvcgo+ID4gZHJpdmVycyB3aGljaCBib3Ro IGhhdmUgYSBjdXJzb3IgcGxhbmUsIGFuZCBpbXBsZW1lbnQgdGhhdCBjdXJzb3IgdXNpbmcKPiA+ IHVuaXZlcnNhbCBwbGFuZXMgKGkuZS4gc2V0dHRpbmcgZHJtX2NydGMtPmN1cnNvcikuIEFmYWlr IHRoZSBvbmx5IHR3byBhcmUKPiA+IHZjNCBhbmQgaTkxNSwgYW5kIGFmdGVyIHRoaXMgc2VyaWVz IGJvdGggd2lsbCBoYXZlIGFwcHJvcHJpYXRlIGhhY2tzIChmb3IKPiA+IG5vdykgdG8ga2VlcCBl eGlzdGluZyB1c2Vyc3BhY2UgaGFwcHkuCj4gPiAtRGFuaWVsCj4gCj4gU2FtZSBwYXRjaCwgcmV3 b3JkZWQhCj4gLS0tODwtLS0KPiBBdG9taWMgZHJpdmVycyBtYXkgc2V0IHByb3BlcnRpZXMgbGlr ZSByb3RhdGlvbiBvbiB0aGUgc2FtZSBmYiwgd2hpY2gKPiBtYXkgcmVxdWlyZSBhIGNhbGwgdG8g cHJlcGFyZV9mYiBldmVuIHdoZW4gZnJhbWVidWZmZXIgc3RheXMgaWRlbnRpY2FsLgo+IAo+IElu c3RlYWQgb2YgaGFuZGxpbmcgYWxsIHRoZSBzcGVjaWFsIGNhc2VzIGluIHRoZSBjb3JlLCBsZXQg dGhlIGRyaXZlcgo+IGRlY2lkZSB3aGVuIHByZXBhcmVfZmIgYW5kIGNsZWFudXBfZmIgYXJlIG5v b3BzLgo+IAo+IFRoaXMgaXMgYSByZXZlcnQgb2Y6Cj4gCj4gY29tbWl0IGZjYzYwYjQxM2QxNGRk MDZkZGJkNzllYzUwZTgzYzRmYjJhMDk3YmEKPiBBdXRob3I6IEtlaXRoIFBhY2thcmQgPGtlaXRo cEBrZWl0aHAuY29tPgo+IERhdGU6ICAgU2F0IEp1biA0IDAxOjE2OjIyIDIwMTYgLTA3MDAKPiAK PiAgICAgZHJtOiBEb24ndCBwcmVwYXJlIG9yIGNsZWFudXAgdW5jaGFuZ2luZyBmcmFtZSBidWZm ZXJzIFt2M10KPiAKPiBUaGUgb3JpZ2luYWwgY29tbWl0IG1lbnRpb25zIHRoYXQgdGhpcyBwcmV2 ZW50cyB3YWl0aW5nIGluIGk5MTUgb24gYWxsCj4gcHJldmlvdXMgcmVuZGVyaW5nIGR1cmluZyBj dXJzb3IgdXBkYXRlcywgYnV0IHRoZXJlIGFyZSBiZXR0ZXIgd2F5cyB0bwo+IGZpeCB0aGlzLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBs aW51eC5pbnRlbC5jb20+CgpBY2tlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5j aGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmMgfCA5IC0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOSBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMK PiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGluZGV4IDIzNzY3ZGY3MjYx NS4uZDE5NTYzNjUxZTA3Cj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ IEBAIC0xNjY0LDkgKzE2NjQsNiBAQCBpbnQgZHJtX2F0b21pY19oZWxwZXJfcHJlcGFyZV9wbGFu ZXMoc3RydWN0IGRybV9kZXZpY2UKPiAqZGV2LAo+IAo+ICAJCWZ1bmNzID0gcGxhbmUtPmhlbHBl cl9wcml2YXRlOwo+IAo+IC0JCWlmICghZHJtX2F0b21pY19oZWxwZXJfZnJhbWVidWZmZXJfY2hh bmdlZChkZXYsIHN0YXRlLAo+IHBsYW5lX3N0YXRlLT5jcnRjKSkgLQkJCWNvbnRpbnVlOwo+IC0K PiAgCQlpZiAoZnVuY3MtPnByZXBhcmVfZmIpIHsKPiAgCQkJcmV0ID0gZnVuY3MtPnByZXBhcmVf ZmIocGxhbmUsIHBsYW5lX3N0YXRlKTsKPiAgCQkJaWYgKHJldCkKPiBAQCAtMTY4Myw5ICsxNjgw LDYgQEAgaW50IGRybV9hdG9taWNfaGVscGVyX3ByZXBhcmVfcGxhbmVzKHN0cnVjdCBkcm1fZGV2 aWNlCj4gKmRldiwgaWYgKGogPj0gaSkKPiAgCQkJY29udGludWU7Cj4gCj4gLQkJaWYgKCFkcm1f YXRvbWljX2hlbHBlcl9mcmFtZWJ1ZmZlcl9jaGFuZ2VkKGRldiwgc3RhdGUsCj4gcGxhbmVfc3Rh dGUtPmNydGMpKSAtCQkJY29udGludWU7Cj4gLQo+ICAJCWZ1bmNzID0gcGxhbmUtPmhlbHBlcl9w cml2YXRlOwo+IAo+ICAJCWlmIChmdW5jcy0+Y2xlYW51cF9mYikKPiBAQCAtMTk1Miw5ICsxOTQ2 LDYgQEAgdm9pZCBkcm1fYXRvbWljX2hlbHBlcl9jbGVhbnVwX3BsYW5lcyhzdHJ1Y3QKPiBkcm1f ZGV2aWNlICpkZXYsIGZvcl9lYWNoX3BsYW5lX2luX3N0YXRlKG9sZF9zdGF0ZSwgcGxhbmUsIHBs YW5lX3N0YXRlLCBpKQo+IHsKPiAgCQljb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX2hlbHBlcl9mdW5j cyAqZnVuY3M7Cj4gCj4gLQkJaWYgKCFkcm1fYXRvbWljX2hlbHBlcl9mcmFtZWJ1ZmZlcl9jaGFu Z2VkKGRldiwgb2xkX3N0YXRlLAo+IHBsYW5lX3N0YXRlLT5jcnRjKSkgLQkJCWNvbnRpbnVlOwo+ IC0KPiAgCQlmdW5jcyA9IHBsYW5lLT5oZWxwZXJfcHJpdmF0ZTsKPiAKPiAgCQlpZiAoZnVuY3Mt PmNsZWFudXBfZmIpCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=