From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/4] drm/i915: Support whitelist workarounds on all engines Date: Tue, 18 Jun 2019 07:29:01 +0100 Message-ID: <32d7e660-26e4-e4b9-3de4-bee49ed0675b@linux.intel.com> References: <20190618010108.27499-1-John.C.Harrison@Intel.com> <20190618010108.27499-3-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B9966E0DA for ; Tue, 18 Jun 2019 06:29:04 +0000 (UTC) In-Reply-To: <20190618010108.27499-3-John.C.Harrison@Intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA2LzIwMTkgMDI6MDEsIEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20gd3JvdGU6Cj4g RnJvbTogSm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPiAKPiBOZXdl ciBoYXJkd2FyZSByZXF1aXJlcyBzZXR0aW5nIHVwIHdoaXRlbGlzdHMgb24gZW5naW5lcyBvdGhl ciB0aGFuCj4gcmVuZGVyLiBTbywgZXh0ZW5kIHRoZSB3aGl0ZWxpc3QgY29kZSB0byBzdXBwb3J0 IGFsbCBlbmdpbmVzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEpvaG4gSGFycmlzb24gPEpvaG4uQy5I YXJyaXNvbkBJbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUm9iZXJ0IE0uIEZvc2hhIDxyb2Jl cnQubS5mb3NoYUBpbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxp bkBpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfd29ya2Fyb3VuZHMuYyB8 IDY2ICsrKysrKysrKysrKysrKy0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQ3IGluc2VydGlv bnMoKyksIDE5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9ndC9pbnRlbF93b3JrYXJvdW5kcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50 ZWxfd29ya2Fyb3VuZHMuYwo+IGluZGV4IGFlODIzNDBmZmY0NS4uNTMwOGEwODY0ZTc4IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmthcm91bmRzLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF93b3JrYXJvdW5kcy5jCj4gQEAgLTEw NDMsNDggKzEwNDMsNzkgQEAgc3RhdGljIHZvaWQgZ2VuOV93aGl0ZWxpc3RfYnVpbGQoc3RydWN0 IGk5MTVfd2FfbGlzdCAqdykKPiAgIAl3aGl0ZWxpc3RfcmVnKHcsIEdFTjhfSERDX0NISUNLRU4x KTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgdm9pZCBza2xfd2hpdGVsaXN0X2J1aWxkKHN0cnVjdCBp OTE1X3dhX2xpc3QgKncpCj4gK3N0YXRpYyB2b2lkIHNrbF93aGl0ZWxpc3RfYnVpbGQoc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgewo+ICsJc3RydWN0IGk5MTVfd2FfbGlzdCAq dyA9ICZlbmdpbmUtPndoaXRlbGlzdDsKPiArCj4gKwlpZiAoZW5naW5lLT5jbGFzcyAhPSBSRU5E RVJfQ0xBU1MpCj4gKwkJcmV0dXJuOwo+ICsKPiAgIAlnZW45X3doaXRlbGlzdF9idWlsZCh3KTsK PiAgIAo+ICAgCS8qIFdhRGlzYWJsZUxTUUNST1BFUkZmb3JPQ0w6c2tsICovCj4gICAJd2hpdGVs aXN0X3JlZyh3LCBHRU44X0wzU1FDUkVHNCk7Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgYnh0 X3doaXRlbGlzdF9idWlsZChzdHJ1Y3QgaTkxNV93YV9saXN0ICp3KQo+ICtzdGF0aWMgdm9pZCBi eHRfd2hpdGVsaXN0X2J1aWxkKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsK PiAtCWdlbjlfd2hpdGVsaXN0X2J1aWxkKHcpOwo+ICsJaWYgKGVuZ2luZS0+Y2xhc3MgIT0gUkVO REVSX0NMQVNTKQo+ICsJCXJldHVybjsKPiArCj4gKwlnZW45X3doaXRlbGlzdF9idWlsZCgmZW5n aW5lLT53aGl0ZWxpc3QpOwo+ICAgfQo+ICAgCj4gLXN0YXRpYyB2b2lkIGtibF93aGl0ZWxpc3Rf YnVpbGQoc3RydWN0IGk5MTVfd2FfbGlzdCAqdykKPiArc3RhdGljIHZvaWQga2JsX3doaXRlbGlz dF9idWlsZChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICB7Cj4gKwlzdHJ1Y3Qg aTkxNV93YV9saXN0ICp3ID0gJmVuZ2luZS0+d2hpdGVsaXN0Owo+ICsKPiArCWlmIChlbmdpbmUt PmNsYXNzICE9IFJFTkRFUl9DTEFTUykKPiArCQlyZXR1cm47Cj4gKwo+ICAgCWdlbjlfd2hpdGVs aXN0X2J1aWxkKHcpOwo+ICAgCj4gICAJLyogV2FEaXNhYmxlTFNRQ1JPUEVSRmZvck9DTDprYmwg Ki8KPiAgIAl3aGl0ZWxpc3RfcmVnKHcsIEdFTjhfTDNTUUNSRUc0KTsKPiAgIH0KPiAgIAo+IC1z dGF0aWMgdm9pZCBnbGtfd2hpdGVsaXN0X2J1aWxkKHN0cnVjdCBpOTE1X3dhX2xpc3QgKncpCj4g K3N0YXRpYyB2b2lkIGdsa193aGl0ZWxpc3RfYnVpbGQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAq ZW5naW5lKQo+ICAgewo+ICsJc3RydWN0IGk5MTVfd2FfbGlzdCAqdyA9ICZlbmdpbmUtPndoaXRl bGlzdDsKPiArCj4gKwlpZiAoZW5naW5lLT5jbGFzcyAhPSBSRU5ERVJfQ0xBU1MpCj4gKwkJcmV0 dXJuOwo+ICsKPiAgIAlnZW45X3doaXRlbGlzdF9idWlsZCh3KTsKPiAgIAo+ICAgCS8qIFdBICMw ODYyOiBVc2Vyc3BhY2UgaGFzIHRvIHNldCAiQmFycmllciBNb2RlIiB0byBhdm9pZCBoYW5ncy4g Ki8KPiAgIAl3aGl0ZWxpc3RfcmVnKHcsIEdFTjlfU0xJQ0VfQ09NTU9OX0VDT19DSElDS0VOMSk7 Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgY2ZsX3doaXRlbGlzdF9idWlsZChzdHJ1Y3QgaTkx NV93YV9saXN0ICp3KQo+ICtzdGF0aWMgdm9pZCBjZmxfd2hpdGVsaXN0X2J1aWxkKHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAtCWdlbjlfd2hpdGVsaXN0X2J1aWxkKHcp Owo+ICsJaWYgKGVuZ2luZS0+Y2xhc3MgIT0gUkVOREVSX0NMQVNTKQo+ICsJCXJldHVybjsKPiAr Cj4gKwlnZW45X3doaXRlbGlzdF9idWlsZCgmZW5naW5lLT53aGl0ZWxpc3QpOwo+ICAgfQo+ICAg Cj4gLXN0YXRpYyB2b2lkIGNubF93aGl0ZWxpc3RfYnVpbGQoc3RydWN0IGk5MTVfd2FfbGlzdCAq dykKPiArc3RhdGljIHZvaWQgY25sX3doaXRlbGlzdF9idWlsZChzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICplbmdpbmUpCj4gICB7Cj4gKwlzdHJ1Y3QgaTkxNV93YV9saXN0ICp3ID0gJmVuZ2luZS0+ d2hpdGVsaXN0Owo+ICsKPiArCWlmIChlbmdpbmUtPmNsYXNzICE9IFJFTkRFUl9DTEFTUykKPiAr CQlyZXR1cm47Cj4gKwo+ICAgCS8qIFdhRW5hYmxlUHJlZW1wdGlvbkdyYW51bGFyaXR5Q29udHJv bEJ5VU1EOmNubCAqLwo+ICAgCXdoaXRlbGlzdF9yZWcodywgR0VOOF9DU19DSElDS0VOMSk7Cj4g ICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgaWNsX3doaXRlbGlzdF9idWlsZChzdHJ1Y3QgaTkxNV93 YV9saXN0ICp3KQo+ICtzdGF0aWMgdm9pZCBpY2xfd2hpdGVsaXN0X2J1aWxkKHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiArCXN0cnVjdCBpOTE1X3dhX2xpc3QgKncgPSAm ZW5naW5lLT53aGl0ZWxpc3Q7Cj4gKwo+ICsJaWYgKGVuZ2luZS0+Y2xhc3MgIT0gUkVOREVSX0NM QVNTKQo+ICsJCXJldHVybjsKPiArCj4gICAJLyogV2FBbGxvd1VNRFRvTW9kaWZ5SGFsZlNsaWNl Q2hpY2tlbjc6aWNsICovCj4gICAJd2hpdGVsaXN0X3JlZyh3LCBHRU45X0hBTEZfU0xJQ0VfQ0hJ Q0tFTjcpOwo+ICAgCj4gQEAgLTExMDAsMjUgKzExMzEsMjIgQEAgdm9pZCBpbnRlbF9lbmdpbmVf aW5pdF93aGl0ZWxpc3Qoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICppOTE1ID0gZW5naW5lLT5pOTE1Owo+ICAgCXN0cnVjdCBpOTE1 X3dhX2xpc3QgKncgPSAmZW5naW5lLT53aGl0ZWxpc3Q7Cj4gICAKPiAtCWlmIChlbmdpbmUtPmNs YXNzICE9IFJFTkRFUl9DTEFTUykKPiAtCQlyZXR1cm47Cj4gLQo+ICAgCXdhX2luaXRfc3RhcnQo dywgIndoaXRlbGlzdCIpOwo+ICAgCj4gICAJaWYgKElTX0dFTihpOTE1LCAxMSkpCj4gLQkJaWNs X3doaXRlbGlzdF9idWlsZCh3KTsKPiArCQlpY2xfd2hpdGVsaXN0X2J1aWxkKGVuZ2luZSk7Cj4g ICAJZWxzZSBpZiAoSVNfQ0FOTk9OTEFLRShpOTE1KSkKPiAtCQljbmxfd2hpdGVsaXN0X2J1aWxk KHcpOwo+ICsJCWNubF93aGl0ZWxpc3RfYnVpbGQoZW5naW5lKTsKPiAgIAllbHNlIGlmIChJU19D T0ZGRUVMQUtFKGk5MTUpKQo+IC0JCWNmbF93aGl0ZWxpc3RfYnVpbGQodyk7Cj4gKwkJY2ZsX3do aXRlbGlzdF9idWlsZChlbmdpbmUpOwo+ICAgCWVsc2UgaWYgKElTX0dFTUlOSUxBS0UoaTkxNSkp Cj4gLQkJZ2xrX3doaXRlbGlzdF9idWlsZCh3KTsKPiArCQlnbGtfd2hpdGVsaXN0X2J1aWxkKGVu Z2luZSk7Cj4gICAJZWxzZSBpZiAoSVNfS0FCWUxBS0UoaTkxNSkpCj4gLQkJa2JsX3doaXRlbGlz dF9idWlsZCh3KTsKPiArCQlrYmxfd2hpdGVsaXN0X2J1aWxkKGVuZ2luZSk7Cj4gICAJZWxzZSBp ZiAoSVNfQlJPWFRPTihpOTE1KSkKPiAtCQlieHRfd2hpdGVsaXN0X2J1aWxkKHcpOwo+ICsJCWJ4 dF93aGl0ZWxpc3RfYnVpbGQoZW5naW5lKTsKPiAgIAllbHNlIGlmIChJU19TS1lMQUtFKGk5MTUp KQo+IC0JCXNrbF93aGl0ZWxpc3RfYnVpbGQodyk7Cj4gKwkJc2tsX3doaXRlbGlzdF9idWlsZChl bmdpbmUpOwo+ICAgCWVsc2UgaWYgKElOVEVMX0dFTihpOTE1KSA8PSA4KQo+ICAgCQlyZXR1cm47 Cj4gICAJZWxzZQo+IAoKIEZyb20gbGFzdCByb3VuZDoKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJz dWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=