From: Kenneth Graunke <kenneth@whitecape.org>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel_aubdump: Default to 64-bit AUBs when the gen is unknown
Date: Mon, 09 Oct 2017 18:17:42 -0700 [thread overview]
Message-ID: <3329245.usB7SrW3Ws@kirito> (raw)
In-Reply-To: <20170915003424.2322-2-jordan.l.justen@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]
On Thursday, September 14, 2017 5:34:24 PM PDT Jordan Justen wrote:
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> ---
> tools/aubdump.c | 26 ++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/tools/aubdump.c b/tools/aubdump.c
> index 788bed13..893ddf93 100644
> --- a/tools/aubdump.c
> +++ b/tools/aubdump.c
> @@ -58,6 +58,7 @@ static int gen = 0;
> static int verbose = 0;
> static bool device_override;
> static uint32_t device;
> +static bool use_64bit = false;
It might be better to call this use_48bit_addrs, to clarify that this
isn't about 32-bit or 64-bit OSes.
Either way,
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-10 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 0:34 [PATCH] intel_aubdump: Default to 64-bit AUBs when the gen is unknown Jordan Justen
2017-10-10 1:17 ` Kenneth Graunke [this message]
2017-10-10 23:05 ` [PATCH i-g-t v2] intel_aubdump: Default to 48-bit " Jordan Justen
2017-10-10 23:26 ` Kenneth Graunke
2017-10-10 23:44 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-11 12:17 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3329245.usB7SrW3Ws@kirito \
--to=kenneth@whitecape.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox