From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH] intel_aubdump: Default to 64-bit AUBs when the gen is unknown Date: Mon, 09 Oct 2017 18:17:42 -0700 Message-ID: <3329245.usB7SrW3Ws@kirito> References: <20170915003424.2322-2-jordan.l.justen@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0257812719==" Return-path: Received: from smtp105.iad3a.emailsrvr.com (smtp105.iad3a.emailsrvr.com [173.203.187.105]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEF3C6E165 for ; Tue, 10 Oct 2017 01:26:41 +0000 (UTC) In-Reply-To: <20170915003424.2322-2-jordan.l.justen@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0257812719== Content-Type: multipart/signed; boundary="nextPart1601636.tC93S1HNdb"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPart1601636.tC93S1HNdb Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Thursday, September 14, 2017 5:34:24 PM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > tools/aubdump.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) > > diff --git a/tools/aubdump.c b/tools/aubdump.c > index 788bed13..893ddf93 100644 > --- a/tools/aubdump.c > +++ b/tools/aubdump.c > @@ -58,6 +58,7 @@ static int gen = 0; > static int verbose = 0; > static bool device_override; > static uint32_t device; > +static bool use_64bit = false; It might be better to call this use_48bit_addrs, to clarify that this isn't about 32-bit or 64-bit OSes. Either way, Reviewed-by: Kenneth Graunke --nextPart1601636.tC93S1HNdb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE6OtbNAgc4e6ibv4ZW1vaBx1JzDgFAlncH7YACgkQW1vaBx1J zDgmQg//ai5FJ51Sh2MvqPTsJ/XcEAnFQTG4DDMvh73Lu8DGf8o4RIHcHQEDLza1 UF77Eqc5tHUVbGklMW44NApRW2OC3R86aH/jT235mRYj5pjQeGGoTz4MIIxOpeBC XsWUVNdosDrwE0b4l1HB5MbTcrqJbqT+Vg7WjewJS150n763HiTw248akGeVlBi5 g3Zl8L+ygfvrMhbO3wnltpwomh1dk+Y3pmb55debaafCSCIERDz6croqt0Zj4kI3 UY96T5xgH8If0icFP8TYmHAA/ntw01+c96wMk/hBqZpBX6dnvpTJJb3A+YANsadM rjT2ZZDCxHBqwD8InN8ZtACNZxrV/J0li9vxwOIDNXINmgWd3WIHe35i8LvEEUjK 0GcX0gNjV6LrDzZJWa4/BmqgGsVRn3DxkfzLtxWSNwGUX+U65bZdOwF0+NByMrnx /5BMs/7S5SzXslnQ9yBzxsXDmP2pwbUmzxDRWQtqonmu1Q9hx1Ok2UPfocJjJaNk 7rQo4OBfPNwaSD4uT9DuE6mzsYZTA+fBHlsyh8bwUVLiLSW5FkDhmsThE+lEaUhE yuRh0mGGTnGuV8Pxm3lat11V2n+05+1ydpAxkIV4iXBFLBvG8QelobroMsI2bbfs phGGnnZDPkMlx9WOPdhmwllKMvVav6tkS7wc4yjGhIBN2da+TKA= =Kd2y -----END PGP SIGNATURE----- --nextPart1601636.tC93S1HNdb-- --===============0257812719== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0257812719==--