Re: [PATCH] intel_aubdump: Default to 64-bit AUBs when the gen is unknown

Kenneth Graunke
2017-10-10T01:26:41Z

[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]

On Thursday, September 14, 2017 5:34:24 PM PDT Jordan Justen wrote:
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> ---
> tools/aubdump.c | 26 ++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/tools/aubdump.c b/tools/aubdump.c
> index 788bed13..893ddf93 100644
> --- a/tools/aubdump.c
> +++ b/tools/aubdump.c
> @@ -58,6 +58,7 @@ static int gen = 0;
> static int verbose = 0;
> static bool device_override;
> static uint32_t device;
> +static bool use_64bit = false;

It might be better to call this use_48bit_addrs, to clarify that this
isn't about 32-bit or 64-bit OSes.

Either way,
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]