From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 1/3] ACPI / LPSS: Rename pwm_backlight pwm-lookup to pwm_soc_backlight Date: Fri, 29 Nov 2019 12:59:40 +0100 Message-ID: <3461808.dMKB6b565b@kreacher> References: <20191119151818.67531-1-hdegoede@redhat.com> <20191119151818.67531-2-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20191119151818.67531-2-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Hans de Goede Cc: Maarten Lankhorst , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Len Brown , Lee Jones , Andy Shevchenko , linux-acpi@vger.kernel.org, intel-gfx , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Tuesday, November 19, 2019 4:18:16 PM CET Hans de Goede wrote: > At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 > different PWM controllers for controlling the LCD's backlight brightness. > Either the one integrated into the PMIC or the one integrated into the > SoC (the 1st LPSS PWM controller). > > So far in the LPSS code on BYT we have skipped registering the LPSS PWM > controller "pwm_backlight" lookup entry when a Crystal Cove PMIC is > present, assuming that in this case the PMIC PWM controller will be used. > > On CHT we have been relying on only 1 of the 2 PWM controllers being > enabled in the DSDT at the same time; and always registered the lookup. > > So far this has been working, but the correct way to determine which PWM > controller needs to be used is by checking a bit in the VBT table and > recently I've learned about 2 different BYT devices: > Point of View MOBII TAB-P800W > Acer Switch 10 SW5-012 > > Which use a Crystal Cove PMIC, yet the LCD is connected to the SoC/LPSS > PWM controller (and the VBT correctly indicates this), so here our old > heuristics fail. > > Since only the i915 driver has access to the VBT, this commit renames > the "pwm_backlight" lookup entries for the 1st BYT/CHT LPSS PWM controller > to "pwm_soc_backlight" so that the i915 driver can do a pwm_get() for > the right controller depending on the VBT bit, instead of the i915 driver > relying on a "pwm_backlight" lookup getting registered which magically > points to the right controller. > > Signed-off-by: Hans de Goede Acked-by: Rafael J. Wysocki Or please let me know if you want me to take the whole series. Thanks! > --- > drivers/acpi/acpi_lpss.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c > index 751ed38f2a10..63e81d8e675b 100644 > --- a/drivers/acpi/acpi_lpss.c > +++ b/drivers/acpi/acpi_lpss.c > @@ -69,10 +69,6 @@ ACPI_MODULE_NAME("acpi_lpss"); > #define LPSS_SAVE_CTX BIT(4) > #define LPSS_NO_D3_DELAY BIT(5) > > -/* Crystal Cove PMIC shares same ACPI ID between different platforms */ > -#define BYT_CRC_HRV 2 > -#define CHT_CRC_HRV 3 > - > struct lpss_private_data; > > struct lpss_device_desc { > @@ -158,7 +154,7 @@ static void lpss_deassert_reset(struct lpss_private_data *pdata) > */ > static struct pwm_lookup byt_pwm_lookup[] = { > PWM_LOOKUP_WITH_MODULE("80860F09:00", 0, "0000:00:02.0", > - "pwm_backlight", 0, PWM_POLARITY_NORMAL, > + "pwm_soc_backlight", 0, PWM_POLARITY_NORMAL, > "pwm-lpss-platform"), > }; > > @@ -170,8 +166,7 @@ static void byt_pwm_setup(struct lpss_private_data *pdata) > if (!adev->pnp.unique_id || strcmp(adev->pnp.unique_id, "1")) > return; > > - if (!acpi_dev_present("INT33FD", NULL, BYT_CRC_HRV)) > - pwm_add_table(byt_pwm_lookup, ARRAY_SIZE(byt_pwm_lookup)); > + pwm_add_table(byt_pwm_lookup, ARRAY_SIZE(byt_pwm_lookup)); > } > > #define LPSS_I2C_ENABLE 0x6c > @@ -204,7 +199,7 @@ static void byt_i2c_setup(struct lpss_private_data *pdata) > /* BSW PWM used for backlight control by the i915 driver */ > static struct pwm_lookup bsw_pwm_lookup[] = { > PWM_LOOKUP_WITH_MODULE("80862288:00", 0, "0000:00:02.0", > - "pwm_backlight", 0, PWM_POLARITY_NORMAL, > + "pwm_soc_backlight", 0, PWM_POLARITY_NORMAL, > "pwm-lpss-platform"), > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7318C432C0 for ; Fri, 29 Nov 2019 12:06:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 921C020869 for ; Fri, 29 Nov 2019 12:06:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 921C020869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 302126E8F0; Fri, 29 Nov 2019 12:06:24 +0000 (UTC) X-Greylist: delayed 399 seconds by postgrey-1.36 at gabe; Fri, 29 Nov 2019 12:06:22 UTC Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E6D56E8F0 for ; Fri, 29 Nov 2019 12:06:22 +0000 (UTC) Received: from 79.184.255.242.ipv4.supernova.orange.pl (79.184.255.242) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.320) id 0bd48a9c974178a2; Fri, 29 Nov 2019 12:59:40 +0100 From: "Rafael J. Wysocki" To: Hans de Goede Date: Fri, 29 Nov 2019 12:59:40 +0100 Message-ID: <3461808.dMKB6b565b@kreacher> In-Reply-To: <20191119151818.67531-2-hdegoede@redhat.com> References: <20191119151818.67531-1-hdegoede@redhat.com> <20191119151818.67531-2-hdegoede@redhat.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 1/3] ACPI / LPSS: Rename pwm_backlight pwm-lookup to pwm_soc_backlight X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, Andy Shevchenko , Lee Jones , Len Brown Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191129115940.3kj5dEU5xx2_o7MjSHcBzzIN8A-QOnCooLjN96DSnYc@z> T24gVHVlc2RheSwgTm92ZW1iZXIgMTksIDIwMTkgNDoxODoxNiBQTSBDRVQgSGFucyBkZSBHb2Vk ZSB3cm90ZToKPiBBdCBsZWFzdCBCYXkgVHJhaWwgKEJZVCkgYW5kIENoZXJyeSBUcmFpbCAoQ0hU KSBkZXZpY2VzIGNhbiB1c2UgMSBvZiAyCj4gZGlmZmVyZW50IFBXTSBjb250cm9sbGVycyBmb3Ig Y29udHJvbGxpbmcgdGhlIExDRCdzIGJhY2tsaWdodCBicmlnaHRuZXNzLgo+IEVpdGhlciB0aGUg b25lIGludGVncmF0ZWQgaW50byB0aGUgUE1JQyBvciB0aGUgb25lIGludGVncmF0ZWQgaW50byB0 aGUKPiBTb0MgKHRoZSAxc3QgTFBTUyBQV00gY29udHJvbGxlcikuCj4gCj4gU28gZmFyIGluIHRo ZSBMUFNTIGNvZGUgb24gQllUIHdlIGhhdmUgc2tpcHBlZCByZWdpc3RlcmluZyB0aGUgTFBTUyBQ V00KPiBjb250cm9sbGVyICJwd21fYmFja2xpZ2h0IiBsb29rdXAgZW50cnkgd2hlbiBhIENyeXN0 YWwgQ292ZSBQTUlDIGlzCj4gcHJlc2VudCwgYXNzdW1pbmcgdGhhdCBpbiB0aGlzIGNhc2UgdGhl IFBNSUMgUFdNIGNvbnRyb2xsZXIgd2lsbCBiZSB1c2VkLgo+IAo+IE9uIENIVCB3ZSBoYXZlIGJl ZW4gcmVseWluZyBvbiBvbmx5IDEgb2YgdGhlIDIgUFdNIGNvbnRyb2xsZXJzIGJlaW5nCj4gZW5h YmxlZCBpbiB0aGUgRFNEVCBhdCB0aGUgc2FtZSB0aW1lOyBhbmQgYWx3YXlzIHJlZ2lzdGVyZWQg dGhlIGxvb2t1cC4KPiAKPiBTbyBmYXIgdGhpcyBoYXMgYmVlbiB3b3JraW5nLCBidXQgdGhlIGNv cnJlY3Qgd2F5IHRvIGRldGVybWluZSB3aGljaCBQV00KPiBjb250cm9sbGVyIG5lZWRzIHRvIGJl IHVzZWQgaXMgYnkgY2hlY2tpbmcgYSBiaXQgaW4gdGhlIFZCVCB0YWJsZSBhbmQKPiByZWNlbnRs eSBJJ3ZlIGxlYXJuZWQgYWJvdXQgMiBkaWZmZXJlbnQgQllUIGRldmljZXM6Cj4gUG9pbnQgb2Yg VmlldyBNT0JJSSBUQUItUDgwMFcKPiBBY2VyIFN3aXRjaCAxMCBTVzUtMDEyCj4gCj4gV2hpY2gg dXNlIGEgQ3J5c3RhbCBDb3ZlIFBNSUMsIHlldCB0aGUgTENEIGlzIGNvbm5lY3RlZCB0byB0aGUg U29DL0xQU1MKPiBQV00gY29udHJvbGxlciAoYW5kIHRoZSBWQlQgY29ycmVjdGx5IGluZGljYXRl cyB0aGlzKSwgc28gaGVyZSBvdXIgb2xkCj4gaGV1cmlzdGljcyBmYWlsLgo+IAo+IFNpbmNlIG9u bHkgdGhlIGk5MTUgZHJpdmVyIGhhcyBhY2Nlc3MgdG8gdGhlIFZCVCwgdGhpcyBjb21taXQgcmVu YW1lcwo+IHRoZSAicHdtX2JhY2tsaWdodCIgbG9va3VwIGVudHJpZXMgZm9yIHRoZSAxc3QgQllU L0NIVCBMUFNTIFBXTSBjb250cm9sbGVyCj4gdG8gInB3bV9zb2NfYmFja2xpZ2h0IiBzbyB0aGF0 IHRoZSBpOTE1IGRyaXZlciBjYW4gZG8gYSBwd21fZ2V0KCkgZm9yCj4gdGhlIHJpZ2h0IGNvbnRy b2xsZXIgZGVwZW5kaW5nIG9uIHRoZSBWQlQgYml0LCBpbnN0ZWFkIG9mIHRoZSBpOTE1IGRyaXZl cgo+IHJlbHlpbmcgb24gYSAicHdtX2JhY2tsaWdodCIgbG9va3VwIGdldHRpbmcgcmVnaXN0ZXJl ZCB3aGljaCBtYWdpY2FsbHkKPiBwb2ludHMgdG8gdGhlIHJpZ2h0IGNvbnRyb2xsZXIuCj4gCj4g U2lnbmVkLW9mZi1ieTogSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KCkFja2Vk LWJ5OiBSYWZhZWwgSi4gV3lzb2NraSA8cmFmYWVsLmoud3lzb2NraUBpbnRlbC5jb20+CgpPciBw bGVhc2UgbGV0IG1lIGtub3cgaWYgeW91IHdhbnQgbWUgdG8gdGFrZSB0aGUgd2hvbGUgc2VyaWVz LgoKVGhhbmtzIQoKPiAtLS0KPiAgZHJpdmVycy9hY3BpL2FjcGlfbHBzcy5jIHwgMTEgKysrLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hY3BpL2FjcGlfbHBzcy5jIGIvZHJpdmVycy9hY3Bp L2FjcGlfbHBzcy5jCj4gaW5kZXggNzUxZWQzOGYyYTEwLi42M2U4MWQ4ZTY3NWIgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9hY3BpL2FjcGlfbHBzcy5jCj4gKysrIGIvZHJpdmVycy9hY3BpL2FjcGlf bHBzcy5jCj4gQEAgLTY5LDEwICs2OSw2IEBAIEFDUElfTU9EVUxFX05BTUUoImFjcGlfbHBzcyIp Owo+ICAjZGVmaW5lIExQU1NfU0FWRV9DVFgJCQlCSVQoNCkKPiAgI2RlZmluZSBMUFNTX05PX0Qz X0RFTEFZCQlCSVQoNSkKPiAgCj4gLS8qIENyeXN0YWwgQ292ZSBQTUlDIHNoYXJlcyBzYW1lIEFD UEkgSUQgYmV0d2VlbiBkaWZmZXJlbnQgcGxhdGZvcm1zICovCj4gLSNkZWZpbmUgQllUX0NSQ19I UlYJCQkyCj4gLSNkZWZpbmUgQ0hUX0NSQ19IUlYJCQkzCj4gLQo+ICBzdHJ1Y3QgbHBzc19wcml2 YXRlX2RhdGE7Cj4gIAo+ICBzdHJ1Y3QgbHBzc19kZXZpY2VfZGVzYyB7Cj4gQEAgLTE1OCw3ICsx NTQsNyBAQCBzdGF0aWMgdm9pZCBscHNzX2RlYXNzZXJ0X3Jlc2V0KHN0cnVjdCBscHNzX3ByaXZh dGVfZGF0YSAqcGRhdGEpCj4gICAqLwo+ICBzdGF0aWMgc3RydWN0IHB3bV9sb29rdXAgYnl0X3B3 bV9sb29rdXBbXSA9IHsKPiAgCVBXTV9MT09LVVBfV0lUSF9NT0RVTEUoIjgwODYwRjA5OjAwIiwg MCwgIjAwMDA6MDA6MDIuMCIsCj4gLQkJCSAgICAgICAicHdtX2JhY2tsaWdodCIsIDAsIFBXTV9Q T0xBUklUWV9OT1JNQUwsCj4gKwkJCSAgICAgICAicHdtX3NvY19iYWNrbGlnaHQiLCAwLCBQV01f UE9MQVJJVFlfTk9STUFMLAo+ICAJCQkgICAgICAgInB3bS1scHNzLXBsYXRmb3JtIiksCj4gIH07 Cj4gIAo+IEBAIC0xNzAsOCArMTY2LDcgQEAgc3RhdGljIHZvaWQgYnl0X3B3bV9zZXR1cChzdHJ1 Y3QgbHBzc19wcml2YXRlX2RhdGEgKnBkYXRhKQo+ICAJaWYgKCFhZGV2LT5wbnAudW5pcXVlX2lk IHx8IHN0cmNtcChhZGV2LT5wbnAudW5pcXVlX2lkLCAiMSIpKQo+ICAJCXJldHVybjsKPiAgCj4g LQlpZiAoIWFjcGlfZGV2X3ByZXNlbnQoIklOVDMzRkQiLCBOVUxMLCBCWVRfQ1JDX0hSVikpCj4g LQkJcHdtX2FkZF90YWJsZShieXRfcHdtX2xvb2t1cCwgQVJSQVlfU0laRShieXRfcHdtX2xvb2t1 cCkpOwo+ICsJcHdtX2FkZF90YWJsZShieXRfcHdtX2xvb2t1cCwgQVJSQVlfU0laRShieXRfcHdt X2xvb2t1cCkpOwo+ICB9Cj4gIAo+ICAjZGVmaW5lIExQU1NfSTJDX0VOQUJMRQkJCTB4NmMKPiBA QCAtMjA0LDcgKzE5OSw3IEBAIHN0YXRpYyB2b2lkIGJ5dF9pMmNfc2V0dXAoc3RydWN0IGxwc3Nf cHJpdmF0ZV9kYXRhICpwZGF0YSkKPiAgLyogQlNXIFBXTSB1c2VkIGZvciBiYWNrbGlnaHQgY29u dHJvbCBieSB0aGUgaTkxNSBkcml2ZXIgKi8KPiAgc3RhdGljIHN0cnVjdCBwd21fbG9va3VwIGJz d19wd21fbG9va3VwW10gPSB7Cj4gIAlQV01fTE9PS1VQX1dJVEhfTU9EVUxFKCI4MDg2MjI4ODow MCIsIDAsICIwMDAwOjAwOjAyLjAiLAo+IC0JCQkgICAgICAgInB3bV9iYWNrbGlnaHQiLCAwLCBQ V01fUE9MQVJJVFlfTk9STUFMLAo+ICsJCQkgICAgICAgInB3bV9zb2NfYmFja2xpZ2h0IiwgMCwg UFdNX1BPTEFSSVRZX05PUk1BTCwKPiAgCQkJICAgICAgICJwd20tbHBzcy1wbGF0Zm9ybSIpLAo+ ICB9Owo+ICAKPiAKCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeA==