From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abdiel Janulgue Subject: Re: [RFC] xf86-video-intel: enable hw-generated binding tables Date: Thu, 24 Apr 2014 14:22:36 +0300 Message-ID: <3553696.JPyDtcldpQ@abj-desktop> References: <1398179796-5103-1-git-send-email-abdiel.janulgue@linux.intel.com> <7920834.6vm1cbEC2H@abj-desktop> <20140424101714.GP18465@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id A09F86E048 for ; Thu, 24 Apr 2014 04:16:50 -0700 (PDT) In-Reply-To: <20140424101714.GP18465@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Thursday, April 24, 2014 01:17:14 PM Ville Syrj=E4l=E4 wrote: > On Thu, Apr 24, 2014 at 11:25:15AM +0300, Abdiel Janulgue wrote: > > On Thursday, April 24, 2014 07:06:34 AM Chris Wilson wrote: > > > On Thu, Apr 24, 2014 at 09:08:14AM +0300, Abdiel Janulgue wrote: > > > > Anyway I haven't tried the work-around where we explictly only disa= ble > > > > the > > > > BT and RS on the other user-space clients (xorg driver in this case) > > > > when > > > > Mesa is using RS instead of forcing the reset of the clients to use= RS > > > > format. I'll try that first and let you know if it works. > > = > > I hate to break the bad news. Tried this just now - still get hangs :( > > = > > So I guess, all userspace clients* does need to use RS-format if we use > > this feature. GPGPU workloads seems to be special use-case where the RS > > hwbinding table format can be disabled. Otherwise, I guess we are stuck > > with this inflexibility. > = > The spec also says this: > "When switching between HW and SW binding table generation, > SW must issue a state cache invalidate." > = > So it does look like they were expecting people to switch between the > two modes. Yep, the previous work-around did include a state cache invalidate. > = > Do you have any igt test for RS? Maybe add an option into rendercopy to > make use of RS? Then we could write some tests that try to hit this > problem w/o requiring Mesa. Seems to be a good idea. I'll try to reproduce the problem with igt > = > > [1] > > On the other hand, it doesn't seem all that bad though. The RS hw-bindi= ng > > table format are only needed for clients that submit vertex and pixel > > shader commands. I've identified currently just UXA and SNA that seem to > > use this besides Mesa. OpenCL is not affected. > > = > > > > If it does, it > > > > might be more efficient to do that in the kernel? > > > = > > > It has to be done in the kernel in order for interoperability with th= ird > > > party clients. > > > -Chris