From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 07/15] drm/omap: Use per-plane rotation property Date: Thu, 6 Oct 2016 12:59:17 +0300 Message-ID: <35cbb9de-1e50-b33d-ed77-8cfd339404ae@ti.com> References: <1474907460-10717-1-git-send-email-ville.syrjala@linux.intel.com> <1474907460-10717-8-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0267069694==" Return-path: In-Reply-To: <1474907460-10717-8-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0267069694== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TdgO6ulvGbAF2td54GkBLjTQPOfh09vpQ" --TdgO6ulvGbAF2td54GkBLjTQPOfh09vpQ Content-Type: multipart/mixed; boundary="ShOBCVpwUDxEcGB8x0mp4INCLvMSUc8tK"; protected-headers="v1" From: Tomi Valkeinen To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Rob Clark Message-ID: <35cbb9de-1e50-b33d-ed77-8cfd339404ae@ti.com> Subject: Re: [PATCH v2 07/15] drm/omap: Use per-plane rotation property References: <1474907460-10717-1-git-send-email-ville.syrjala@linux.intel.com> <1474907460-10717-8-git-send-email-ville.syrjala@linux.intel.com> In-Reply-To: <1474907460-10717-8-git-send-email-ville.syrjala@linux.intel.com> --ShOBCVpwUDxEcGB8x0mp4INCLvMSUc8tK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/09/16 19:30, ville.syrjala@linux.intel.com wrote: > From: Ville Syrj=C3=A4l=C3=A4 >=20 > The global mode_config.rotation_property is going away, switch over to > per-plane rotation_property. >=20 > Not sure I got the annoying crtc rotation_property handling right. > Might work, or migth not. >=20 > v2: Drop the BIT() > Don't create rotation property twice for each primary plane >=20 > Cc: Tomi Valkeinen > Cc: Rob Clark > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 > --- > diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/oma= pdrm/omap_plane.c > index 6ddaa5ea4b6b..b272f810989e 100644 > --- a/drivers/gpu/drm/omapdrm/omap_plane.c > +++ b/drivers/gpu/drm/omapdrm/omap_plane.c > @@ -211,9 +211,16 @@ void omap_plane_install_properties(struct drm_plan= e *plane, > struct omap_drm_private *priv =3D dev->dev_private; > =20 > if (priv->has_dmm) { > - struct drm_property *prop =3D dev->mode_config.rotation_property; > - > - drm_object_attach_property(obj, prop, DRM_ROTATE_0); > + if (!plane->rotation_property) > + drm_plane_create_rotation_property(plane, > + DRM_ROTATE_0, > + DRM_ROTATE_0 | DRM_ROTATE_90 | > + DRM_ROTATE_180 | DRM_ROTATE_270 | > + DRM_REFLECT_X | DRM_REFLECT_Y); > + > + if (plane->rotation_property && obj !=3D &plane->base) > + drm_object_attach_property(obj, plane->rotation_property, > + DRM_ROTATE_0); I think this could use a short comment, as it's not obvious wth is going on here =3D). Otherwise both omap patches look fine, and test fine. Reviewed-by: Tomi Valkeinen Tomi --ShOBCVpwUDxEcGB8x0mp4INCLvMSUc8tK-- --TdgO6ulvGbAF2td54GkBLjTQPOfh09vpQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX9iB1AAoJEPo9qoy8lh71CXoP/ArS8THKGgsifhWsjsa5o5dl XZoX3EIDLUFIVtQk/tw4mhjuTkcsu8LOpVHDihcM6jjuX5+OZtQJAqhKkYOrbQ3U XPwoCD/xAgZMitI7sIgJvYYQq8B7IlgPGrBKfnP0vG/lNclgSGNROxB9mgsfqhZt Sk6/HIGB+sGNccfAVD1/lm0Eq71YDah16r3O4DSM7gXB/emCFHoM8Nh4eWTG6CcZ P09eIZ5QodXcfWFRMxN2L9HVRv54GWOYjkwNI/nO+vTRFvtuUF8KKdDGV2QOa1qH IHeJt9ByUmQRY7MCdpGhKhKIXcLJ0u+SB5n9F4kgQxsq9kYgNt7m6qij23+epjxA EGqH0MFHJ7rdgZMZ3NKPYt4V5qGG31mbeCttJ/Oe85VDTjP/0RCtkqi0RWQl7VEx Buk5KD71N7Sua5s+ot5fh5Gf6i3ncW8x5k/wNmpwHxbzc6nq0hP3TQQLq4gle02n c+FbRMKlTnrh+R4eQ56d6OP62gq9KgYdT8xausHwpV1rbTum1zbB5iNML8v/qaNp TXwsldiyGt8Ilo0igvZB/0DMXUIM/V0tkxHpcztmpCzzET6jgiTIKTHpcSA5JPkg fgsF9Vo9UMeS4gB3bSQGIBkDYL3UnvJkHjPM/45RngY2jeaJNIrsYThOaAu0xgp6 vg2qAiieVYfCp9x5b1Wh =jDYr -----END PGP SIGNATURE----- --TdgO6ulvGbAF2td54GkBLjTQPOfh09vpQ-- --===============0267069694== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0267069694==--