From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 14/15] drm/i915/guc: Keep the execbuf client allocated across reset Date: Mon, 28 Nov 2016 13:49:03 +0000 Message-ID: <374f5898-6f14-00a7-2af3-3fdc2d06ac7a@linux.intel.com> References: <20161125093057.18491-1-chris@chris-wilson.co.uk> <20161125093057.18491-15-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50B136E31B for ; Mon, 28 Nov 2016 13:49:21 +0000 (UTC) In-Reply-To: <20161125093057.18491-15-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI1LzExLzIwMTYgMDk6MzAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbiBvcmRlciB0byBh dm9pZCBzb21lIGNvbXBsZXhpdHkgaW4gdHJ5aW5nIHRvIHJlY29uc3RydWN0IHRoZQo+IHdvcmtx dWV1ZXMgYWNyb3NzIHJlc2V0LCByZW1lbWJlciB0aGVtIGluc3RlYWQuIFRoZSBpc3N1ZSBjb21l cyB3aGVuIHdlCj4gaGF2ZSB0byBoYW5kbGUgYSByZXNldCBiZXR3ZWVuIHJlcXVlc3QgYWxsb2Nh dGlvbiBhbmQgc3VibWlzc2lvbiwgdGhlCj4gcmVxdWVzdCBoYXMgcmVzZXJ2ZWQgc3BhY2UgaW4g dGhlIHdxLCBidXQgaXMgbm90IGluIGFueSBsaXN0IHNvIHdlIGZhaWwKPiB0byByZXN0b3JlIHRo ZSByZXNlcnZlZCBzcGFjZS4gQnkga2VlcGluZyB0aGUgZXhlY2J1ZiBjbGllbnQgaW50YWN0Cj4g YWNyb3NzIHRoZSByZXNldCwgd2UgYWxzbyBrZWVwIHRoZSByZXNlcnZhdGlvbnMuCgpJIGxvc3Qg dHJhY2sgYSBiaXQgb24gd2h5IGRvIHdlIG5lZWQgdG8gcmVzZXJ2ZSB0aGUgc3BhY2UgYXQgcmVx dWVzdCAKY3JlYXRpb24gdGltZT8gSXMgaXQgbm90IGJlY29taW5nIGEgYml0IGN1bWJlcnNvbWU/ Cgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8 IDgzICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTIg aW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXggODAwZGM1YmI3MzJmLi4wMGI1ZmE4NzE2NDQg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gQEAg LTI1MiwxMyArMjUyLDYgQEAgc3RhdGljIGludCBndWNfdXBkYXRlX2Rvb3JiZWxsX2lkKHN0cnVj dCBpbnRlbF9ndWMgKmd1YywKPiAgCXJldHVybiBob3N0Mmd1Y19hbGxvY2F0ZV9kb29yYmVsbChn dWMsIGNsaWVudCk7Cj4gIH0KPgo+IC1zdGF0aWMgaW50IGd1Y19pbml0X2Rvb3JiZWxsKHN0cnVj dCBpbnRlbF9ndWMgKmd1YywKPiAtCQkJICAgICAgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xp ZW50LAo+IC0JCQkgICAgICB1aW50MTZfdCBkYl9pZCkKPiAtewo+IC0JcmV0dXJuIGd1Y191cGRh dGVfZG9vcmJlbGxfaWQoZ3VjLCBjbGllbnQsIGRiX2lkKTsKPiAtfQo+IC0KPiAgc3RhdGljIHZv aWQgZ3VjX2Rpc2FibGVfZG9vcmJlbGwoc3RydWN0IGludGVsX2d1YyAqZ3VjLAo+ICAJCQkJIHN0 cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCkKPiAgewo+IEBAIC03NzksOCArNzcyLDcgQEAg c3RhdGljIHZvaWQgZ3VjX2luaXRfZG9vcmJlbGxfaHcoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ ICAJdWludDE2X3QgZGJfaWQ7Cj4gIAlpbnQgaSwgZXJyOwo+Cj4gLQkvKiBTYXZlIGNsaWVudCdz IG9yaWdpbmFsIGRvb3JiZWxsIHNlbGVjdGlvbiAqLwo+IC0JZGJfaWQgPSBjbGllbnQtPmRvb3Ji ZWxsX2lkOwo+ICsJZ3VjX2Rpc2FibGVfZG9vcmJlbGwoZ3VjLCBjbGllbnQpOwo+Cj4gIAlmb3Ig KGkgPSAwOyBpIDwgR1VDX01BWF9ET09SQkVMTFM7ICsraSkgewo+ICAJCS8qIFNraXAgaWYgZG9v cmJlbGwgaXMgT0sgKi8KPiBAQCAtNzkzLDcgKzc4NSw5IEBAIHN0YXRpYyB2b2lkIGd1Y19pbml0 X2Rvb3JiZWxsX2h3KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgCQkJCQlpLCBlcnIpOwo+ICAJ fQo+Cj4gLQkvKiBSZXN0b3JlIHRvIG9yaWdpbmFsIHZhbHVlICovCj4gKwlkYl9pZCA9IHNlbGVj dF9kb29yYmVsbF9yZWdpc3RlcihndWMsIGNsaWVudC0+cHJpb3JpdHkpOwo+ICsJV0FSTl9PTihk Yl9pZCA9PSBHVUNfSU5WQUxJRF9ET09SQkVMTF9JRCk7Cj4gKwo+ICAJZXJyID0gZ3VjX3VwZGF0 ZV9kb29yYmVsbF9pZChndWMsIGNsaWVudCwgZGJfaWQpOwo+ICAJaWYgKGVycikKPiAgCQlEUk1f V0FSTigiRmFpbGVkIHRvIHJlc3RvcmUgZG9vcmJlbGwgdG8gJWQsIGVyciAlZFxuIiwKPiBAQCAt ODgzLDggKzg3NywxMyBAQCBndWNfY2xpZW50X2FsbG9jKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPgo+ICAJZ3VjX3Byb2NfZGVzY19pbml0KGd1YywgY2xpZW50KTsKPiAgCWd1 Y19jdHhfZGVzY19pbml0KGd1YywgY2xpZW50KTsKPiAtCWlmIChndWNfaW5pdF9kb29yYmVsbChn dWMsIGNsaWVudCwgZGJfaWQpKQo+IC0JCWdvdG8gZXJyOwo+ICsKPiArCS8qIEZvciBydW50aW1l IGNsaWVudCBhbGxvY2F0aW9uIHdlIG5lZWQgdG8gZW5hYmxlIHRoZSBkb29yYmVsbC4gTm90Cj4g KwkgKiByZXF1aXJlZCB5ZXQgZm9yIHRoZSBzdGF0aWMgZXhlY2J1Zl9jbGllbnQgYXMgdGhpcyBz cGVjaWFsIGtlcm5lbAo+ICsJICogY2xpZW50IGlzIGVuYWJsZWQgZnJvbSBpOTE1X2d1Y19zdWJt aXNzaW9uX2VuYWJsZSgpLgo+ICsJICoKPiArCSAqIGd1Y191cGRhdGVfZG9vcmJlbGxfaWQoZ3Vj LCBjbGllbnQsIGRiX2lkKTsKPiArCSAqLwoKV2hhdCBmdXR1cmUgaXMgdGhlICJub3QgeWV0IiBw YXJ0IHJlZmVycmluZyB0bz8gV2hhdCBhcmUgdGhlIG90aGVyIGNsaWVudHM/Cgo+Cj4gIAlEUk1f REVCVUdfRFJJVkVSKCJuZXcgcHJpb3JpdHkgJXUgY2xpZW50ICVwIGZvciBlbmdpbmUocykgMHgl eDogY3R4X2luZGV4ICV1XG4iLAo+ICAJCXByaW9yaXR5LCBjbGllbnQsIGNsaWVudC0+ZW5naW5l cywgY2xpZW50LT5jdHhfaW5kZXgpOwo+IEBAIC0xNDg0LDYgKzE0ODMsOSBAQCBpbnQgaTkxNV9n dWNfc3VibWlzc2lvbl9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAg CXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZkZXZfcHJpdi0+Z3VjOwo+ICAJc3RydWN0IGk5MTVf dm1hICp2bWE7Cj4KPiArCWlmICghSEFTX0dVQ19TQ0hFRChkZXZfcHJpdikpCj4gKwkJcmV0dXJu IDA7CgpXaHkgZGlkIHlvdSBoYXZlIHRvIGFkZCB0aGlzIGh1bms/IEkgdGhpbmsgdGhpcyBmdW5j dGlvbiBkb2VzIG5vdCBnZXQgCmNhbGxlZCB1bmxlc3MgdGhlcmUgaXMgYSBHdUMuCj4gKwo+ICAJ LyogV2lwZSBiaXRtYXAgJiBkZWxldGUgY2xpZW50IGluIGNhc2Ugb2YgcmVpbml0aWFsaXNhdGlv biAqLwo+ICAJYml0bWFwX2NsZWFyKGd1Yy0+ZG9vcmJlbGxfYml0bWFwLCAwLCBHVUNfTUFYX0RP T1JCRUxMUyk7Cj4gIAlpOTE1X2d1Y19zdWJtaXNzaW9uX2Rpc2FibGUoZGV2X3ByaXYpOwo+IEBA IC0xNTA0LDQyICsxNTA2LDU3IEBAIGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJZ3VjX2xvZ19jcmVhdGUoZ3VjKTsKPiAg CWd1Y19hZGRvbl9jcmVhdGUoZ3VjKTsKPgo+ICsJZ3VjLT5leGVjYnVmX2NsaWVudCA9IGd1Y19j bGllbnRfYWxsb2MoZGV2X3ByaXYsCj4gKwkJCQkJICAgICAgIElOVEVMX0lORk8oZGV2X3ByaXYp LT5yaW5nX21hc2ssCj4gKwkJCQkJICAgICAgIEdVQ19DVFhfUFJJT1JJVFlfS01EX05PUk1BTCwK PiArCQkJCQkgICAgICAgZGV2X3ByaXYtPmtlcm5lbF9jb250ZXh0KTsKPiArCWlmICghZ3VjLT5l eGVjYnVmX2NsaWVudCkgewo+ICsJCURSTV9FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSBHdUMgY2xp ZW50IGZvciBleGVjYnVmIVxuIik7Cj4gKwkJZ290byBlcnI7Cj4gKwl9Cj4gKwo+ICAJcmV0dXJu IDA7Cj4gKwo+ICtlcnI6Cj4gKwlpOTE1X2d1Y19zdWJtaXNzaW9uX2ZpbmkoZGV2X3ByaXYpOwo+ ICsJcmV0dXJuIC1FTk9NRU07Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGd1Y19yZXNldF93cShz dHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpnYykKPiArewo+ICsJc3RydWN0IGd1Y19wcm9jZXNzX2Rl c2MgKmRlc2MgPSBnYy0+dmFkZHIgKyBnYy0+cHJvY19kZXNjX29mZnNldDsKPiArCj4gKwlkZXNj LT5oZWFkID0gMDsKPiArCWRlc2MtPnRhaWwgPSAwOwo+ICsKPiArCWdjLT53cV90YWlsID0gMDsK PiAgfQo+Cj4gIGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2VuYWJsZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZkZXZf cHJpdi0+Z3VjOwo+IC0Jc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0Owo+IC0J c3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50Owo+ICsJc3RydWN0IGk5MTVfZ3VjX2NsaWVu dCAqY2xpZW50ID0gZ3VjLT5leGVjYnVmX2NsaWVudDsKPiAgCXN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmVuZ2luZTsKPiAgCWVudW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+Cj4gLQkvKiBjbGllbnQg Zm9yIGV4ZWNidWYgc3VibWlzc2lvbiAqLwo+IC0JY2xpZW50ID0gZ3VjX2NsaWVudF9hbGxvYyhk ZXZfcHJpdiwKPiAtCQkJCSAgSU5URUxfSU5GTyhkZXZfcHJpdiktPnJpbmdfbWFzaywKPiAtCQkJ CSAgR1VDX0NUWF9QUklPUklUWV9LTURfTk9STUFMLAo+IC0JCQkJICBkZXZfcHJpdi0+a2VybmVs X2NvbnRleHQpOwo+IC0JaWYgKCFjbGllbnQpIHsKPiAtCQlEUk1fRVJST1IoIkZhaWxlZCB0byBj cmVhdGUgbm9ybWFsIEd1QyBjbGllbnQhXG4iKTsKPiAtCQlyZXR1cm4gLUVOT01FTTsKPiAtCX0K PiArCWlmICghY2xpZW50KQo+ICsJCXJldHVybiAtRU5PREVWOwo+Cj4gLQlndWMtPmV4ZWNidWZf Y2xpZW50ID0gY2xpZW50Owo+ICsJZ3VjX3Jlc2V0X3dxKGNsaWVudCk7Cj4gIAlob3N0Mmd1Y19z YW1wbGVfZm9yY2V3YWtlKGd1YywgY2xpZW50KTsKPiAgCWd1Y19pbml0X2Rvb3JiZWxsX2h3KGd1 Yyk7Cj4KPiAgCS8qIFRha2Ugb3ZlciBmcm9tIG1hbnVhbCBjb250cm9sIG9mIEVMU1AgKGV4ZWNs aXN0cykgKi8KPiAgCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2LCBpZCkgewo+ICsJ CXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnE7Cj4gKwo+ICAJCWVuZ2luZS0+c3VibWl0 X3JlcXVlc3QgPSBpOTE1X2d1Y19zdWJtaXQ7Cj4gIAkJZW5naW5lLT5zY2hlZHVsZSA9IE5VTEw7 Cj4KPiAgCQkvKiBSZXBsYXkgdGhlIGN1cnJlbnQgc2V0IG9mIHByZXZpb3VzbHkgc3VibWl0dGVk IHJlcXVlc3RzICovCj4gLQkJbGlzdF9mb3JfZWFjaF9lbnRyeShyZXF1ZXN0LAo+IC0JCQkJICAg ICZlbmdpbmUtPnRpbWVsaW5lLT5yZXF1ZXN0cywgbGluaykgewo+ICsJCWxpc3RfZm9yX2VhY2hf ZW50cnkocnEsICZlbmdpbmUtPnRpbWVsaW5lLT5yZXF1ZXN0cywgbGluaykgewo+ICAJCQljbGll bnQtPndxX3JzdmQgKz0gc2l6ZW9mKHN0cnVjdCBndWNfd3FfaXRlbSk7Cj4gLQkJCWlmIChpOTE1 X3N3X2ZlbmNlX2RvbmUoJnJlcXVlc3QtPnN1Ym1pdCkpCj4gLQkJCQlpOTE1X2d1Y19zdWJtaXQo cmVxdWVzdCk7CgppOTE1X3N3X2ZlbmNlX2RvbmUgY2hlY2sgaXMgbm90IG5lZWRlZCBiZWNhdXNl IG9ubHkgc3VibWl0LXJlYWR5IApyZXF1ZXN0cyBjYW4gYmUgb24gdGhlIGVuZ2luZSB0aW1lbGlu ZT8KCj4gKwkJCWk5MTVfZ3VjX3N1Ym1pdChycSk7Cj4gIAkJfQo+ICAJfQo+Cj4gQEAgLTE1NTUs MTQgKzE1NzIsMTggQEAgdm9pZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Rpc2FibGUoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Cj4gIAkvKiBSZXZlcnQgYmFjayB0byBtYW51YWwg RUxTUCBzdWJtaXNzaW9uICovCj4gIAlpbnRlbF9leGVjbGlzdHNfZW5hYmxlX3N1Ym1pc3Npb24o ZGV2X3ByaXYpOwo+IC0KPiAtCWd1Y19jbGllbnRfZnJlZShkZXZfcHJpdiwgZ3VjLT5leGVjYnVm X2NsaWVudCk7Cj4gLQlndWMtPmV4ZWNidWZfY2xpZW50ID0gTlVMTDsKPiAgfQo+Cj4gIHZvaWQg aTkxNV9ndWNfc3VibWlzc2lvbl9maW5pKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiAgewo+ICAJc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmRldl9wcml2LT5ndWM7Cj4gKwlz dHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQ7Cj4gKwo+ICsJY2xpZW50ID0gZmV0Y2hfYW5k X3plcm8oJmd1Yy0+ZXhlY2J1Zl9jbGllbnQpOwo+ICsJaWYgKCFjbGllbnQpCj4gKwkJcmV0dXJu Owo+ICsKPiArCWd1Y19jbGllbnRfZnJlZShkZXZfcHJpdiwgY2xpZW50KTsKPgo+ICAJaTkxNV92 bWFfdW5waW5fYW5kX3JlbGVhc2UoJmd1Yy0+YWRzX3ZtYSk7Cj4gIAlpOTE1X3ZtYV91bnBpbl9h bmRfcmVsZWFzZSgmZ3VjLT5sb2cudm1hKTsKPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK