From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E161C433DF for ; Thu, 6 Aug 2020 17:29:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97BC5221E3 for ; Thu, 6 Aug 2020 17:29:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97BC5221E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8B646E8F3; Thu, 6 Aug 2020 17:29:18 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28B736E8F3 for ; Thu, 6 Aug 2020 17:29:17 +0000 (UTC) IronPort-SDR: faZveW2jiWnQL1EMq1bol0p+Q52IbAjd2OI/E+fSH8/90yLJLsuT39gJx8v/bHbpd52zvqweU+ JJ2DUdASNejQ== X-IronPort-AV: E=McAfee;i="6000,8403,9705"; a="152839743" X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="152839743" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2020 10:29:16 -0700 IronPort-SDR: A9wDJYpFFoVPGtlZp1MKge/d83MEHlthu5/8AjIS5eLHuYS5P7s6nX72WQt1lC1tWrqirufgn4 RaxBa8DdBrog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="323502589" Received: from salerno-mobl2.ger.corp.intel.com (HELO [10.252.62.160]) ([10.252.62.160]) by orsmga008.jf.intel.com with ESMTP; 06 Aug 2020 10:29:15 -0700 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20200806161056.17593-1-chris@chris-wilson.co.uk> From: Lionel Landwerlin Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ Message-ID: <3814b8d6-6b4e-7d8a-7087-df934d9ab005@intel.com> Date: Thu, 6 Aug 2020 20:29:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200806161056.17593-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Free the fence after a fence-chain lookup failure X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 06/08/2020 19:10, Chris Wilson wrote: > If dma_fence_chain_find_seqno() reports an error, it does so in its > preamable before it disposes of the input fence. On handling the > error, we need to drop the reference to the fence. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2292 > Signed-off-by: Chris Wilson > Cc: Lionel Landwerlin Oops... Fixes: dc61199c09b1 ("drm/i915: add syncobj timeline support") Reviewed-by: Lionel Landwerlin > --- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index 9ce114d67288..24a1486d2dc5 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -2289,6 +2289,7 @@ add_timeline_fence_array(struct i915_execbuffer *eb, > > if (err && !(user_fence.flags & I915_EXEC_FENCE_SIGNAL)) { > DRM_DEBUG("Syncobj handle missing requested point %llu\n", point); > + dma_fence_put(fence); > drm_syncobj_put(syncobj); > return err; > } _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx