Re: [PATCH 1/6] drm/i915/breadcrumbs: Use booleans for intel_breadcrumbs_busy()

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 15/03/2017 14:01, Chris Wilson wrote:
> Since commit 9b6586ae9f6b ("drm/i915: Keep a global seqno per-engine")
> converted intel_breadcrumbs_busy() to reporting a single boolean, we
> need only compute a boolean internally (and not needlessly compute the
> flag).
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_breadcrumbs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c
> index 2a1ed6d7ad4d..3f222dee4c25 100644
> --- a/drivers/gpu/drm/i915/intel_breadcrumbs.c
> +++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c
> @@ -828,12 +828,12 @@ bool intel_breadcrumbs_busy(struct intel_engine_cs *engine)
>
>  	if (b->irq_wait) {
>  		wake_up_process(b->irq_wait->tsk);
> -		busy |= intel_engine_flag(engine);
> +		busy = true;
>  	}
>
>  	if (rcu_access_pointer(b->first_signal)) {
>  		wake_up_process(b->signaler);
> -		busy |= intel_engine_flag(engine);
> +		busy = true;
>  	}
>
>  	spin_unlock_irq(&b->rb_lock);
>

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx