Re: [PATCH] drm/i915: Perform manual conversions for crtc uapi/hw split, v2.

Ville Syrjälä
2019-10-24T12:23:37Z

On Thu, Oct 24, 2019 at 02:12:46PM +0200, Maarten Lankhorst wrote:
> Op 22-10-2019 om 20:16 schreef Ville Syrjälä:
> > On Fri, Oct 18, 2019 at 10:13:23AM +0200, Maarten Lankhorst wrote:
> >> intel_get_load_detect_pipe() needs to set uapi active,
> >> uapi enable is set by the call to drm_atomic_set_mode_for_crtc(),
> >> so we can remove it.
> >>
> >> intel_pipe_config_compare() needs to look at hw state, but I didn't
> >> change spatch to look at it. It's easy enough to do manually.
> >>
> >> intel_atomic_check() definitely needs to check for uapi enable,
> >> otherwise intel_modeset_pipe_config cannot copy uapi state to hw.
> > We seem to have three totally separate things in this one patch.
>
> The patch is about the manual conversions that need to be done because the automated
>
> checks get them wrong.

Does that mean the series is not actually bisectable?

> So it touches 3 spots but does 1 thing, if you want I can split it into 3 patches.
>
> Will do so if required.
>
> ~Maarten

--
Ville Syrjälä
Intel