From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C32D0C433E2 for ; Sat, 29 Aug 2020 01:11:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93DEB207BB for ; Sat, 29 Aug 2020 01:11:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93DEB207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 079196E169; Sat, 29 Aug 2020 01:11:29 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0FEE66E169; Sat, 29 Aug 2020 01:11:27 +0000 (UTC) IronPort-SDR: AqBQGoTMTnGG0qgjniQ/u/OlOpcaJ7B+lAHUA3ZfNbBNAXRLzv9ElcUVZaJ+NanPyr7n4KNqzG 5O/KcTkgqLZA== X-IronPort-AV: E=McAfee;i="6000,8403,9727"; a="156030319" X-IronPort-AV: E=Sophos;i="5.76,365,1592895600"; d="scan'208";a="156030319" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2020 18:11:26 -0700 IronPort-SDR: 8XKr402pDMeWK7gEmQD5xxksZ4Ahvm4WNu5HdK4b4iIc2+2Ue8RLNHxZTUaChm8mBFjg67LmMY PwhzpuBP9gVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,365,1592895600"; d="scan'208";a="282549523" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 28 Aug 2020 18:11:26 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 28 Aug 2020 18:10:52 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 28 Aug 2020 18:10:52 -0700 Received: from fmsmsx107.amr.corp.intel.com ([169.254.6.136]) by FMSMSX151.amr.corp.intel.com ([169.254.7.84]) with mapi id 14.03.0439.000; Fri, 28 Aug 2020 18:10:52 -0700 From: "Souza, Jose" To: "airlied@linux.ie" , "Vivi, Rodrigo" , "Roper, Matthew D" , "joonas.lahtinen@linux.intel.com" , "Srivatsa, Anusha" , "Laxminarayan Bharadiya, Pankaj" , "trix@redhat.com" , "wambui.karugax@gmail.com" , "daniel@ffwll.ch" , "jani.nikula@linux.intel.com" , "Kasireddy, Vivek" Thread-Topic: [PATCH] drm/i915/display: fix uninitialized variable Thread-Index: AQHWezZyFQ6O6CxC8EepYMeUJRKygKlOwiWA Date: Sat, 29 Aug 2020 01:10:51 +0000 Message-ID: <3a93ddc0727676afc8878ca11d0afbebe8e5e4ab.camel@intel.com> References: <20200825232057.31601-1-trix@redhat.com> In-Reply-To: <20200825232057.31601-1-trix@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.240.12] Content-ID: MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: fix uninitialized variable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Just merged the first patch that fixed this issue, thanks anyways. 2034c2129bc4a91d471815d4dc7a2a69eaa5338d - drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state On Tue, 2020-08-25 at 16:20 -0700, trix@redhat.com wrote: > From: Tom Rix < > trix@redhat.com > > > > clang static analysis flags this error > > intel_combo_phy.c:268:7: warning: The left expression of the > compound assignment is an uninitialized value. > The computed value will also be garbage > ret &= check_phy_reg(... > ~~~ ^ > > ret has no initial values, in icl_combo_phy_verify_state() ret is > set by the next statment and then updated by similar &= logic. > > Because the check_phy_req() are only register reads, reorder the > statements. > > Fixes: 239bef676d8e ("drm/i915/display: Implement new combo phy initialization step") > Signed-off-by: Tom Rix < > trix@redhat.com > > > --- > drivers/gpu/drm/i915/display/intel_combo_phy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c > index 6968de4f3477..7622ef66c987 100644 > --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c > +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c > @@ -264,6 +264,8 @@ static bool icl_combo_phy_verify_state(struct drm_i915_private *dev_priv, > if (!icl_combo_phy_enabled(dev_priv, phy)) > return false; > > + ret = cnl_verify_procmon_ref_values(dev_priv, phy); > + > if (INTEL_GEN(dev_priv) >= 12) { > ret &= check_phy_reg(dev_priv, phy, ICL_PORT_TX_DW8_LN0(phy), > ICL_PORT_TX_DW8_ODCC_CLK_SEL | > @@ -276,8 +278,6 @@ static bool icl_combo_phy_verify_state(struct drm_i915_private *dev_priv, > DCC_MODE_SELECT_CONTINUOSLY); > } > > - ret = cnl_verify_procmon_ref_values(dev_priv, phy); > - > if (phy_is_master(dev_priv, phy)) { > ret &= check_phy_reg(dev_priv, phy, ICL_PORT_COMP_DW8(phy), > IREFGEN, IREFGEN); > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx