From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: "Sagar Arun Kamble , Michal Wajdeczko ,
\" Michał Winiarski"
<"\"sagar.a.kamble@intel.commichal.wajdeczko\"@intel.commic?=
=?UTF-8?Q?hal.winiarski"@intel.com>
Subject: Re: [PATCH v8 3/8] drm/i915: Create uC runtime and system suspend/resume helpers
Date: Tue, 26 Sep 2017 19:52:20 +0530 [thread overview]
Message-ID: <3b3f6783-0358-8d2e-e1c5-585501ef131a@intel.com> (raw)
In-Reply-To: <150643341113.18177.1607157219749634814@mail.alporthouse.com>
On 9/26/2017 7:13 PM, Chris Wilson wrote:
> Quoting Sagar Arun Kamble (2017-09-26 14:24:40)
>> @@ -2077,7 +2079,7 @@ int i915_gem_runtime_suspend(struct drm_i915_private *dev_priv)
>> reg->dirty = true;
>> }
>>
>> - return 0;
>> + return ret;
> OI! These are written as return 0 because you are very much not meant to
> reach this point with an error.
> -Chris
What if GuC suspend fail? Do we still want to return 0. It might cause
issues as GuC will be active when PCI Device is set to D3.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-26 14:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 13:24 [PATCH v8 1/8] drm/i915: Create GEM runtime resume helper and handle GEM suspend/resume errors Sagar Arun Kamble
2017-09-26 13:24 ` [PATCH v8 2/8] drm/i915: Update GEM suspend/resume flows considering GuC and GEM fences Sagar Arun Kamble
2017-09-26 13:42 ` Chris Wilson
2017-09-26 14:24 ` Sagar Arun Kamble
2017-09-26 14:39 ` Chris Wilson
2017-09-26 14:48 ` Chris Wilson
2017-09-26 15:07 ` Sagar Arun Kamble
2017-09-26 13:24 ` [PATCH v8 3/8] drm/i915: Create uC runtime and system suspend/resume helpers Sagar Arun Kamble
2017-09-26 13:43 ` Chris Wilson
2017-09-26 14:22 ` Sagar Arun Kamble [this message]
2017-09-26 13:24 ` [PATCH v8 4/8] drm/i915/guc: Introduce intel_guc_sanitize Sagar Arun Kamble
2017-09-26 13:46 ` Chris Wilson
2017-09-26 14:20 ` Sagar Arun Kamble
2017-09-26 13:24 ` [PATCH v8 5/8] drm/i915/guc: Update GuC ggtt.invalidate/interrupts/communication across RPM suspend/resume Sagar Arun Kamble
2017-09-26 13:24 ` [PATCH v8 6/8] drm/i915/guc: Update GuC suspend functionality in intel_uc_suspend Sagar Arun Kamble
2017-09-26 13:49 ` Chris Wilson
2017-09-26 13:57 ` Michał Winiarski
2017-09-26 14:15 ` Sagar Arun Kamble
2017-09-26 13:24 ` [PATCH v8 7/8] drm/i915/guc: Disable GuC submission and suspend it prior to i915 reset Sagar Arun Kamble
2017-09-26 13:52 ` Chris Wilson
2017-09-26 14:18 ` Sagar Arun Kamble
2017-09-26 13:24 ` [PATCH v8 8/8] drm/i915/guc: Fix GuC cleanup in unload path Sagar Arun Kamble
2017-09-26 13:29 ` [PATCH v8 1/8] drm/i915: Create GEM runtime resume helper and handle GEM suspend/resume errors Sagar Arun Kamble
2017-09-26 13:37 ` Chris Wilson
2017-09-26 14:11 ` ✓ Fi.CI.BAT: success for series starting with [v8,1/8] " Patchwork
2017-09-26 20:39 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3f6783-0358-8d2e-e1c5-585501ef131a@intel.com \
--to=sagar.a.kamble@intel.com \
--cc="\"sagar.a.kamble@intel.commichal.wajdeczko\"@intel.commic?= =?UTF-8?Q?hal.winiarski"@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox