From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6353FC433F5 for ; Mon, 24 Jan 2022 07:28:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94BA510EBEB; Mon, 24 Jan 2022 07:27:57 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85E9810EBEB; Mon, 24 Jan 2022 07:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643009275; x=1674545275; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=sipxUkhwaAEDluHYIhBEtL2FMiWtPPy8wVlRwkgIVmk=; b=CWFa4Cirqr5VplM6+o8wsug3hL9udhmSg0RYBcrPAdd05cfm0bIcq93L fhf8rCrk7lt4ZtIEYggmDwcvtFfKhi29qn1lqMNkFPvefdTAiQDclF4nu sQlAbOnvhyHa21kl5C/MSHepR6lCtc7MPAgK9ZrBSetHlVhHy7fykbEH0 yK+r/YTwP3FvaG152Nx69ibSuz1hoyVq7177UsD2x0O4eqswTh8XiaimM N8mWDdQpDa2okRsCarxV8ECgqMcvTXQ2J8xGBylIX2iG0TnwqP3ZldWYm 9H6tfVCWXYb2G2mxQKOG+6z0jiFLvienE/luyhQQo9nLw/K+54Kmo+aAU w==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="332339741" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="332339741" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2022 23:27:31 -0800 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="673536160" Received: from xwan118-mobl1.ger.corp.intel.com (HELO [10.249.254.58]) ([10.249.254.58]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2022 23:27:26 -0800 Message-ID: <3ba14be418ab94a5cee363146438e188cb08d6cd.camel@linux.intel.com> From: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= To: Andi Shyti , Intel GFX , DRI Devel Date: Mon, 24 Jan 2022 08:27:24 +0100 In-Reply-To: <20220124010811.1640-1-andi.shyti@linux.intel.com> References: <20220124010811.1640-1-andi.shyti@linux.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-2.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix header file inclusion for might_alloc() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 2022-01-24 at 03:08 +0200, Andi Shyti wrote: > Replace "linux/slab.h" with "linux/sched/mm.h" header inclusion > as the first is not required, while the second, if not included, > prdouces the following error: > > drivers/gpu/drm/i915/i915_vma_resource.c: In function > ‘i915_vma_resource_bind_dep_await’: > drivers/gpu/drm/i915/i915_vma_resource.c:381:9: error: implicit > declaration of function ‘might_alloc’; did you mean ‘might_lock’? [- > Werror=implicit-function-declaration] >   381 |         might_alloc(gfp); >       |         ^~~~~~~~~~~ >       |         might_lock > > Signed-off-by: Andi Shyti We'd need a Fixes: tag here? > Cc: Thomas Hellström Reviewed-by: Thomas Hellström > --- >  drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c > b/drivers/gpu/drm/i915/i915_vma_resource.c > index 1f41c0c699eb..bbb0ff14272f 100644 > --- a/drivers/gpu/drm/i915/i915_vma_resource.c > +++ b/drivers/gpu/drm/i915/i915_vma_resource.c > @@ -4,7 +4,7 @@ >   */ >   >  #include > -#include > +#include >   >  #include "i915_sw_fence.h" >  #include "i915_vma_resource.h"