From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm/i915: Block enabling FBC until flips have been completed Date: Fri, 13 Apr 2018 09:19:26 +0200 Message-ID: <3ca87e4d-0f3a-fafa-27b4-8871afeb6f78@linux.intel.com> References: <20180412160718.4618-1-maarten.lankhorst@linux.intel.com> <75b2f362926bba97b55c9cae5a341266937c893a.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 803F36E999 for ; Fri, 13 Apr 2018 07:19:30 +0000 (UTC) In-Reply-To: <75b2f362926bba97b55c9cae5a341266937c893a.camel@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T3AgMTItMDQtMTggb20gMjE6NDEgc2NocmVlZiBTb3V6YSwgSm9zZToKPiBPbiBUaHUsIDIwMTgt MDQtMTIgYXQgMTg6MDcgKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+PiBUaGVyZSBp cyBhIHNtYWxsIHJhY2Ugd2luZG93IGluIHdoaWNoIEZCQyBjYW4gYmUgZW5hYmxlZCBhZnRlcgo+ PiBwcmVfcGxhbmVfdXBkYXRlIGlzIGNhbGxlZCwgYnV0IGJlZm9yZSB0aGUgcGFnZSBmbGlwIGhh cyBiZWVuCj4+IHF1ZXVlZCBvciBjb21wbGV0ZWQuCj4gSSBkb24ndCB0aGluayB0aGVyZSBpcyBz dWNoIHdpbmRvdywgaW50ZWxfZmJjX2RlYWN0aXZhdGUoKSB0aGF0IGlzCj4gY2FsbGVkIGZyb20g aW50ZWxfZmJjX3ByZV91cGRhdGUoKSB3aWxsIHNldCBmYmMtPndvcmsuc2NoZWR1bGVkID0KPiBm YWxzZTsgc28gdGhlIEZCQyB3aWxsIG5vdCBiZSBlbmFibGVkIGluIGludGVsX2ZiY193b3JrX2Zu KCkKWWVhaCwgaW50ZWxfZmJjX3ByZV91cGRhdGUgZGVhY3RpdmF0ZXMgaXQsIGJ1dCBpbnRlbF9m YmNfZmx1c2goKSBjYW4gcmUtZW5hYmxlIGl0LiA6KQo+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVu IExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+PiBCdWd6aWxs YTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMTY3Cj4+ IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgfCAgMSArCj4+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYyB8IDM1ICsrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tLS0tLQo+PiAtLS0tLQo+PiAgMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAy NCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmgKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IGluZGV4IGEw YjhkYjNkYjE0MS4uMmUyZjI0YzJkYjllIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK Pj4gQEAgLTQ5Miw2ICs0OTIsNyBAQCBzdHJ1Y3QgaW50ZWxfZmJjIHsKPj4gIAo+PiAgCWJvb2wg ZW5hYmxlZDsKPj4gIAlib29sIGFjdGl2ZTsKPj4gKwlib29sIGZsaXBfcGVuZGluZzsKPj4gIAo+ PiAgCWJvb2wgdW5kZXJydW5fZGV0ZWN0ZWQ7Cj4+ICAJc3RydWN0IHdvcmtfc3RydWN0IHVuZGVy cnVuX3dvcms7Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMu Ywo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jCj4+IGluZGV4IGI0MzFiNjcz M2NjMS4uNDc3MGRkN2RhZDVjIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9mYmMuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+PiBA QCAtOTI0LDEzICs5MjQsNiBAQCBzdGF0aWMgdm9pZCBpbnRlbF9mYmNfZ2V0X3JlZ19wYXJhbXMo c3RydWN0Cj4+IGludGVsX2NydGMgKmNydGMsCj4+ICAJCQkJCQkzMiAqIGZiYy0+dGhyZXNob2xk KSAKPj4gKiA4Owo+PiAgfQo+PiAgCj4+IC1zdGF0aWMgYm9vbCBpbnRlbF9mYmNfcmVnX3BhcmFt c19lcXVhbChzdHJ1Y3QgaW50ZWxfZmJjX3JlZ19wYXJhbXMKPj4gKnBhcmFtczEsCj4+IC0JCQkJ ICAgICAgIHN0cnVjdCBpbnRlbF9mYmNfcmVnX3BhcmFtcwo+PiAqcGFyYW1zMikKPj4gLXsKPj4g LQkvKiBXZSBjYW4gdXNlIHRoaXMgc2luY2UgaW50ZWxfZmJjX2dldF9yZWdfcGFyYW1zKCkgZG9l cyBhCj4+IG1lbXNldC4gKi8KPj4gLQlyZXR1cm4gbWVtY21wKHBhcmFtczEsIHBhcmFtczIsIHNp emVvZigqcGFyYW1zMSkpID09IDA7Cj4+IC19Cj4+IC0KPj4gIHZvaWQgaW50ZWxfZmJjX3ByZV91 cGRhdGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4+ICAJCQkgIHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpjcnRjX3N0YXRlLAo+PiAgCQkJICBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBs YW5lX3N0YXRlKQo+PiBAQCAtOTUyLDYgKzk0NSw3IEBAIHZvaWQgaW50ZWxfZmJjX3ByZV91cGRh dGUoc3RydWN0IGludGVsX2NydGMKPj4gKmNydGMsCj4+ICAJaWYgKCFmYmMtPmVuYWJsZWQgfHwg ZmJjLT5jcnRjICE9IGNydGMpCj4+ICAJCWdvdG8gdW5sb2NrOwo+PiAgCj4+ICsJZmJjLT5mbGlw X3BlbmRpbmcgPSB0cnVlOwo+IEFsc28gdGhpcyBpcyBub3QgYSBnb29kIG5hbWUsIG90aGVyIGFj dGlvbnMgY2FuIGNhdXNlIHRoaXMgZnVuY3Rpb24gdG8KPiBiZSBleGVjdXRlZCBvdGhlciB0aGFu IGEgZmxpcC4KV2VsbCwgZm9yIEZCQyBwdXJwb3NlcyBpdCdzIGEgZmxpcCwgYnV0IEkgYW0gYWxz byBvayB3aXRoIHJlbmFtaW5nIGl0IHRvIHVwZGF0ZV9wZW5kaW5nPyA6KQo+PiAgCWludGVsX2Zi Y191cGRhdGVfc3RhdGVfY2FjaGUoY3J0YywgY3J0Y19zdGF0ZSwgcGxhbmVfc3RhdGUpOwo+PiAg Cj4+ICBkZWFjdGl2YXRlOgo+PiBAQCAtOTg4LDEzICs5ODIsMTUgQEAgc3RhdGljIHZvaWQgX19p bnRlbF9mYmNfcG9zdF91cGRhdGUoc3RydWN0Cj4+IGludGVsX2NydGMgKmNydGMpCj4+ICB7Cj4+ ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNl LmRldik7Cj4+ICAJc3RydWN0IGludGVsX2ZiYyAqZmJjID0gJmRldl9wcml2LT5mYmM7Cj4+IC0J c3RydWN0IGludGVsX2ZiY19yZWdfcGFyYW1zIG9sZF9wYXJhbXM7Cj4+ICAKPj4gIAlXQVJOX09O KCFtdXRleF9pc19sb2NrZWQoJmZiYy0+bG9jaykpOwo+PiAgCj4+ICAJaWYgKCFmYmMtPmVuYWJs ZWQgfHwgZmJjLT5jcnRjICE9IGNydGMpCj4+ICAJCXJldHVybjsKPj4gIAo+PiArCWZiYy0+Zmxp cF9wZW5kaW5nID0gZmFsc2U7Cj4+ICsJV0FSTl9PTihmYmMtPmFjdGl2ZSk7Cj4+ICsKPj4gIAlp ZiAoIWk5MTVfbW9kcGFyYW1zLmVuYWJsZV9mYmMpIHsKPj4gIAkJaW50ZWxfZmJjX2RlYWN0aXZh dGUoZGV2X3ByaXYsICJkaXNhYmxlZCBhdCBydW50aW1lCj4+IHBlciBtb2R1bGUgcGFyYW0iKTsK Pj4gIAkJX19pbnRlbF9mYmNfZGlzYWJsZShkZXZfcHJpdik7Cj4+IEBAIC0xMDAyLDI1ICs5OTgs MTYgQEAgc3RhdGljIHZvaWQgX19pbnRlbF9mYmNfcG9zdF91cGRhdGUoc3RydWN0Cj4+IGludGVs X2NydGMgKmNydGMpCj4+ICAJCXJldHVybjsKPj4gIAl9Cj4+ICAKPj4gLQlpZiAoIWludGVsX2Zi Y19jYW5fYWN0aXZhdGUoY3J0YykpIHsKPj4gLQkJV0FSTl9PTihmYmMtPmFjdGl2ZSk7Cj4+ICsJ aWYgKCFpbnRlbF9mYmNfY2FuX2FjdGl2YXRlKGNydGMpKQo+PiAgCQlyZXR1cm47Cj4+IC0JfQo+ PiAgCj4+IC0Jb2xkX3BhcmFtcyA9IGZiYy0+cGFyYW1zOwo+PiAgCWludGVsX2ZiY19nZXRfcmVn X3BhcmFtcyhjcnRjLCAmZmJjLT5wYXJhbXMpOwo+PiAgCj4+IC0JLyogSWYgdGhlIHNjYW5vdXQg aGFzIG5vdCBjaGFuZ2VkLCBkb24ndCBtb2RpZnkgdGhlIEZCQwo+PiBzZXR0aW5ncy4KPj4gLQkg KiBOb3RlIHRoYXQgd2UgbWFrZSB0aGUgZnVuZGFtZW50YWwgYXNzdW1wdGlvbiB0aGF0IHRoZSBm Yi0KPj4+IG9iago+PiAtCSAqIGNhbm5vdCBiZSB1bnBpbm5lZCAoYW5kIGhhdmUgaXRzIEdUVCBv ZmZzZXQgYW5kIGZlbmNlCj4+IHJldm9rZWQpCj4+IC0JICogd2l0aG91dCBmaXJzdCBiZWluZyBk ZWNvdXBsZWQgZnJvbSB0aGUgc2Nhbm91dCBhbmQgRkJDCj4+IGRpc2FibGVkLgo+PiAtCSAqLwo+ PiAtCWlmIChmYmMtPmFjdGl2ZSAmJgo+PiAtCSAgICBpbnRlbF9mYmNfcmVnX3BhcmFtc19lcXVh bCgmb2xkX3BhcmFtcywgJmZiYy0+cGFyYW1zKSkKPj4gLQkJcmV0dXJuOwo+PiAtCj4+IC0JaW50 ZWxfZmJjX2RlYWN0aXZhdGUoZGV2X3ByaXYsICJGQkMgZW5hYmxlZCAoYWN0aXZlIG9yCj4+IHNj aGVkdWxlZCkiKTsKPj4gLQlpbnRlbF9mYmNfc2NoZWR1bGVfYWN0aXZhdGlvbihjcnRjKTsKPj4g KwlpZiAoIWZiYy0+YnVzeV9iaXRzKSB7Cj4gSSBndWVzcyB0aGlzICdpZicgdGhlIGxpbmUgdGhh dCBpcyBmaXhpbmcgdGhlIGlzc3VlLgoKSSB0aGluayB0aGF0J3Mgbm90IG5lY2Vzc2FyaWx5IHRo ZSBjYXNlIGZvciB0aGVzZSB0ZXN0cy4gSSBkb24ndCBrbm93IGlmIHRoaXMgZml4ZXMKdGhlIGJ1 ZywgYXMgdGhlIGRpcnR5ZmIgaXMgY2FsbGVkIGFmdGVyIHRoZSBhdG9taWMgdXBkYXRlIGNvbXBs ZXRlZC4gSSBqdXN0IG5vdGVkIHRoYXQKYWZ0ZXIgcHJlX3BsYW5lX3VwZGF0ZSwgeW91IGNvdWxk IHNuZWFrIGluIGEgZGlydHlmYiBhbmQgdGhlbiBmYmMgY291bGQgYmUgYWN0aXZhdGVkCnRvbyBl YXJseS4KClRoYXQncyB0aGUgaG9sZSBJJ3ZlIGJlZW4gdHJ5aW5nIHRvIGNsb3NlLiBCdXQgSSBj bG9zZWQgaXQgdGhlIG90aGVyIHdheSBhcm91bmQgdG9vCmp1c3QgaW4gY2FzZS4gOikgCgo+PiAr CQlpbnRlbF9mYmNfZGVhY3RpdmF0ZShkZXZfcHJpdiwgIkZCQyBlbmFibGVkIChhY3RpdmUKPj4g b3Igc2NoZWR1bGVkKSIpOwo+PiArCQlpbnRlbF9mYmNfc2NoZWR1bGVfYWN0aXZhdGlvbihjcnRj KTsKPj4gKwl9IGVsc2UKPj4gKwkJaW50ZWxfZmJjX2RlYWN0aXZhdGUoZGV2X3ByaXYsICJmcm9u dGJ1ZmZlciB3cml0ZSIpOwo+PiAgfQo+PiAgCj4+ICB2b2lkIGludGVsX2ZiY19wb3N0X3VwZGF0 ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPj4gQEAgLTEwODUsNyArMTA3Miw3IEBAIHZvaWQg aW50ZWxfZmJjX2ZsdXNoKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4+ICpkZXZfcHJpdiwKPj4g IAkgICAgKGZyb250YnVmZmVyX2JpdHMgJiBpbnRlbF9mYmNfZ2V0X2Zyb250YnVmZmVyX2JpdChm YmMpKSkKPj4gewo+PiAgCQlpZiAoZmJjLT5hY3RpdmUpCj4+ICAJCQlpbnRlbF9mYmNfcmVjb21w cmVzcyhkZXZfcHJpdik7Cj4+IC0JCWVsc2UKPj4gKwkJZWxzZSBpZiAoIWZiYy0+ZmxpcF9wZW5k aW5nKQo+PiAgCQkJX19pbnRlbF9mYmNfcG9zdF91cGRhdGUoZmJjLT5jcnRjKTsKPj4gIAl9Cj4+ ICAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK