* [PATCH 1/2] drm/i915: Silence sparse by using gfp_t
@ 2017-09-01 14:57 Chris Wilson
2017-09-01 14:57 ` [PATCH 2/2] drm/i915/perf: Remove __user from u64 in drm_i915_perf_oa_config Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Chris Wilson @ 2017-09-01 14:57 UTC (permalink / raw)
To: intel-gfx
Sparse enforces that GFP flags are only manipulated inside gfp_t locals.
Fixes: 4d470f7359c4 ("drm/i915: Avoid undefined behaviour of "u32 >> 32"")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 8a9d37ac16d4..67317b79b9e0 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -290,7 +290,7 @@ static int eb_create(struct i915_execbuffer *eb)
* direct lookup.
*/
do {
- unsigned int flags;
+ gfp_t flags;
/* While we can still reduce the allocation size, don't
* raise a warning and allow the allocation to fail.
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] drm/i915/perf: Remove __user from u64 in drm_i915_perf_oa_config
2017-09-01 14:57 [PATCH 1/2] drm/i915: Silence sparse by using gfp_t Chris Wilson
@ 2017-09-01 14:57 ` Chris Wilson
2017-09-01 15:05 ` Lionel Landwerlin
2017-09-01 15:21 ` [PATCH 1/2] drm/i915: Silence sparse by using gfp_t Ville Syrjälä
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2017-09-01 14:57 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld
Sparse complains that these integers from which we form void __user *,
and so we don't need the annotation itself inside the uABI.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
---
include/uapi/drm/i915_drm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index 6598fb76d2c2..d8d10d932759 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -1509,9 +1509,9 @@ struct drm_i915_perf_oa_config {
__u32 n_boolean_regs;
__u32 n_flex_regs;
- __u64 __user mux_regs_ptr;
- __u64 __user boolean_regs_ptr;
- __u64 __user flex_regs_ptr;
+ __u64 mux_regs_ptr;
+ __u64 boolean_regs_ptr;
+ __u64 flex_regs_ptr;
};
#if defined(__cplusplus)
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] drm/i915/perf: Remove __user from u64 in drm_i915_perf_oa_config
2017-09-01 14:57 ` [PATCH 2/2] drm/i915/perf: Remove __user from u64 in drm_i915_perf_oa_config Chris Wilson
@ 2017-09-01 15:05 ` Lionel Landwerlin
0 siblings, 0 replies; 8+ messages in thread
From: Lionel Landwerlin @ 2017-09-01 15:05 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Matthew Auld
Sure :
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
On 01/09/17 15:57, Chris Wilson wrote:
> Sparse complains that these integers from which we form void __user *,
> and so we don't need the annotation itself inside the uABI.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> ---
> include/uapi/drm/i915_drm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
> index 6598fb76d2c2..d8d10d932759 100644
> --- a/include/uapi/drm/i915_drm.h
> +++ b/include/uapi/drm/i915_drm.h
> @@ -1509,9 +1509,9 @@ struct drm_i915_perf_oa_config {
> __u32 n_boolean_regs;
> __u32 n_flex_regs;
>
> - __u64 __user mux_regs_ptr;
> - __u64 __user boolean_regs_ptr;
> - __u64 __user flex_regs_ptr;
> + __u64 mux_regs_ptr;
> + __u64 boolean_regs_ptr;
> + __u64 flex_regs_ptr;
> };
>
> #if defined(__cplusplus)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] drm/i915: Silence sparse by using gfp_t
2017-09-01 14:57 [PATCH 1/2] drm/i915: Silence sparse by using gfp_t Chris Wilson
2017-09-01 14:57 ` [PATCH 2/2] drm/i915/perf: Remove __user from u64 in drm_i915_perf_oa_config Chris Wilson
@ 2017-09-01 15:21 ` Ville Syrjälä
2017-09-01 15:47 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2017-09-04 6:50 ` [PATCH 1/2] " Joonas Lahtinen
3 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2017-09-01 15:21 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Sep 01, 2017 at 03:57:28PM +0100, Chris Wilson wrote:
> Sparse enforces that GFP flags are only manipulated inside gfp_t locals.
>
> Fixes: 4d470f7359c4 ("drm/i915: Avoid undefined behaviour of "u32 >> 32"")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> index 8a9d37ac16d4..67317b79b9e0 100644
> --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -290,7 +290,7 @@ static int eb_create(struct i915_execbuffer *eb)
> * direct lookup.
> */
> do {
> - unsigned int flags;
> + gfp_t flags;
>
> /* While we can still reduce the allocation size, don't
> * raise a warning and allow the allocation to fail.
> --
> 2.14.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Silence sparse by using gfp_t
2017-09-01 14:57 [PATCH 1/2] drm/i915: Silence sparse by using gfp_t Chris Wilson
2017-09-01 14:57 ` [PATCH 2/2] drm/i915/perf: Remove __user from u64 in drm_i915_perf_oa_config Chris Wilson
2017-09-01 15:21 ` [PATCH 1/2] drm/i915: Silence sparse by using gfp_t Ville Syrjälä
@ 2017-09-01 15:47 ` Patchwork
2017-09-04 6:50 ` [PATCH 1/2] " Joonas Lahtinen
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-09-01 15:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Silence sparse by using gfp_t
URL : https://patchwork.freedesktop.org/series/29702/
State : failure
== Summary ==
Series 29702v1 series starting with [1/2] drm/i915: Silence sparse by using gfp_t
https://patchwork.freedesktop.org/api/1.0/series/29702/revisions/1/mbox/
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-snb-2600) fdo#100215
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> FAIL (fi-kbl-r)
Subgroup suspend-read-crc-pipe-c:
pass -> FAIL (fi-kbl-r)
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fi-bdw-5557u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:457s
fi-bdw-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:442s
fi-blb-e6850 total:288 pass:224 dwarn:1 dfail:0 fail:0 skip:63 time:365s
fi-bsw-n3050 total:288 pass:243 dwarn:0 dfail:0 fail:0 skip:45 time:554s
fi-bwr-2160 total:288 pass:184 dwarn:0 dfail:0 fail:0 skip:104 time:254s
fi-bxt-j4205 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:523s
fi-byt-j1900 total:288 pass:254 dwarn:1 dfail:0 fail:0 skip:33 time:525s
fi-byt-n2820 total:288 pass:250 dwarn:1 dfail:0 fail:0 skip:37 time:512s
fi-elk-e7500 total:288 pass:230 dwarn:0 dfail:0 fail:0 skip:58 time:434s
fi-glk-2a total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:615s
fi-hsw-4770 total:288 pass:263 dwarn:0 dfail:0 fail:0 skip:25 time:442s
fi-hsw-4770r total:288 pass:263 dwarn:0 dfail:0 fail:0 skip:25 time:422s
fi-ilk-650 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:428s
fi-ivb-3520m total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:506s
fi-ivb-3770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:480s
fi-kbl-7500u total:288 pass:264 dwarn:1 dfail:0 fail:0 skip:23 time:514s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:589s
fi-kbl-r total:288 pass:259 dwarn:0 dfail:0 fail:2 skip:27 time:570s
fi-pnv-d510 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:537s
fi-skl-6260u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:472s
fi-skl-6700k total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:537s
fi-skl-6770hq total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:479s
fi-skl-gvtdvm total:288 pass:266 dwarn:0 dfail:0 fail:0 skip:22 time:441s
fi-skl-x1585l total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:482s
fi-snb-2520m total:288 pass:251 dwarn:0 dfail:0 fail:0 skip:37 time:547s
fi-snb-2600 total:288 pass:249 dwarn:0 dfail:0 fail:1 skip:38 time:403s
8b962a9a16b3a4e3cc2a56cba82ee9c0dc0941b5 drm-tip: 2017y-09m-01d-13h-56m-06s UTC integration manifest
5bb3599f4091 drm/i915/perf: Remove __user from u64 in drm_i915_perf_oa_config
527d430e9026 drm/i915: Silence sparse by using gfp_t
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5566/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] drm/i915: Silence sparse by using gfp_t
2017-09-01 14:57 [PATCH 1/2] drm/i915: Silence sparse by using gfp_t Chris Wilson
` (2 preceding siblings ...)
2017-09-01 15:47 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
@ 2017-09-04 6:50 ` Joonas Lahtinen
2017-09-04 11:08 ` Chris Wilson
3 siblings, 1 reply; 8+ messages in thread
From: Joonas Lahtinen @ 2017-09-04 6:50 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On Fri, 2017-09-01 at 15:57 +0100, Chris Wilson wrote:
> Sparse enforces that GFP flags are only manipulated inside gfp_t locals.
>
> Fixes: 4d470f7359c4 ("drm/i915: Avoid undefined behaviour of "u32 >> 32"")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Isn't Fixes: bit much for sparse warning?
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] drm/i915: Silence sparse by using gfp_t
2017-09-04 6:50 ` [PATCH 1/2] " Joonas Lahtinen
@ 2017-09-04 11:08 ` Chris Wilson
2017-09-18 13:19 ` Joonas Lahtinen
0 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2017-09-04 11:08 UTC (permalink / raw)
To: Joonas Lahtinen, intel-gfx
Quoting Joonas Lahtinen (2017-09-04 07:50:38)
> On Fri, 2017-09-01 at 15:57 +0100, Chris Wilson wrote:
> > Sparse enforces that GFP flags are only manipulated inside gfp_t locals.
> >
> > Fixes: 4d470f7359c4 ("drm/i915: Avoid undefined behaviour of "u32 >> 32"")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Isn't Fixes: bit much for sparse warning?
Impact: None ?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] drm/i915: Silence sparse by using gfp_t
2017-09-04 11:08 ` Chris Wilson
@ 2017-09-18 13:19 ` Joonas Lahtinen
0 siblings, 0 replies; 8+ messages in thread
From: Joonas Lahtinen @ 2017-09-18 13:19 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On Mon, 2017-09-04 at 12:08 +0100, Chris Wilson wrote:
> Quoting Joonas Lahtinen (2017-09-04 07:50:38)
> > On Fri, 2017-09-01 at 15:57 +0100, Chris Wilson wrote:
> > > Sparse enforces that GFP flags are only manipulated inside gfp_t locals.
> > >
> > > Fixes: 4d470f7359c4 ("drm/i915: Avoid undefined behaviour of "u32 >> 32"")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > Isn't Fixes: bit much for sparse warning?
>
> Impact: None ?
Well, "Impact: Cosmetic" would be more truthful but complex.
"Backport: None" ?
Could also take the value that is currently causing grief in the Cc:
stable line;
"Backport: v4.8+"
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-09-18 13:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-01 14:57 [PATCH 1/2] drm/i915: Silence sparse by using gfp_t Chris Wilson
2017-09-01 14:57 ` [PATCH 2/2] drm/i915/perf: Remove __user from u64 in drm_i915_perf_oa_config Chris Wilson
2017-09-01 15:05 ` Lionel Landwerlin
2017-09-01 15:21 ` [PATCH 1/2] drm/i915: Silence sparse by using gfp_t Ville Syrjälä
2017-09-01 15:47 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2017-09-04 6:50 ` [PATCH 1/2] " Joonas Lahtinen
2017-09-04 11:08 ` Chris Wilson
2017-09-18 13:19 ` Joonas Lahtinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox