From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Tidy workaround batch buffer emission
Date: Thu, 16 Feb 2017 13:23:51 +0000 [thread overview]
Message-ID: <3f68d4fa-1275-5d19-5f27-0149d5f94f0c@linux.intel.com> (raw)
In-Reply-To: <20170216132044.GM21134@nuc-i3427.alporthouse.com>
On 16/02/2017 13:20, Chris Wilson wrote:
> On Thu, Feb 16, 2017 at 12:23:24PM +0000, Tvrtko Ursulin wrote:
>> + /*
>> + * Emit the two workaround batch buffers, recording the offset from the
>> + * start of the workaround batch buffer object for each and their
>> + * respective sizes.
>> + */
>> + for (i = 0; i < ARRAY_SIZE(wa_bb_fn); i++) {
>> + wa_bb[i]->offset = ALIGN(batch_ptr - batch, CACHELINE_BYTES);
>> + batch_ptr = wa_bb_fn[i](engine, batch_ptr);
>> + wa_bb[i]->size = batch_ptr - batch + wa_bb[i]->offset;
>
> wa_bb[i]->size = batch_ptr - (batch + wa_bb[i]->offset);
> ?
Shock horror.. Thanks.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-16 13:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 12:23 [PATCH 0/5] Assorted engine tidy Tvrtko Ursulin
2017-02-16 12:23 ` [PATCH 1/5] drm/i915: Make int __intel_ring_space static Tvrtko Ursulin
2017-02-16 13:12 ` Chris Wilson
2017-02-16 12:23 ` [PATCH 2/5] drm/i915: Simplify cleanup path in intel_engines_init Tvrtko Ursulin
2017-02-16 13:15 ` Chris Wilson
2017-02-16 12:23 ` [PATCH 3/5] drm/i915: Move common workaround code to intel_engine_cs Tvrtko Ursulin
2017-02-16 13:18 ` Chris Wilson
2017-02-16 12:23 ` [PATCH 4/5] drm/i915: Tidy workaround batch buffer emission Tvrtko Ursulin
2017-02-16 13:20 ` Chris Wilson
2017-02-16 13:23 ` Tvrtko Ursulin [this message]
2017-02-16 13:28 ` Chris Wilson
2017-02-16 13:47 ` Tvrtko Ursulin
2017-02-16 13:51 ` [PATCH v4 1/2] " Tvrtko Ursulin
2017-02-16 13:54 ` [PATCH v5 " Tvrtko Ursulin
2017-02-16 14:03 ` Chris Wilson
2017-02-17 7:58 ` [PATCH v6] " Tvrtko Ursulin
2017-02-17 8:16 ` Chris Wilson
2017-02-16 12:23 ` [PATCH 5/5] drm/i915: Consolidate gen8_emit_pipe_control Tvrtko Ursulin
2017-02-16 18:22 ` ✓ Fi.CI.BAT: success for Assorted engine tidy (rev3) Patchwork
2017-02-17 8:22 ` ✗ Fi.CI.BAT: failure for Assorted engine tidy (rev4) Patchwork
2017-02-17 11:50 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f68d4fa-1275-5d19-5f27-0149d5f94f0c@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox