From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30F82C001B0 for ; Mon, 10 Jul 2023 09:01:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9BC110E240; Mon, 10 Jul 2023 09:01:00 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7363410E23F for ; Mon, 10 Jul 2023 09:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688979658; x=1720515658; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=IlYvCRoYdRBQ/1KGKbXZH0wv4/da6e2Hk09jQtW4Nfk=; b=E58O1MlXbQlEr14ESh0hB7X4IjGMHFk59Vv3gmlmsPqiBuEwZdoaVlcm jQxIUoKHkhzE2C4T0KIHtIqlUWSkXCu52qHnpGKib/JV9KSaqX5ZypThq p4yReVJks9zq3PNhCRSpwUzs84WynErGAcTQOVmLeFGf5vMH3c2zi07GM EpBONgmW7F2Ix3RLKtoTg5kNCjrrQRmykLoyvEFYyqLobmDvzkmwQVRuF EJmQUc2aaR9em2kkrT1XPYN0CKpWcE9X7gi2g6q2AwL3yS+zL8bSxHwLv gjoQH/TvWMJZKQDnoGeksS36byXYvs1ENqN9/NNxC4P5G6laowIDEMu82 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="427984666" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="427984666" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 02:00:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="810740477" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="810740477" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.252.43.200]) ([10.252.43.200]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 02:00:56 -0700 Message-ID: <4032e558-00f7-4c9b-6d4a-7b8958361237@linux.intel.com> Date: Mon, 10 Jul 2023 11:00:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Tvrtko Ursulin , Nirmoy Das , intel-gfx@lists.freedesktop.org References: <20230630170140.17319-1-nirmoy.das@intel.com> <20230630170140.17319-2-nirmoy.das@intel.com> <837c9971-79fc-015c-e611-a161cb8d4b96@linux.intel.com> <73912e3b-69af-b95c-7b0b-8518d003a3d2@linux.intel.com> From: Nirmoy Das In-Reply-To: <73912e3b-69af-b95c-7b0b-8518d003a3d2@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Do not use stolen on MTL X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrzej Hajda Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Tvrkto, On 7/6/2023 3:43 PM, Tvrtko Ursulin wrote: > > On 06/07/2023 14:35, Nirmoy Das wrote: >> >> On 7/6/2023 3:32 PM, Tvrtko Ursulin wrote: >>> >>> On 30/06/2023 18:01, Nirmoy Das wrote: >>>> Use smem on MTL due to a HW bug in MTL that prevents >>>> reading from stolen memory using LMEM BAR. >>> >>> Does anything remain in stolen or could the memory region just not >>> be created? >> >> >> GSC requires DSM which can't use smem for another bug. > > Okay, thanks. > > As a related comment, these if-if-if object creation ladders were > always a bit ugly and some years ago I was suggesting we create a > helper with some "intent/usage" flags. Which could then dtrt ie. > create the right object for that intent/usage and platform. I *think* > I possibly even had a RFC... need to try and find it. Did you find it :) Would be nice to have a better way to detect and apply memory region as per platfrom/usecase. Regards, Nirmoy > > Regards, > > Tvrtko > >> >> Regards, >> >> Nirmoy >> >> >>> >>> Regards, >>> >>> Tvrtko >>> >>>> Cc: Oak Zeng >>>> Cc: Jani Nikula >>>> Cc: Joonas Lahtinen >>>> Cc: Andi Shyti >>>> Cc: Andrzej Hajda >>>> Signed-off-by: Nirmoy Das >>>> --- >>>>   drivers/gpu/drm/i915/display/intel_fbdev.c   | 2 ++ >>>>   drivers/gpu/drm/i915/display/intel_overlay.c | 7 ++++--- >>>>   2 files changed, 6 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c >>>> b/drivers/gpu/drm/i915/display/intel_fbdev.c >>>> index 1cc0ddc6a310..10e38d60f9ef 100644 >>>> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c >>>> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c >>>> @@ -182,6 +182,8 @@ static int intelfb_alloc(struct drm_fb_helper >>>> *helper, >>>>           obj = i915_gem_object_create_lmem(dev_priv, size, >>>>                             I915_BO_ALLOC_CONTIGUOUS | >>>>                             I915_BO_ALLOC_USER); >>>> +    } else if (IS_METEORLAKE(dev_priv)) { /* Wa_22018444074 */ >>>> +        obj = i915_gem_object_create_shmem(dev_priv, size); >>>>       } else { >>>>           /* >>>>            * If the FB is too big, just don't use it since fbdev is >>>> not very >>>> diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c >>>> b/drivers/gpu/drm/i915/display/intel_overlay.c >>>> index d6fe2bbabe55..05ae446c8a56 100644 >>>> --- a/drivers/gpu/drm/i915/display/intel_overlay.c >>>> +++ b/drivers/gpu/drm/i915/display/intel_overlay.c >>>> @@ -1348,12 +1348,13 @@ int intel_overlay_attrs_ioctl(struct >>>> drm_device *dev, void *data, >>>>   static int get_registers(struct intel_overlay *overlay, bool >>>> use_phys) >>>>   { >>>>       struct drm_i915_private *i915 = overlay->i915; >>>> -    struct drm_i915_gem_object *obj; >>>> +    struct drm_i915_gem_object *obj = NULL; >>>>       struct i915_vma *vma; >>>>       int err; >>>>   -    obj = i915_gem_object_create_stolen(i915, PAGE_SIZE); >>>> -    if (IS_ERR(obj)) >>>> +    if (!IS_METEORLAKE(i915)) /* Wa_22018444074 */ >>>> +        obj = i915_gem_object_create_stolen(i915, PAGE_SIZE); >>>> +    if (IS_ERR_OR_NULL(obj)) >>>>           obj = i915_gem_object_create_internal(i915, PAGE_SIZE); >>>>       if (IS_ERR(obj)) >>>>           return PTR_ERR(obj);