From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: [PATCH] drm: Make the decision to keep vblank irq enabled earlier Date: Fri, 24 Mar 2017 04:16:28 +0100 Message-ID: <4098543f-16e1-ca44-cdf2-157bdb66b188@gmail.com> References: <20170322200200.GM31595@intel.com> <20170323075106.7494-1-chris@chris-wilson.co.uk> <20170323132642.GS31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170323132642.GS31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Chris Wilson Cc: =?UTF-8?Q?Michel_D=c3=a4nzer?= , dri-devel@lists.freedesktop.org, Laurent Pinchart , Dave Airlie , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDMvMjMvMjAxNyAwMjoyNiBQTSwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+IE9uIFRodSwg TWFyIDIzLCAyMDE3IGF0IDA3OjUxOjA2QU0gKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4g V2Ugd2FudCB0byBwcm92aWRlIHRoZSB2YmxhbmsgaXJxIHNoYWRvdyBmb3IgcGFnZWZsaXAgZXZl bnRzIGFzIHdlbGwgYXMKPj4gdmJsYW5rIHF1ZXJpZXMuIFN1Y2ggZXZlbnRzIGFyZSBjb21wbGV0 ZWQgd2l0aGluIHRoZSB2YmxhbmsgaW50ZXJydXB0Cj4+IGhhbmRsZXIsIGFuZCBzbyB0aGUgY3Vy cmVudCBjaGVjayBmb3IgZGlzYWJsaW5nIHRoZSBpcnEgd2lsbCBkaXNhYmxlIGl0Cj4+IGZyb20g d2l0aCB0aGUgc2FtZSBpbnRlcnJ1cHQgYXMgdGhlIGxhc3QgcGFnZWZsaXAgZXZlbnQuIElmIHdl IG1vdmUgdGhlCj4+IGRlY2lzaW9uIG9uIHdoZXRoZXIgdG8gZGlzYWJsZSB0aGUgaXJxIChiYXNl ZCBvbiB0aGVyZSBubyBiZWluZyBubwo+PiByZW1haW5pbmcgdmJsYW5rIGV2ZW50cywgaS5lLiB2 YmxhbmstPnJlZmNvdW50ID09IDApIHRvIGJlZm9yZSB3ZSBzaWduYWwKPj4gdGhlIGV2ZW50cywg d2Ugd2lsbCBvbmx5IGRpc2FibGUgdGhlIGlycSBvbiB0aGUgaW50ZXJydXB0IGFmdGVyIHRoZSBs YXN0Cj4+IGV2ZW50IHdhcyBzaWduYWxlZC4gSW4gdGhlIG5vcm1hbCBjb3Vyc2Ugb2YgZXZlbnRz LCB0aGlzIHdpbGwga2VlcCB0aGUKPj4gdmJsYW5rIGlycSBlbmFibGVkIGZvciB0aGUgZW50aXJl IGZsaXAgc2VxdWVuY2Ugd2hlcmVhcyBiZWZvcmUgaXQgd291bGQKPj4gZmxpcC1mbG9wIGFyb3Vu ZCBldmVyeSBpbnRlcnJ1cHQuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hy aXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5j aD4KPj4gQ2M6IE1pY2hlbCBEw6RuemVyIDxtaWNoZWxAZGFlbnplci5uZXQ+Cj4+IENjOiBMYXVy ZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4+IENjOiBE YXZlIEFpcmxpZSA8YWlybGllZEByZWRoYXQuY29tPiwKPj4gQ2M6IE1hcmlvIEtsZWluZXIgPG1h cmlvLmtsZWluZXIuZGVAZ21haWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f aXJxLmMgfCAxOCArKysrKysrKysrKy0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNl cnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2RybV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPj4gaW5kZXggNWI3NzA1 N2U5MWNhLi4xZDZiY2VlMzcwOGYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f aXJxLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwo+PiBAQCAtMTc0MSw2ICsx NzQxLDcgQEAgYm9vbCBkcm1faGFuZGxlX3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1 bnNpZ25lZCBpbnQgcGlwZSkKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX3ZibGFua19jcnRjICp2Ymxh bmsgPSAmZGV2LT52YmxhbmtbcGlwZV07Cj4+ICAJdW5zaWduZWQgbG9uZyBpcnFmbGFnczsKPj4g Kwlib29sIGRpc2FibGVfaXJxOwo+Pgo+PiAgCWlmIChXQVJOX09OX09OQ0UoIWRldi0+bnVtX2Ny dGNzKSkKPj4gIAkJcmV0dXJuIGZhbHNlOwo+PiBAQCAtMTc2OCwxNiArMTc2OSwxOSBAQCBib29s IGRybV9oYW5kbGVfdmJsYW5rKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBw aXBlKQo+PiAgCXNwaW5fdW5sb2NrKCZkZXYtPnZibGFua190aW1lX2xvY2spOwo+Pgo+PiAgCXdh a2VfdXAoJnZibGFuay0+cXVldWUpOwo+PiAtCWRybV9oYW5kbGVfdmJsYW5rX2V2ZW50cyhkZXYs IHBpcGUpOwo+Pgo+PiAgCS8qIFdpdGggaW5zdGFudC1vZmYsIHdlIGRlZmVyIGRpc2FibGluZyB0 aGUgaW50ZXJydXB0IHVudGlsIGFmdGVyCj4+IC0JICogd2UgZmluaXNoIHByb2Nlc3NpbmcgdGhl IGZvbGxvd2luZyB2YmxhbmsuIFRoZSBkaXNhYmxlIGhhcyB0bwo+PiAtCSAqIGJlIGxhc3QgKGFm dGVyIGRybV9oYW5kbGVfdmJsYW5rX2V2ZW50cykgc28gdGhhdCB0aGUgdGltZXN0YW1wCj4+IC0J ICogaXMgYWx3YXlzIGFjY3VyYXRlLgo+PiArCSAqIHdlIGZpbmlzaCBwcm9jZXNzaW5nIHRoZSBm b2xsb3dpbmcgdmJsYW5rIGFmdGVyIGFsbCBldmVudHMgaGF2ZQo+PiArCSAqIGJlZW4gc2lnbmFs ZWQuIFRoZSBkaXNhYmxlIGhhcyB0byBiZSBsYXN0IChhZnRlcgo+PiArCSAqIGRybV9oYW5kbGVf dmJsYW5rX2V2ZW50cykgc28gdGhhdCB0aGUgdGltZXN0YW1wIGlzIGFsd2F5cyBhY2N1cmF0ZS4K Pgo+IFdlIHdvdWxkbid0IGFjdHVhbGx5IGRvIHRoZSBkaXNhYmxlIGFzIGxvbmcgdGhlcmUncyBh IHJlZmVyZW5jZSBzdGlsbAo+IGhlbGQsIHNvIHRoZSB0aW1lc3RhbXAgc2hvdWxkIGJlIGZpbmUg aW4gdGhhdCBjYXNlLiBBbmQgaWYgdGhlcmUgYXJlbid0Cj4gYW55IHJlZmVyZW5jZXMgdGhlIHRp bWVzdGFtcCBzaG91bGRuJ3QgbWF0dGVyLi4uIEkgdGhpbmsuIEJ1dCBpdCdzCj4gcHJvYmFibHkg bW9yZSBjbGVhciB0byBrZWVwIHRvIHRoZSBvcmRlciB5b3UgcHJvcG9zZSBoZXJlIGFueXdheS4K Pgo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+CgpMb29rcyBnb29kIHRvIG1lLiBBcyBhIGZ1cnRoZXIgb3B0aW1pemF0aW9uLCBp IHRoaW5rIHdlIGNvdWxkIG1vdmUgdGhlIAp2YmxhbmtfZGlzYWJsZV9mbigpIGNhbGwgb3V0c2lk ZS9iZWxvdyB0aGUgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSBmb3IgCmV2ZW50X2xvY2ssIGFzIHZi bGFua19kaXNhYmxlX2ZuKCkgZG9lc24ndCBuZWVkIGFueSBsb2NrcyBoZWxkIGF0IGNhbGwgCnRp bWUsIHNvIHNsaWdodGx5IHJlZHVjZSBldmVudF9sb2NrIGhvbGQgdGltZS4gRG9uJ3Qga25vdyBp ZiBpdCBpcyB3b3J0aCBpdC4KCkluIGFueSBjYXNlCgpSZXZpZXdlZC1ieTogTWFyaW8gS2xlaW5l ciA8bWFyaW8ua2xlaW5lci5kZUBnbWFpbC5jb20+Cgp0aGFua3MsCi1tYXJpbwoKPiBPaCwgYW5k IG5vdyB0aGF0IEkgdGhpbmsgYWJvdXQgdGhpcyBzdHVmZiBhZ2FpbiwgSSBzdGFydCB0byB3b25k ZXIgd2h5Cj4gSSBtYWRlIHRoZSBkaXNhYmxlIGFjdHVhbGx5IHVwZGF0ZSB0aGUgc2VxL3RzLiBJ ZiB0aGUgaW50ZXJydXB0IGlzCj4gY3VycmVudGx5IGVuYWJsZWQgdGhlIHNlcS90cyBzaG91bGQg YmUgcmVhc29uYWJseSB1cHRvZGF0ZSBhbHJlYWR5Cj4gd2hlbiB3ZSBkbyBkaXNhYmxlIHRoZSBp bnRlcnJ1cHQuIFBlcmhhcHMgSSB3YXMgb25seSB0aGlua2luZyBhYm91dAo+IGRybV92Ymxhbmtf b2ZmKCkgd2hlbiBJIG1hZGUgdGhhdCBjaGFuZ2UsIG9yIEkgZGVjaWRlZCB0aGF0IEkgZGlkbid0 Cj4gd2FudCB0d28gZGlmZmVyZW50IGRpc2FibGUgY29kZXBhdGhzLiBBbnl3YXlzLCBqdXN0IGFu IGlkZWEgdGhhdAo+IHdlIG1pZ2h0IGJlIGFibGUgdG8gbWFrZSB0aGUgdmJsYW5rIGlycSBkaXNh YmxlIGEgbGl0dGxlIGNoZWFwZXIuCj4KPj4gIAkgKi8KPj4gLQlpZiAoZGV2LT52YmxhbmtfZGlz YWJsZV9pbW1lZGlhdGUgJiYKPj4gLQkgICAgZHJtX3ZibGFua19vZmZkZWxheSA+IDAgJiYKPj4g LQkgICAgIWF0b21pY19yZWFkKCZ2YmxhbmstPnJlZmNvdW50KSkKPj4gKwlkaXNhYmxlX2lycSA9 IChkZXYtPnZibGFua19kaXNhYmxlX2ltbWVkaWF0ZSAmJgo+PiArCQkgICAgICAgZHJtX3ZibGFu a19vZmZkZWxheSA+IDAgJiYKPj4gKwkJICAgICAgICFhdG9taWNfcmVhZCgmdmJsYW5rLT5yZWZj b3VudCkpOwo+PiArCj4+ICsJZHJtX2hhbmRsZV92YmxhbmtfZXZlbnRzKGRldiwgcGlwZSk7Cj4+ ICsKPj4gKwlpZiAoZGlzYWJsZV9pcnEpCj4+ICAJCXZibGFua19kaXNhYmxlX2ZuKCh1bnNpZ25l ZCBsb25nKXZibGFuayk7Cj4+Cj4+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2LT5ldmVu dF9sb2NrLCBpcnFmbGFncyk7Cj4+IC0tCj4+IDIuMTEuMAo+Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=