From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lionel Landwerlin Subject: Re: [PATCH i-g-t v2 2/2] intel_gpu_overlay: Update for class:instance engine tracepoints Date: Wed, 6 Jun 2018 11:29:02 +0100 Message-ID: <409dd7c5-ff6b-37ef-5027-87345e6d39e4@intel.com> References: <152822764202.9058.18039377220321146761@mail.alporthouse.com> <20180606090233.6646-1-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180606090233.6646-1-tvrtko.ursulin@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDYvMDYvMTggMTA6MDIsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+IEZyb206IFR2cnRrbyBV cnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4KPiBBIG1pbWluYWwgaGFjayB0byBw YXJzZSB0aGUgbmV3IHRyYWNlcG9pbnQgZm9ybWF0IGFuZCBpbnZlbnQgbmV3ICJyaW5nCj4gaWQn cyIgYmFzZWQgb24gZW5naW5lIGNsYXNzIGFuZCBpbnN0YW5jZS4KPgo+IHYyOgo+ICAgKiBNYWtl IGl0IGEgYml0IG1vcmUgZnV0dXJlIHByb29mLiAoTGlvbmVsLCBDaHJpcykKPiAgICogU29tZSBh c3NvcnRlZCBmaXh1cHMgdG8gc2hvdyBmb3Jnb3R0ZW4gZW5naW5lcy4KPgo+IFNpZ25lZC1vZmYt Ynk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IExpb25l bCBMYW5kd2VybGluIDxsaW9uZWwuZy5sYW5kd2VybGluQGludGVsLmNvbT4KPiAtLS0KPiAgIG92 ZXJsYXkvZ3B1LXBlcmYuYyB8IDQwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0t LS0tLS0KPiAgIG92ZXJsYXkvb3ZlcmxheS5jICB8IDE3ICsrKysrKysrKy0tLS0tLS0tCj4gICAy IGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+Cj4gZGlm ZiAtLWdpdCBhL292ZXJsYXkvZ3B1LXBlcmYuYyBiL292ZXJsYXkvZ3B1LXBlcmYuYwo+IGluZGV4 IGVhMzQ4MDA1MGFiOS4uNTYyOWY4MjY3NjVlIDEwMDY0NAo+IC0tLSBhL292ZXJsYXkvZ3B1LXBl cmYuYwo+ICsrKyBiL292ZXJsYXkvZ3B1LXBlcmYuYwo+IEBAIC0zMyw2ICszMyw3IEBACj4gICAj aW5jbHVkZSA8c3RyaW5nLmg+Cj4gICAjaW5jbHVkZSA8ZmNudGwuaD4KPiAgICNpbmNsdWRlIDxl cnJuby5oPgo+ICsjaW5jbHVkZSA8YXNzZXJ0Lmg+Cj4gICAKPiAgICNpbmNsdWRlICJpZ3RfcGVy Zi5oIgo+ICAgCj4gQEAgLTg1LDcgKzg2LDggQEAgc3RydWN0IHRyYWNlcG9pbnQgewo+ICAgCj4g ICAJaW50IGRldmljZV9maWVsZDsKPiAgIAlpbnQgY3R4X2ZpZWxkOwo+IC0JaW50IHJpbmdfZmll bGQ7Cj4gKwlpbnQgY2xhc3NfZmllbGQ7Cj4gKwlpbnQgaW5zdGFuY2VfZmllbGQ7Cj4gICAJaW50 IHNlcW5vX2ZpZWxkOwo+ICAgCWludCBnbG9iYWxfc2Vxbm9fZmllbGQ7Cj4gICAJaW50IHBsYW5l X2ZpZWxkOwo+IEBAIC0xNTEsOCArMTUzLDEwIEBAIHRyYWNlcG9pbnRfaWQoaW50IHRwX2lkKQo+ ICAgCQkJCXRwLT5kZXZpY2VfZmllbGQgPSBmOwo+ICAgCQkJfSBlbHNlIGlmICghc3RyY21wKHRw LT5maWVsZHNbZl0ubmFtZSwgImN0eCIpKSB7Cj4gICAJCQkJdHAtPmN0eF9maWVsZCA9IGY7Cj4g LQkJCX0gZWxzZSBpZiAoIXN0cmNtcCh0cC0+ZmllbGRzW2ZdLm5hbWUsICJyaW5nIikpIHsKPiAt CQkJCXRwLT5yaW5nX2ZpZWxkID0gZjsKPiArCQkJfSBlbHNlIGlmICghc3RyY21wKHRwLT5maWVs ZHNbZl0ubmFtZSwgImNsYXNzIikpIHsKPiArCQkJCXRwLT5jbGFzc19maWVsZCA9IGY7Cj4gKwkJ CX0gZWxzZSBpZiAoIXN0cmNtcCh0cC0+ZmllbGRzW2ZdLm5hbWUsICJpbnN0YW5jZSIpKSB7Cj4g KwkJCQl0cC0+aW5zdGFuY2VfZmllbGQgPSBmOwo+ICAgCQkJfSBlbHNlIGlmICghc3RyY21wKHRw LT5maWVsZHNbZl0ubmFtZSwgInNlcW5vIikpIHsKPiAgIAkJCQl0cC0+c2Vxbm9fZmllbGQgPSBm Owo+ICAgCQkJfSBlbHNlIGlmICghc3RyY21wKHRwLT5maWVsZHNbZl0ubmFtZSwgImdsb2JhbF9z ZXFubyIpKSB7Cj4gQEAgLTE3NSw2ICsxNzksMjYgQEAgdHJhY2Vwb2ludF9pZChpbnQgdHBfaWQp Cj4gICAJCQkgICAgIHRyYWNlcG9pbnRzW3RwX2lkXS5maWVsZHNbCQkJXAo+ICAgCQkJCSAgICAg dHJhY2Vwb2ludHNbdHBfaWRdLmZpZWxkX25hbWUjI19maWVsZF0ub2Zmc2V0KSkKPiAgIAo+ICsj ZGVmaW5lIFJFQURfVFBfRklFTERfVTE2KHNhbXBsZSwgdHBfaWQsIGZpZWxkX25hbWUpCQkJXAo+ ICsJKCooY29uc3QgdWludDE2X3QgKikoKHNhbXBsZSktPnRyYWNlcG9pbnRfZGF0YSArCQlcCj4g KwkJCSAgICAgdHJhY2Vwb2ludHNbdHBfaWRdLmZpZWxkc1sJCQlcCj4gKwkJCQkgICAgIHRyYWNl cG9pbnRzW3RwX2lkXS5maWVsZF9uYW1lIyNfZmllbGRdLm9mZnNldCkpCj4gKwo+ICsjZGVmaW5l IEdFVF9SSU5HX0lEKHNhbXBsZSwgdHBfaWQpIFwKPiArKHsgXAo+ICsJdW5zaWduZWQgY2hhciBj bGFzcywgaW5zdGFuY2UsIHJpbmc7IFwKPiArXAo+ICsJY2xhc3MgPSBSRUFEX1RQX0ZJRUxEX1Ux NihzYW1wbGUsIHRwX2lkLCBjbGFzcyk7IFwKPiArCWluc3RhbmNlID0gUkVBRF9UUF9GSUVMRF9V MTYoc2FtcGxlLCB0cF9pZCwgaW5zdGFuY2UpOyBcCj4gK1wKPiArCWFzc2VydChjbGFzcyA8PSBJ OTE1X0VOR0lORV9DTEFTU19WSURFT19FTkhBTkNFKTsgXAo+ICsJYXNzZXJ0KGluc3RhbmNlIDw9 IDQpOyBcCj4gK1wKPiArCXJpbmcgPSBjbGFzcyAqIDQgKyBpbnN0YW5jZTsgXAo+ICtcCj4gKwly aW5nOyBcCj4gK30pCj4gKwo+ICAgc3RhdGljIGludCBwZXJmX3RyYWNlcG9pbnRfb3BlbihzdHJ1 Y3QgZ3B1X3BlcmYgKmdwLCBpbnQgdHBfaWQsCj4gICAJCQkJaW50ICgqZnVuYykoc3RydWN0IGdw dV9wZXJmICosIGNvbnN0IHZvaWQgKikpCj4gICB7Cj4gQEAgLTMxMyw3ICszMzcsNyBAQCBzdGF0 aWMgaW50IHJlcXVlc3RfYWRkKHN0cnVjdCBncHVfcGVyZiAqZ3AsIGNvbnN0IHZvaWQgKmV2ZW50 KQo+ICAgCWlmIChjb21tID09IE5VTEwpCj4gICAJCXJldHVybiAwOwo+ICAgCj4gLQljb21tLT5u cl9yZXF1ZXN0c1tSRUFEX1RQX0ZJRUxEX1UzMihzYW1wbGUsIFRQX0dFTV9SRVFVRVNUX0FERCwg cmluZyldKys7Cj4gKwljb21tLT5ucl9yZXF1ZXN0c1tHRVRfUklOR19JRChzYW1wbGUsIFRQX0dF TV9SRVFVRVNUX0FERCldKys7Cj4gICAJcmV0dXJuIDE7Cj4gICB9Cj4gICAKPiBAQCAtMzI5LDcg KzM1Myw3IEBAIHN0YXRpYyBpbnQgY3R4X3N3aXRjaChzdHJ1Y3QgZ3B1X3BlcmYgKmdwLCBjb25z dCB2b2lkICpldmVudCkKPiAgIHsKPiAgIAljb25zdCBzdHJ1Y3Qgc2FtcGxlX2V2ZW50ICpzYW1w bGUgPSBldmVudDsKPiAgIAo+IC0JZ3AtPmN0eF9zd2l0Y2hbUkVBRF9UUF9GSUVMRF9VMzIoc2Ft cGxlLCBUUF9HRU1fUklOR19TV0lUQ0hfQ09OVEVYVCwgcmluZyldKys7Cj4gKwlncC0+Y3R4X3N3 aXRjaFtHRVRfUklOR19JRChzYW1wbGUsIFRQX0dFTV9SSU5HX1NXSVRDSF9DT05URVhUKV0rKzsK PiAgIAlyZXR1cm4gMTsKPiAgIH0KPiAgIAo+IEBAIC0zNjcsOCArMzkxLDggQEAgc3RhdGljIGlu dCB3YWl0X2JlZ2luKHN0cnVjdCBncHVfcGVyZiAqZ3AsIGNvbnN0IHZvaWQgKmV2ZW50KQo+ICAg CXdhaXQtPmNvbnRleHQgPSBSRUFEX1RQX0ZJRUxEX1UzMihzYW1wbGUsIFRQX0dFTV9SRVFVRVNU X1dBSVRfQkVHSU4sIGN0eCk7Cj4gICAJd2FpdC0+c2Vxbm8gPSBSRUFEX1RQX0ZJRUxEX1UzMihz YW1wbGUsIFRQX0dFTV9SRVFVRVNUX1dBSVRfQkVHSU4sIHNlcW5vKTsKPiAgIAl3YWl0LT50aW1l ID0gc2FtcGxlLT50aW1lOwo+IC0Jd2FpdC0+bmV4dCA9IGdwLT53YWl0W1JFQURfVFBfRklFTERf VTMyKHNhbXBsZSwgVFBfR0VNX1JFUVVFU1RfV0FJVF9CRUdJTiwgcmluZyldOwo+IC0JZ3AtPndh aXRbUkVBRF9UUF9GSUVMRF9VMzIoc2FtcGxlLCBUUF9HRU1fUkVRVUVTVF9XQUlUX0JFR0lOLCBy aW5nKV0gPSB3YWl0Owo+ICsJd2FpdC0+bmV4dCA9IGdwLT53YWl0W0dFVF9SSU5HX0lEKHNhbXBs ZSwgVFBfR0VNX1JFUVVFU1RfV0FJVF9CRUdJTildOwo+ICsJZ3AtPndhaXRbR0VUX1JJTkdfSUQo c2FtcGxlLCBUUF9HRU1fUkVRVUVTVF9XQUlUX0JFR0lOKV0gPSB3YWl0Owo+ICAgCj4gICAJcmV0 dXJuIDA7Cj4gICB9Cj4gQEAgLTM3Nyw3ICs0MDEsNyBAQCBzdGF0aWMgaW50IHdhaXRfZW5kKHN0 cnVjdCBncHVfcGVyZiAqZ3AsIGNvbnN0IHZvaWQgKmV2ZW50KQo+ICAgewo+ICAgCWNvbnN0IHN0 cnVjdCBzYW1wbGVfZXZlbnQgKnNhbXBsZSA9IGV2ZW50Owo+ICAgCXN0cnVjdCBncHVfcGVyZl90 aW1lICp3YWl0LCAqKnByZXY7Cj4gLQl1aW50MzJfdCBlbmdpbmUgPSBSRUFEX1RQX0ZJRUxEX1Uz MihzYW1wbGUsIFRQX0dFTV9SRVFVRVNUX1dBSVRfRU5ELCByaW5nKTsKPiArCXVpbnQzMl90IGVu Z2luZSA9IEdFVF9SSU5HX0lEKHNhbXBsZSwgVFBfR0VNX1JFUVVFU1RfV0FJVF9FTkQpOwo+ICAg CXVpbnQzMl90IGNvbnRleHQgPSBSRUFEX1RQX0ZJRUxEX1UzMihzYW1wbGUsIFRQX0dFTV9SRVFV RVNUX1dBSVRfRU5ELCBjdHgpOwo+ICAgCXVpbnQzMl90IHNlcW5vID0gUkVBRF9UUF9GSUVMRF9V MzIoc2FtcGxlLCBUUF9HRU1fUkVRVUVTVF9XQUlUX0VORCwgc2Vxbm8pOwo+ICAgCj4gZGlmZiAt LWdpdCBhL292ZXJsYXkvb3ZlcmxheS5jIGIvb3ZlcmxheS9vdmVybGF5LmMKPiBpbmRleCA1NDVh ZjdiY2IyZjUuLmVhZTVkZGZhODgyMyAxMDA2NDQKPiAtLS0gYS9vdmVybGF5L292ZXJsYXkuYwo+ ICsrKyBiL292ZXJsYXkvb3ZlcmxheS5jCj4gQEAgLTE0OCw2ICsxNDgsNyBAQCBzdGF0aWMgdm9p ZCBpbml0X2dwdV90b3Aoc3RydWN0IG92ZXJsYXlfY29udGV4dCAqY3R4LAo+ICAgCQl7IDAuMjUs IDEsIDAuMjUsIDEgfSwKPiAgIAkJeyAwLjI1LCAwLjI1LCAxLCAxIH0sCj4gICAJCXsgMSwgMSwg MSwgMSB9LAo+ICsJCXsgMSwgMSwgMC4yNSwgMSB9LAo+ICAgCX07Cj4gICAJaW50IG47Cj4gICAK PiBAQCAtMzExLDExICszMTIsMTEgQEAgc3RhdGljIHZvaWQgc2hvd19ncHVfcGVyZihzdHJ1Y3Qg b3ZlcmxheV9jb250ZXh0ICpjdHgsIHN0cnVjdCBvdmVybGF5X2dwdV9wZXJmICoKPiAgIAkJeyAx LCAxLCAxLCAxIH0sCj4gICAJfTsKPiAgIAlzdHJ1Y3QgZ3B1X3BlcmZfY29tbSAqY29tbSwgKipw cmV2Owo+IC0JY29uc3QgY2hhciAqcmluZ19uYW1lW10gPSB7Cj4gLQkJIlIiLAo+IC0JCSJCIiwK PiAtCQkiVjAiLAo+IC0JCSJWMSIsCj4gKwljb25zdCBjaGFyICpyaW5nX25hbWVbTUFYX1JJTkdT XSA9IHsKPiArCQkiUiIsICI/IiwgIj8iLCAiPyIsCj4gKwkJIkIiLCAiPyIsICI/IiwgIj8iLAo+ ICsJCSJWMCIsICJWMSIsICI/IiwgIj8iLAo+ICsJCSJWRTAiLCAiPyIsICI/IiwgIj8iLAo+ICAg CX07CgpJIGd1ZXNzIGlmIHlvdSBkZWZpbmVkIGEgTUFYX0VOR0lORV9JTlNUQU5DRVMgc29tZXdo ZXJlLCB5b3UgY291bGQganVzdCAKaGF2ZSBhbiBhcnJheSBvZiBjbGFzcyBuYW1lcyBhbmQgdGhl biBnZW5lcmF0ZSByaW5nX25hbWUgb2ZmIHRoZSBuIAp2YXJpYWJsZSBmdXJ0aGVyIGJlbG93LgoK Y2xhc3MgPSBuIC8gTUFYX0VOR0lORV9JTlNUQU5DRVMKaW5zdGFuY2UgPSBuICUgTUFYX0VOR0lO RV9JTlNUQU5DRVMKCnNucHJpbnRmKHJpbmdfbmFtZSwgc2l6ZW9mKHJpbmdfbmFtZSksICIlcyVp IiwgY2xhc3NfbmFtZXNbY2xhc3NdLCAKaW5zdGFuY2UpOwoKCkp1c3QgYSBzdWdnZXN0aW9uLCBy ZWdhcmRsZXNzIDoKClJldmlld2VkLWJ5OiBMaW9uZWwgTGFuZHdlcmxpbiA8bGlvbmVsLmcubGFu ZHdlcmxpbkBpbnRlbC5jb20+Cgo+ICAgCWRvdWJsZSByYW5nZVsyXTsKPiAgIAljaGFyIGJ1Zlsx MDI0XTsKPiBAQCAtMzI2LDcgKzMyNyw3IEBAIHN0YXRpYyB2b2lkIHNob3dfZ3B1X3BlcmYoc3Ry dWN0IG92ZXJsYXlfY29udGV4dCAqY3R4LCBzdHJ1Y3Qgb3ZlcmxheV9ncHVfcGVyZiAqCj4gICAK PiAgIAlncHVfcGVyZl91cGRhdGUoJmdwLT5ncHVfcGVyZik7Cj4gICAKPiAtCWZvciAobiA9IDA7 IG4gPCA0OyBuKyspIHsKPiArCWZvciAobiA9IDA7IG4gPCBNQVhfUklOR1M7IG4rKykgewo+ICAg CQlpZiAoZ3AtPmdwdV9wZXJmLmN0eF9zd2l0Y2hbbl0pCj4gICAJCQloYXNfY3R4ID0gbiArIDE7 Cj4gICAJCWlmIChncC0+Z3B1X3BlcmYuZmxpcF9jb21wbGV0ZVtuXSkKPiBAQCAtMzg5LDcgKzM5 MCw3IEBAIHN0YXRpYyB2b2lkIHNob3dfZ3B1X3BlcmYoc3RydWN0IG92ZXJsYXlfY29udGV4dCAq Y3R4LCBzdHJ1Y3Qgb3ZlcmxheV9ncHVfcGVyZiAqCj4gICAJCX0KPiAgIAo+ICAgCQl0b3RhbCA9 IDA7Cj4gLQkJZm9yIChuID0gMDsgbiA8IDM7IG4rKykKPiArCQlmb3IgKG4gPSAwOyBuIDwgTUFY X1JJTkdTOyBuKyspCj4gICAJCQl0b3RhbCArPSBjb21tLT5ucl9yZXF1ZXN0c1tuXTsKPiAgIAkJ Y2hhcnRfYWRkX3NhbXBsZShjb21tLT51c2VyX2RhdGEsIHRvdGFsKTsKPiAgIAl9Cj4gQEAgLTQz Myw3ICs0MzQsNyBAQCBzdGF0aWMgdm9pZCBzaG93X2dwdV9wZXJmKHN0cnVjdCBvdmVybGF5X2Nv bnRleHQgKmN0eCwgc3RydWN0IG92ZXJsYXlfZ3B1X3BlcmYgKgo+ICAgCQkJZ290byBza2lwX2Nv bW07Cj4gICAKPiAgIAkJbGVuID0gc3ByaW50ZihidWYsICIlczoiLCBjb21tLT5uYW1lKTsKPiAt CQlmb3IgKG4gPSAwOyBuIDwgc2l6ZW9mKHJpbmdfbmFtZSkvc2l6ZW9mKHJpbmdfbmFtZVswXSk7 IG4rKykgewo+ICsJCWZvciAobiA9IDA7IG4gPCBNQVhfUklOR1M7IG4rKykgewo+ICAgCQkJaWYg KGNvbW0tPm5yX3JlcXVlc3RzW25dID09IDApCj4gICAJCQkJY29udGludWU7Cj4gICAJCQlsZW4g Kz0gc3ByaW50ZihidWYgKyBsZW4sICIlcyAlZCVzIiwgbmVlZF9jb21tYSA/ICIsIiA6ICIiLCBj b21tLT5ucl9yZXF1ZXN0c1tuXSwgcmluZ19uYW1lW25dKTsKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK