From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 02/13] drm/i915: Introduce the i915_user_extension_method Date: Wed, 13 Mar 2019 11:13:10 +0000 Message-ID: <416b041d-ab92-5dd4-03a0-c0320ad95b61@linux.intel.com> References: <20190308141244.16837-1-chris@chris-wilson.co.uk> <20190308141244.16837-3-chris@chris-wilson.co.uk> <155247421525.30003.1677063484586585461@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA35D6E096 for ; Wed, 13 Mar 2019 11:13:13 +0000 (UTC) In-Reply-To: <155247421525.30003.1677063484586585461@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEzLzAzLzIwMTkgMTA6NTAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTA4IDE0OjMzOjAyKQo+Pgo+PiBPbiAwOC8wMy8yMDE5IDE0OjEy LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiAraW50IGk5MTVfdXNlcl9leHRlbnNpb25zKHN0cnVj dCBpOTE1X3VzZXJfZXh0ZW5zaW9uIF9fdXNlciAqZXh0LAo+Pj4gKyAgICAgICAgICAgICAgICAg ICAgICBjb25zdCBpOTE1X3VzZXJfZXh0ZW5zaW9uX2ZuICp0YmwsCj4+PiArICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGxvbmcgY291bnQsCj4+PiArICAgICAgICAgICAgICAgICAgICAg IHZvaWQgKmRhdGEpCj4+PiArewo+Pj4gKyAgICAgdW5zaWduZWQgaW50IHN0YWNrZGVwdGggPSA1 MTI7Cj4+Cj4+IEkgaGF2ZSBkb3VidHMgYWJvdXQgdXNlZnVsbmVzcyBvZiB0cnlpbmcgdG8gaW1w b3NlIHNvbWUgbGltaXQgbm93LiBBbmQKPj4gYWxzbyByZXNlcnZhdGlvbnMgYWJvdXQgdXNpbmcg dGhlIG5hbWUgc3RhY2suIEJ1dCBib3RoIGFyZSBpcnJlbGV2YW50Cj4+IGltcGxlbWVudGF0aW9u IGRldGFpbHMgYXQgdGhpcyBzdGFnZSBzbyBtZWguCj4gCj4gV2UgbmVlZCBkZWZlbmNlIGFnYWlu c3QgbWFsaWNlIHVzZXJzcGFjZSBkb2luZwo+IAlzdHJ1Y3QgaTkxNV91c2VyX2V4dGVuc2lvbiBl eHQgPSB7Cj4gCQkubmV4dF9leHRlbnNpb24gPSAmZXh0LAo+IAl9Owo+IHNvIHNhZGx5IHNvbWUg bGltaXQgaXMgcmVxdWlyZWQuCgpPaCB5ZXMsIGdvb2QgcG9pbnQuIEkgd2Fzbid0IHRoaW5raW5n IG1hbGljaW91c2x5IGVub3VnaC4KClMgcG9zc2libGUgYWx0ZXJuYXRpdmUgc29sdXRpb24gY291 bGQgYmUsIGluIGNvbmp1bmN0aW9uIHdpdGggdGhlIHJlc3VsdCAKZmllbGQgZnJvbSBiZWxvdywg dG8gb25seSBhbGxvdyB2aXNpdGluZyBhbnkgZXh0ZW5zaW9uIG9uY2UuIEl0IHdvdWxkIApyZXF1 aXJlIHJlc2VydmluZyBzb21lIHZhbHVlIGFzIG1lYW5pbmcgIm5vdCB2aXNpdGVkIi4gUHJvYmFi bHkgemVybywgc28gCm5vbi16ZXJvIGluIHJlc3VsdCB3b3VsZCBpbW1lZGlhdGVseSBmYWlsIHRo ZSBjaGFpbiwgYnV0IHdvdWxkIGFsc28gSSAKdGhpbmsgbWVhbiB3ZSBvbmx5IHN1cHBvcnQgbmVn YXRpdmUgdmFsdWVzIGluIHJlc3VsdCBhcyBvdXRwdXQsIG1hcHBpbmcgCnplcm9zIHRvIG9uZS4K Cj4+PiArCj4+PiArICAgICB3aGlsZSAoZXh0KSB7Cj4+PiArICAgICAgICAgICAgIGludCBlcnI7 Cj4+PiArICAgICAgICAgICAgIHU2NCB4Owo+Pj4gKwo+Pj4gKyAgICAgICAgICAgICBpZiAoIXN0 YWNrZGVwdGgtLSkgLyogcmVjdXJzaW9uIHZzIHVzZWZ1bCBmbGV4aWJpbGl0eSAqLwo+Pj4gKyAg ICAgICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Pj4gKwo+Pj4gKyAgICAgICAgICAg ICBpZiAoZ2V0X3VzZXIoeCwgJmV4dC0+bmFtZSkpCj4+PiArICAgICAgICAgICAgICAgICAgICAg cmV0dXJuIC1FRkFVTFQ7Cj4+PiArCj4+PiArICAgICAgICAgICAgIGVyciA9IC1FSU5WQUw7Cj4+ PiArICAgICAgICAgICAgIGlmICh4IDwgY291bnQgJiYgdGJsW3hdKQo+Pj4gKyAgICAgICAgICAg ICAgICAgICAgIGVyciA9IHRibFt4XShleHQsIGRhdGEpOwo+Pgo+PiBIb3cgYWJvdXQ6Cj4+Cj4+ ICAgICAgICAgICAgICAgICAgcHV0X3VzZXIoZXJyLCAmZXh0LT5yZXN1bHQpOwo+Pgo+PiBBbmQ6 Cj4+Cj4+IHN0cnVjdCBpOTE1X3VzZXJfZXh0ZW5zaW9uIHsKPj4gICAgICAgICAgX191NjQgbmV4 dF9leHRlbnNpb247Cj4+ICAgICAgICAgIF9fdTY0IG5hbWU7Cj4+ICAgICAgICAgIF9fdTMyIHJl c3VsdDsKPj4gICAgICAgICAgX191MzIgbWJ6Owo+PiB9Owo+Pgo+PiBTbyB3ZSBhZGQgdGhlIGFi aWxpdHkgZm9yIGVhY2ggZXh0ZW5zaW9uIHRvIHN0b3JlIGl0J3MgZXhpdCBjb2RlIGdpdmluZwo+ PiB1c2Vyc3BhY2Ugb3Bwb3J0dW5pdHkgdG8ga25vdyB3aGljaCBvbmUgZmFpbGVkLgo+Pgo+PiBX aXRoIHRoaXMgSSB3b3VsZCBiZSBzYXRpc2ZpZWQgdXNhYmlsaXR5IGlzIGZ1dHVyZSBwcm9vZiBl bm91Z2guCj4gCj4gSSdtIHNvcmVseSB0ZW1wdGVkLiBUaGUgYmlnZ2VzdCBvYmplY3Rpb24gSSBo YXZlIGlzIHRoaXMgZGVmZWF0cyB0aGUKPiBlbGVnYW5jZSBvZiBhIHJlYWQtb25seSBjaGFpbi4g U28gd2hvIHdvdWxkIGFjdHVhbGx5IHVzZSBpdD8KPiAKPiBlcnIgPSBnZW1fY29udGV4dF9jcmVh dGVfZXh0KCZjaGFpbik7Cj4gaWYgKGVycikgewo+IAlzdHJ1Y3QgaTkxNV91c2VyX2V4dGVuc2lv biAqZXh0ID0gKHN0cnVjdCBpOTE1X3VzZXJfZXh0ZW5zaW9uICopY2hhaW47Cj4gCXdoaWxlIChl eHQgJiYgIWV4dC0+cmVzdWx0KQo+IAkJZXh0ID0gKHN0cnVjdCBpOTE1X3VzZXJfZXh0ZW5zaW9u ICopZXh0LT5uZXh0X2V4dGVuc2lvbjsKPiAJaWYgKGV4dCkKPiAJCWZwcmludGYoc3RkZXJyLCAi Y29udGV4dCBjcmVhdGlvbiBmYWlsZWQgYXQgZXh0ZW5zaW9uOiAlbGxkIiwgZXh0LT5uYW1lKTsK PiB9Cj4gCj4gV2hhdCBleGFjdGx5IGFyZSB0aGV5IGdvaW5nIHRvIGRvPyBUaGV5IGFyZSBub3Qg Z29pbmcgdG8gZG8gYW55dGhpbmcKPiBsaWtlCj4gCXdoaWxlIChlcnIpIHsKPiAJCWV4dCA9IGZp cnN0X2ZhdWx0eV9leHQoJmNoYWluKTsKPiAJCXN3aXRjaCAoZXh0LT5uYW1lKSB7Cj4gCQljYXNl IC4uLjogIGRvX2ZpeHVwX0EoZXh0KTsKPiAJCX0KPiAJCWVyciA9IGdlbV9jb250ZXh0X2NyZWF0 ZV9leHQoJmNoYWluKTsKPiAJfQo+IAo+IEknbSBub3QgcmVhbGx5IHNlZWluZyBob3cgdGhleSBi ZW5lZml0IG92ZXIsIGFuZCBhYm92ZSwgaGFuZGxpbmcgdGhlCj4gaW9jdGwgZXJyb3IgYnkgcHJp bnRpbmcgb3V0IHRoZSBlbnRpcmUgZXJyb25lb3VzIHN0cnVjdCBhbmQgY2hhaW4sIGFuZAo+IGZh bGxpbmcgYmFjayB0byBhdm9pZGluZyB0aGF0IGlvY3RsLgo+IAo+IEkgdGhpbmsgd2hhdCB5b3Ug cmVhbGx5IHdhbnQgaXMgYSBwZXItYXBwbGljYXRpb24vZmQgZGVidWcgbG9nLCBzbyB0aGF0Cj4g d2UgY2FuIGR1bXAgdGhlIGFjdHVhbCBlcnJvcnMgYXMgdGhleSBhcmlzZSAod2l0aG91dCBsZWFr aW5nIHRoZW0gaW50bwo+IHRoZSBnZW5lcmFsIHN5c2xvZykuCgpNYXliZS4uIGNvdWxkIGJlIGFu IGV4dGVuc2lvbiBvZiB0aGUgZXhpc3RpbmcgcHJvYmxlbSBvZiAiV2hhdCBFSU5WQUwgCnlvdSBt ZWFuIGV4YWN0bHk/IiBpbmRlZWQuCgpJIGRvbid0IHNlZSBhIHByb2JsZW0gd2l0aCB3cml0aW5n IGJhY2sgdGhvdWdoPwoKUmVnYXJkcywKClR2cnRrbwoKCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4