From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0257CCFA13 for ; Mon, 10 Nov 2025 09:03:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 85CD110E2AE; Mon, 10 Nov 2025 09:03:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PcLqfOp3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id DCF2C10E173; Mon, 10 Nov 2025 09:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762765396; x=1794301396; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=yU6LiGee29Hm/OHfAO0x+GuK2AbKddsOz2vgNLRz8eU=; b=PcLqfOp3nUs2ppzfCAlWjD1CBGLXxsfdG4cXwvPZnUBbJ5bl7mucccjX zwEAFnZrOLvcvBJEj00FA/rf3uzxUmY99CA442iv+FvBnid/EBkOKYuHI qA8InLHA0ojoFkHid211wdz7wNVueRBT4mDcvn1JG5oG9lEN91utJHz88 +kQlRnh12rx0JagChBEtkkbJkE0gDLicN93oTJ1BwWkYRckMpKkDoXn4K wQUGMO5eKHWpUiRf7YoVVrB/4AsmHB+7hGKYI6P4OyqRKsBVRlhpTW+Wd eu8SVNazejL6WVrHjRGalrgqAFWT/yvBdNDrfz+CI2s7/+CqaiCPz3+wV w==; X-CSE-ConnectionGUID: hOdjKSqZQgmtpqGtmSsTTQ== X-CSE-MsgGUID: QOHxCaXYTSO7ARaI9Kmjcw== X-IronPort-AV: E=McAfee;i="6800,10657,11608"; a="68454361" X-IronPort-AV: E=Sophos;i="6.19,293,1754982000"; d="scan'208";a="68454361" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2025 01:03:15 -0800 X-CSE-ConnectionGUID: UeyHMpycQFSrVmsJsyJhmQ== X-CSE-MsgGUID: 5agut2yqTAGPewinEqOeAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,293,1754982000"; d="scan'208";a="193006102" Received: from ettammin-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.246.202]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2025 01:03:13 -0800 From: Jani Nikula To: Animesh Manna , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Animesh Manna , Jouni =?utf-8?Q?H=C3=B6gander?= Subject: Re: [PATCH v2 03/10] drm/i915/alpm: Enable debugfs for DP2.1 In-Reply-To: <20251103220957.1229608-4-animesh.manna@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20251103220957.1229608-1-animesh.manna@intel.com> <20251103220957.1229608-4-animesh.manna@intel.com> Date: Mon, 10 Nov 2025 11:03:10 +0200 Message-ID: <4288b58364e6fdf88b1132813fdd04430621719a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 04 Nov 2025, Animesh Manna wrote: > Enable AlPM debug info through lobf debug info. > > Cc: Jouni H=C3=B6gander > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/= i915/display/intel_alpm.c > index 639941e332f3..779718d0c8dd 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > @@ -541,9 +541,15 @@ void intel_alpm_lobf_debugfs_add(struct intel_connec= tor *connector) > struct intel_display *display =3D to_intel_display(connector); > struct dentry *root =3D connector->base.debugfs_entry; >=20=20 > - if (DISPLAY_VER(display) < 20 || > - connector->base.connector_type !=3D DRM_MODE_CONNECTOR_eDP) > + if (connector->base.connector_type =3D=3D DRM_MODE_CONNECTOR_DisplayPor= t) { > + if (DISPLAY_VER(display) < 35) > + return; > + } else if (connector->base.connector_type =3D=3D DRM_MODE_CONNECTOR_eDP= ) { > + if (DISPLAY_VER(display) < 20) > + return; > + } else { > return; > + } These are the same conditions that you're sprinkling all over the place in the previous patch, and basically boil down to "does the connector support alpm?" BR, Jani. >=20=20 > debugfs_create_file("i915_edp_lobf_debug", 0644, root, > connector, &i915_edp_lobf_debug_fops); --=20 Jani Nikula, Intel