From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91214CD4851 for ; Wed, 13 May 2026 16:15:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30EC110EF62; Wed, 13 May 2026 16:15:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="XFI/fIUY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D92510EF61; Wed, 13 May 2026 16:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778688924; x=1810224924; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=9y2ssJSseoAiZ5/pXIcWPaRD7ZJXvdnmxFV/sZ/3qI4=; b=XFI/fIUYEQENfnTvhCW4sZg8dZdsYOnN9wv2QX4zDsEGuDm4UNeEgrQ4 onGwC4nbNdtHrMwwHV7f87gFeaADlI5PMXNpSqtSUo+AG2YE0gOl4a6iC dlbzCTs8d436O6GFHQtGESaPT7PVe/SnJBqgfHIq0XljYpMi15TXWut79 ngyAlkEsdb+vLzpcIj5sbYZqdyucWEAAkXN82z9GYqgbEmO0s35JOFMJI IziT0Cjap35iGkQ0LsEZVFxKTAg+7xPilBuM4pvTkovBT2LaAYM0Ij3HR CPwku/ApqEfVupEbBPrYm9SyEdCAqHP4DFhslg47O3fo4FumRjqg7SF5g Q==; X-CSE-ConnectionGUID: m9m4jXCAQvW2ihR+Pkdweg== X-CSE-MsgGUID: 6nQsDqinQvC5IZsxVxcXQA== X-IronPort-AV: E=McAfee;i="6800,10657,11785"; a="79798517" X-IronPort-AV: E=Sophos;i="6.23,233,1770624000"; d="scan'208";a="79798517" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 09:15:23 -0700 X-CSE-ConnectionGUID: PJHpBvoLTRK3HFy9kAtGBQ== X-CSE-MsgGUID: b0DKqceITFOctdAAq++gTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,233,1770624000"; d="scan'208";a="233679751" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.124]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 09:15:21 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v3 5/6] drm/i915/irq: add intel_display_irq_ack() to irq funcs In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: Date: Wed, 13 May 2026 19:15:19 +0300 Message-ID: <42aec4c84127ecabc3abd30b058d9b471a38d1c6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 13 May 2026, Ville Syrj=C3=A4l=C3=A4 wrote: > On Wed, May 13, 2026 at 01:10:10PM +0300, Jani Nikula wrote: >> Some platforms have a separate step for acking display irqs. Call the >> platform specific display irq ack hooks, if any, via >> intel_display_irq_ack(). >>=20 >> Introduce struct intel_display_irq_state to group together all the data >> the ack hooks need. In the follow-up, this state will be passed on to a >> shared handler function. > > This also might be a bit cleaner done in two steps: > 1. extract the gmch ack() funcs > 2. add the vfunc Sent v4 splitting patches 5-6 into two steps. BR, Jani. --=20 Jani Nikula, Intel