From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Anusha Srivatsa <anusha.srivatsa@intel.com>,
intel-gfx@lists.freedesktop.org,
Jeff McGee <jeff.mcgee@intel.com>
Subject: Re: [PATCH] drm/i915: Always load guc by default.
Date: Thu, 24 Nov 2016 08:31:22 +0000 [thread overview]
Message-ID: <44beca7c-f187-dbb0-241c-ae24df971cae@linux.intel.com> (raw)
In-Reply-To: <20161124082123.GD6546@nuc-i3427.alporthouse.com>
On 24/11/2016 08:21, Chris Wilson wrote:
> On Thu, Nov 24, 2016 at 08:15:31AM +0000, Tvrtko Ursulin wrote:
>>
>> On 24/11/2016 07:13, Chris Wilson wrote:
>>> On Wed, Nov 23, 2016 at 04:52:38PM -0800, Anusha Srivatsa wrote:
>>>> Remove the enable_guc_loading parameter. Load the GuC on
>>>> plaforms that have GuC. All issues we found so far are related
>>>> to GuC features like the command submission, but no bug is related
>>>> to the guc loading itself.
>>>>
>>>> This addresses the case when we need GuC loaded even with no GuC feature
>>>> in use, like - GuC authenticating HuC loading.
>>>
>>> Why not just load the firmware if it may be used?
>>
>> It was discussed briefly in the other thread, but I suppose as soon
>> as the HuC patches go in that would be always so it may not be that
>> useful.
>>
>> Unless there is a reason to add a HuC enable/disable parameter in
>> general. I have no idea on that one.
>
> In hindsight, we should have had i915.enable_dmc to easily protect users
> against failures. History says we will regret enabling a new piece of
> hw/fw without a feature option.
So..
1. Add i915.enable_huc, default to enabled
2. Unexport i915.enable_guc_loading
3. Gate enable_guc_loading by i915.enable_huc and
i915.enable_guc_submission
?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-24 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 0:52 [PATCH] drm/i915: Always load guc by default Anusha Srivatsa
2016-11-24 7:13 ` Chris Wilson
2016-11-24 8:15 ` Tvrtko Ursulin
2016-11-24 8:21 ` Chris Wilson
2016-11-24 8:31 ` Tvrtko Ursulin [this message]
2016-11-24 8:41 ` Chris Wilson
2016-12-02 18:11 ` Srivatsa, Anusha
2016-12-03 16:39 ` Chris Wilson
2016-11-24 8:31 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44beca7c-f187-dbb0-241c-ae24df971cae@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jeff.mcgee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox