From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915/sdvo: clean up connectors on intel_sdvo_init() failures Date: Mon, 12 Nov 2012 16:52:06 +0000 Message-ID: <453bf0$6egvnu@azsmga001.ch.intel.com> References: <648e4ccc5905fd977c69a8dbab0074b05bd56596.1352737835.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1276623822==" Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id AC7A19EF4F for ; Mon, 12 Nov 2012 08:52:10 -0800 (PST) In-Reply-To: <648e4ccc5905fd977c69a8dbab0074b05bd56596.1352737835.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org, daniel@ffwll.ch Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org --===============1276623822== Content-Type: text/plain On Mon, 12 Nov 2012 18:31:35 +0200, Jani Nikula wrote: > Any failures in intel_sdvo_init() after the intel_sdvo_setup_output() call > left behind ghost connectors, attached (with a dangling pointer) to the > sdvo that has been cleaned up and freed. Properly destroy any connectors > attached to the encoder. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46381 > CC: Chris Wilson > Signed-off-by: Jani Nikula > > --- > > This is *completely* untested, and I don't really know if the connector > loop is okay or naïve in some way... Please review and test carefully. CC > Chris in case this addresses his SDVO EDID failures too. Sadly not. The issue in question, for readers at home, is that after commit 9cd300e038d492af4990b04e127e0bd2df64b1ca Author: Jani Nikula Date: Fri Oct 19 14:51:52 2012 +0300 drm/i915: Move cached EDID to intel_connector Move the cached EDID from intel_dp and intel_lvds_connector to intel_connector. Unify cached EDID handling for LVDS and eDP, in preparation for adding more generic EDID caching later. I lose the EDID on a SDVO-LVDS device (an ilk dual LVDS and SDVO-LVDS Libretto W105). -Chris -- Chris Wilson, Intel Open Source Technology Centre --===============1276623822== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1276623822==--