From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 09/13] drm/i915: Extend I915_CONTEXT_PARAM_SSEU to support local ctx->engine[] Date: Fri, 8 Mar 2019 16:31:51 +0000 Message-ID: <46560f29-2cf3-fbd3-d29d-c9635b246996@linux.intel.com> References: <20190308141244.16837-1-chris@chris-wilson.co.uk> <20190308141244.16837-10-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 442236E3F1 for ; Fri, 8 Mar 2019 16:31:53 +0000 (UTC) In-Reply-To: <20190308141244.16837-10-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA4LzAzLzIwMTkgMTQ6MTIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBbGxvdyB0aGUgdXNl ciB0byBzcGVjaWZ5IGEgbG9jYWwgZW5naW5lIGluZGV4IChhcyBvcHBvc2VkIHRvCj4gY2xhc3M6 aW5kZXgpIHRoYXQgdGhleSBjYW4gdXNlIHRvIHJlZmVyIHRvIGEgcHJlc2V0IGVuZ2luZSBpbnNp ZGUgdGhlCj4gY3R4LT5lbmdpbmVbXSBhcnJheSBkZWZpbmVkIGJ5IGFuIGVhcmxpZXIgSTkxNV9D T05URVhUX1BBUkFNX0VOR0lORVMuCj4gVGhpcyB3aWxsIGJlIHVzZWZ1bCBmb3Igc2V0dGluZyBT U0VVIHBhcmFtZXRlcnMgb24gdmlydHVhbCBlbmdpbmVzIHRoYXQKPiBhcmUgbG9jYWwgdG8gdGhl IGNvbnRleHQgYW5kIGRvIG5vdCBoYXZlIGEgdmFsaWQgZ2xvYmFsIGNsYXNzOmluc3RhbmNlCj4g bG9va3VwLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29t Pgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jIHwgMjQg KysrKysrKysrKysrKysrKysrKystLS0tCj4gICBpbmNsdWRlL3VhcGkvZHJtL2k5MTVfZHJtLmgg ICAgICAgICAgICAgfCAgMyArKy0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygr KSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fY29udGV4dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4 dC5jCj4gaW5kZXggODZkOWJlYTZmMjc1Li5hNTgxYzAxZmZmZjEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jCj4gQEAgLTEzMTMsNiArMTMxMyw3IEBAIHN0YXRp YyBpbnQgc2V0X3NzZXUoc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCwKPiAgIAlzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX2NvbnRleHRfcGFyYW1fc3NldSB1c2VyX3NzZXU7Cj4gICAJc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+ICAgCXN0cnVjdCBpbnRlbF9zc2V1IHNzZXU7Cj4gKwl1 bnNpZ25lZCBsb25nIGxvb2t1cDsKClBvb3IgMzItYml0IGJ1aWxkcy4gOykgQW5kIGluIGxvb2t1 cF91c2VyX2VuZ2luZSBhcyB3ZWxsLgoKPiAgIAlpbnQgcmV0Owo+ICAgCj4gICAJaWYgKGFyZ3Mt PnNpemUgPCBzaXplb2YodXNlcl9zc2V1KSkKPiBAQCAtMTMyNSwxMCArMTMyNiwxNyBAQCBzdGF0 aWMgaW50IHNldF9zc2V1KHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4gICAJCQkgICBz aXplb2YodXNlcl9zc2V1KSkpCj4gICAJCXJldHVybiAtRUZBVUxUOwo+ICAgCj4gLQlpZiAodXNl cl9zc2V1LmZsYWdzIHx8IHVzZXJfc3NldS5yc3ZkKQo+ICsJaWYgKHVzZXJfc3NldS5yc3ZkKQo+ ICAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgIAo+IC0JZW5naW5lID0gbG9va3VwX3VzZXJfZW5naW5l KGN0eCwgMCwKPiArCWlmICh1c2VyX3NzZXUuZmxhZ3MgJiB+KEk5MTVfQ09OVEVYVF9TU0VVX0ZM QUdfRU5HSU5FX0lOREVYKSkKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gKwlsb29rdXAgPSAw Owo+ICsJaWYgKHVzZXJfc3NldS5mbGFncyAmIEk5MTVfQ09OVEVYVF9TU0VVX0ZMQUdfRU5HSU5F X0lOREVYKQo+ICsJCWxvb2t1cCB8PSBMT09LVVBfVVNFUl9JTkRFWDsKPiArCj4gKwllbmdpbmUg PSBsb29rdXBfdXNlcl9lbmdpbmUoY3R4LCBsb29rdXAsCj4gICAJCQkJICAgIHVzZXJfc3NldS5l bmdpbmVfY2xhc3MsCj4gICAJCQkJICAgIHVzZXJfc3NldS5lbmdpbmVfaW5zdGFuY2UpOwo+ICAg CWlmICghZW5naW5lKQo+IEBAIC0xODA3LDYgKzE4MTUsNyBAQCBzdGF0aWMgaW50IGdldF9zc2V1 KHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV9j b250ZXh0X3BhcmFtX3NzZXUgdXNlcl9zc2V1Owo+ICAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZTsKPiAgIAlzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY2U7Cj4gKwl1bnNpZ25lZCBsb25n IGxvb2t1cDsKPiAgIAo+ICAgCWlmIChhcmdzLT5zaXplID09IDApCj4gICAJCWdvdG8gb3V0Owo+ IEBAIC0xODE3LDEwICsxODI2LDE3IEBAIHN0YXRpYyBpbnQgZ2V0X3NzZXUoc3RydWN0IGk5MTVf Z2VtX2NvbnRleHQgKmN0eCwKPiAgIAkJCSAgIHNpemVvZih1c2VyX3NzZXUpKSkKPiAgIAkJcmV0 dXJuIC1FRkFVTFQ7Cj4gICAKPiAtCWlmICh1c2VyX3NzZXUuZmxhZ3MgfHwgdXNlcl9zc2V1LnJz dmQpCj4gKwlpZiAodXNlcl9zc2V1LnJzdmQpCj4gICAJCXJldHVybiAtRUlOVkFMOwo+ICAgCj4g LQllbmdpbmUgPSBsb29rdXBfdXNlcl9lbmdpbmUoY3R4LCAwLAo+ICsJaWYgKHVzZXJfc3NldS5m bGFncyAmIH4oSTkxNV9DT05URVhUX1NTRVVfRkxBR19FTkdJTkVfSU5ERVgpKQo+ICsJCXJldHVy biAtRUlOVkFMOwo+ICsKPiArCWxvb2t1cCA9IDA7Cj4gKwlpZiAodXNlcl9zc2V1LmZsYWdzICYg STkxNV9DT05URVhUX1NTRVVfRkxBR19FTkdJTkVfSU5ERVgpCj4gKwkJbG9va3VwIHw9IExPT0tV UF9VU0VSX0lOREVYOwo+ICsKPiArCWVuZ2luZSA9IGxvb2t1cF91c2VyX2VuZ2luZShjdHgsIGxv b2t1cCwKPiAgIAkJCQkgICAgdXNlcl9zc2V1LmVuZ2luZV9jbGFzcywKPiAgIAkJCQkgICAgdXNl cl9zc2V1LmVuZ2luZV9pbnN0YW5jZSk7Cj4gICAJaWYgKCFlbmdpbmUpCj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvdWFwaS9kcm0vaTkxNV9kcm0uaCBiL2luY2x1ZGUvdWFwaS9kcm0vaTkxNV9kcm0u aAo+IGluZGV4IDAwMTQ3Yjk5MGU2My4uYTYwOTYxOTYxMGYyIDEwMDY0NAo+IC0tLSBhL2luY2x1 ZGUvdWFwaS9kcm0vaTkxNV9kcm0uaAo+ICsrKyBiL2luY2x1ZGUvdWFwaS9kcm0vaTkxNV9kcm0u aAo+IEBAIC0xNTY1LDkgKzE1NjUsMTAgQEAgc3RydWN0IGRybV9pOTE1X2dlbV9jb250ZXh0X3Bh cmFtX3NzZXUgewo+ICAgCV9fdTE2IGVuZ2luZV9pbnN0YW5jZTsKPiAgIAo+ICAgCS8qCj4gLQkg KiBVbnVzZWQgZm9yIG5vdy4gTXVzdCBiZSBjbGVhcmVkIHRvIHplcm8uCj4gKwkgKiBVbmtub3du IGZsYWdzIG11c3QgYmUgY2xlYXJlZCB0byB6ZXJvLgo+ICAgCSAqLwo+ICAgCV9fdTMyIGZsYWdz Owo+ICsjZGVmaW5lIEk5MTVfQ09OVEVYVF9TU0VVX0ZMQUdfRU5HSU5FX0lOREVYICgxdSA8PCAw KQo+ICAgCj4gICAJLyoKPiAgIAkgKiBNYXNrIG9mIHNsaWNlcyB0byBlbmFibGUgZm9yIHRoZSBj b250ZXh0LiBWYWxpZCB2YWx1ZXMgYXJlIGEgc3Vic2V0Cj4gCgpMb29rcyBva2F5LiBCdXQgb25l IG1vcmUgdGhpbmcgaXMgbmVlZGVkOgoKaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+dHVy c3VsaW4vZHJtLWludGVsL2NvbW1pdC8/aD1tZWRpYSZpZD0zODI2NmJmZTk5NDY5ZGU5ZTEzNzc0 YTEzZmE2NDFjMzc3OTg4YzY3CgpJZiB5b3UgZG9uJ3QgZGlzYWdyZWUgd2l0aCB0aGlzIHBhdGNo IGZlZWwgZnJlZSB0byBhZG9wdCBpdCBpbnRvIHlvdXIgdHJlZS4KClJlZ2FyZHMsCgpUdnJ0a28K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4