From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC373C35671 for ; Sat, 22 Feb 2020 11:37:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3B672071E for ; Sat, 22 Feb 2020 11:37:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZiK7iWOS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3B672071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 481B96E879; Sat, 22 Feb 2020 11:37:01 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 664B56E879 for ; Sat, 22 Feb 2020 11:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582371417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HJ/w/or5K/3iSGjnhNEupgWTYRGrnhJNvNBceudjZb0=; b=ZiK7iWOSf9JeYMOMQA0v7gpso7s/7A8Avd3Ez6pXYIHqH5G2uaoEhBlrMbGf5wfL2SiNYl F6vz8d/DXQMYbEvDFsK9K9LGewY0X6ebyP1FrohNht+3F+AzJAlXxgrJSjV/2nFPUjgGUf Y3WEqt/CG33+MlZQJ5oLJfMxVzsyVi0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-54-Ja4_qp4rMEGGNPzIwhmeCQ-1; Sat, 22 Feb 2020 06:36:53 -0500 X-MC-Unique: Ja4_qp4rMEGGNPzIwhmeCQ-1 Received: by mail-wm1-f71.google.com with SMTP id u11so1419975wmb.4 for ; Sat, 22 Feb 2020 03:36:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HJ/w/or5K/3iSGjnhNEupgWTYRGrnhJNvNBceudjZb0=; b=WSa2goFxDN6gWrqv4KcJU35mHdtMxJO7WgTVlTPRHWTDYtPI485tX3WD5nyHSHx2e6 SHcwLRx2eX9/9TAHxZPGuLql4V4S4YRRoSawCZL/3sI08n8e3A62AL352zPrBF+bmRdA bk6dkqr9PnoFD8/UO7B0NbdFLQsVOXa/qyYBvIIKAI6aeB6/vjLcHAeThCIV35+STZR8 ZWcuKLq/HgITU5Ly3RuWfY7+v6N5ftMMw74SPlMNkMjVpu0s9THub0Wn+kHVmbOQErmg pCVDsrvxhSRlLXaSoKyCGoeMh7cjIExiKPe1HR4SFd1DhP9RYC23SXl4+cnnzs9yTyKh RKeg== X-Gm-Message-State: APjAAAX9H++ZXjAsSvzDi4xijzpxKKPT4EB7aoFcENh7ribzxx7DMeC5 AwRS2aFAe/ltk4YEn2MTv7AK5EaFcMFuNyr0N2GKcjfZsV4HeOMnrA5PwZfolVVzxdIcrLy0uhE NDU914Y0KflKNpdP+X+PqRdBBH1YD X-Received: by 2002:adf:df0e:: with SMTP id y14mr52355550wrl.377.1582371412136; Sat, 22 Feb 2020 03:36:52 -0800 (PST) X-Google-Smtp-Source: APXvYqyZwTRbNmwvna8NwJJdWmiLjZ2zk4hzXiWwHc/VxMptD6a7Y9B0F7KB6fJdUUdPxuXl19pi7Q== X-Received: by 2002:adf:df0e:: with SMTP id y14mr52355536wrl.377.1582371411917; Sat, 22 Feb 2020 03:36:51 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-7a91-34f6-66f7-d87c.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:7a91:34f6:66f7:d87c]) by smtp.gmail.com with ESMTPSA id m125sm8379996wmf.8.2020.02.22.03.36.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Feb 2020 03:36:51 -0800 (PST) To: Daniel Vetter , DRI Development References: <20200221210319.2245170-1-daniel.vetter@ffwll.ch> <20200221210319.2245170-18-daniel.vetter@ffwll.ch> From: Hans de Goede Message-ID: <468c8ab6-b99f-c662-6f02-bc600b11ceb2@redhat.com> Date: Sat, 22 Feb 2020 12:36:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200221210319.2245170-18-daniel.vetter@ffwll.ch> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Intel-gfx] [PATCH 17/51] drm/gm12u320: Use drmm_add_final_kfree X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, On 2/21/20 10:02 PM, Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > Signed-off-by: Daniel Vetter > Cc: Hans de Goede Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/tiny/gm12u320.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c > index a48173441ae0..524ca0941cf9 100644 > --- a/drivers/gpu/drm/tiny/gm12u320.c > +++ b/drivers/gpu/drm/tiny/gm12u320.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -637,7 +638,6 @@ static void gm12u320_driver_release(struct drm_device *dev) > gm12u320_usb_free(gm12u320); > drm_mode_config_cleanup(dev); > drm_dev_fini(dev); > - kfree(gm12u320); > } > > DEFINE_DRM_GEM_FOPS(gm12u320_fops); > @@ -692,6 +692,7 @@ static int gm12u320_usb_probe(struct usb_interface *interface, > return ret; > } > dev->dev_private = gm12u320; > + drmm_add_final_kfree(dev, gm12u320); > > drm_mode_config_init(dev); > dev->mode_config.min_width = GM12U320_USER_WIDTH; > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx