From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 996A5C46467 for ; Wed, 11 Jan 2023 09:22:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DA9E10E53F; Wed, 11 Jan 2023 09:22:15 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2FE110E53F; Wed, 11 Jan 2023 09:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673428933; x=1704964933; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=o+hLWcQJR1WQrpOJPoZRXxofuA4PdxNyWQ4SIXzT9d0=; b=LUAoyHeURjVURPZIV7oMfXimQPOdAYR91glTywXBQ9hYmFP4oddO1rsJ dBujggJhvv3FkvEPYCbiLcuCEw3zAiY5OII6Cd9+vJcBQ102WxC9k7bmS mg3c5LSo4nsDZuoa7Z542dFDu5618F6LkVPd2l2OxTH0PS3b0b99qMDrE QBGXO4mQwx2vGgwnYI+uAhIf0ZvX6Dt7/W3QaTlRAY9Q6wZQeH4NFPVgz /FRa3J7+zNYpF7OfE7n6sk2iJlz4+zdAt2+sXIjICe6qimmlD9vzBOIwa awfr2zGhXR6vfSAjr5pVPNQ/VQGqoeVDCgrlRqcPy9ZpkmiRfOxVR/CSk A==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="323434076" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="323434076" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 01:22:12 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="607290392" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="607290392" Received: from dhuchimu-mobl3.amr.corp.intel.com (HELO [10.212.68.70]) ([10.212.68.70]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 01:22:11 -0800 Message-ID: <46fb54f5-de8f-eec5-216a-b53a483ebcd2@linux.intel.com> Date: Wed, 11 Jan 2023 09:22:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Matt Roper References: <20230110113533.744436-1-tvrtko.ursulin@linux.intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v4] drm/i915: Do not cover all future platforms in TLB invalidation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrzej Hajda , Intel-gfx@lists.freedesktop.org, Balasubramani Vivekanandan , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 10/01/2023 16:07, Matt Roper wrote: > On Tue, Jan 10, 2023 at 11:35:33AM +0000, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> Revert to the original explicit approach and document the reasoning >> behind it. >> >> v2: >> * DG2 needs to be covered too. (Matt) >> >> v3: >> * Full version check for Gen12 to avoid catching all future platforms. >> (Matt) >> >> v4: >> * Be totally explicit on the Gen12 branch. (Andrzej) >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Matt Roper >> Cc: Balasubramani Vivekanandan >> Cc: Andrzej Hajda >> Reviewed-by: Andrzej Hajda # v1 >> Reviewed-by: Matt Roper # v3 > > Reviewed-by: Matt Roper > > for v4 as well. Thanks, pushed! So next I have that patch which moves the register/bits selection logic to engine init time. I will send it out rebased but do not intend to merge before the tlb invalidation selftest can land upstream. Regards, Tvrtko