public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Chi Ding <chix.ding@intel.com>
Subject: Re: [PATCH] drm/i915: Force vblanks around evasion when i915.watermark_test is set.
Date: Tue, 14 Jun 2016 08:27:57 +0200	[thread overview]
Message-ID: <473c83c2-8bcb-2acf-b0dc-71e50fcd00dc@linux.intel.com> (raw)
In-Reply-To: <20160613144548.GE1338@phenom.ffwll.local>

Op 13-06-16 om 16:45 schreef Daniel Vetter:
> On Thu, Jun 09, 2016 at 01:36:50PM +0200, Maarten Lankhorst wrote:
>> This will make it more likely that intermediary watermarks cause fifo
>> underruns, which is useful when writing watermark specific tests,
>> to make it more likely to trigger FIFO underruns in intermediary watermarks.
> That's surprising ... with the vblank_wait added you're pretty much
> guaranteed to never hit the evasion case. Note that the vblank evasion
> code also just does a vblank wait if it detects a possible collision.
>
> Given that I'd have assumed that this simply slows down atomic flips,
> which is probably not what we want for testing all. Does this really help?
> Any ideas why?
This is a sanity check on the intermediate watermarks. The vblank test will ensure
that the old plane configuration doesn't cause underruns with watermarks, and that
the intermediate watermarks will work correctly with the new plane configuration too.

I think the latter vblank_wait may be killed, but the former could be really useful,
for example to find correct watervblank values in CHV.

~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-06-14  6:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 11:36 [PATCH] drm/i915: Force vblanks around evasion when i915.watermark_test is set Maarten Lankhorst
2016-06-13 14:45 ` Daniel Vetter
2016-06-14  6:27   ` Maarten Lankhorst [this message]
2016-06-14 15:48     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473c83c2-8bcb-2acf-b0dc-71e50fcd00dc@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=chix.ding@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox