* Patch to fix backlight on GM45
@ 2011-01-28 22:13 Peter Clifton
2011-01-30 20:50 ` Niccolò Belli
2011-02-01 20:17 ` Niccolò Belli
0 siblings, 2 replies; 3+ messages in thread
From: Peter Clifton @ 2011-01-28 22:13 UTC (permalink / raw)
To: Intel
[-- Attachment #1.1.1: Type: text/plain, Size: 519 bytes --]
Without this, querying the backlight value returns half of the value it
has been set to. Hilarity ensues, as my user-space likes to query first
before incrementing / decrementing brightness, leading to brightness
collapsing to near as I try to adjust.
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)
[-- Attachment #1.1.2: 0001-drm-intel-Fix-brightness-value-query-when-in-combina.patch --]
[-- Type: text/x-patch, Size: 748 bytes --]
From db647ad5ff5ce80e1a515411db7e4c6587c7e798 Mon Sep 17 00:00:00 2001
From: Peter Clifton <pcjc2@cam.ac.uk>
Date: Fri, 28 Jan 2011 22:08:40 +0000
Subject: [PATCH] drm/intel: Fix brightness value query when in combination mode
---
drivers/gpu/drm/i915/intel_panel.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index 4ab4239..1795823 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -208,7 +208,6 @@ u32 intel_panel_get_backlight(struct drm_device *dev)
val &= ~1;
pci_read_config_byte(dev->pdev, PCI_LBPC, &lbpc);
val *= lbpc;
- val >>= 1;
}
}
--
1.7.2.3
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Patch to fix backlight on GM45
2011-01-28 22:13 Patch to fix backlight on GM45 Peter Clifton
@ 2011-01-30 20:50 ` Niccolò Belli
2011-02-01 20:17 ` Niccolò Belli
1 sibling, 0 replies; 3+ messages in thread
From: Niccolò Belli @ 2011-01-30 20:50 UTC (permalink / raw)
To: Peter Clifton; +Cc: Intel
Il 28/01/2011 23:13, Peter Clifton ha scritto:
> Without this, querying the backlight value returns half of the value it
> has been set to. Hilarity ensues, as my user-space likes to query first
> before incrementing / decrementing brightness, leading to brightness
> collapsing to near as I try to adjust.
I have this problem too. I will try your patch.
Darkbasic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch to fix backlight on GM45
2011-01-28 22:13 Patch to fix backlight on GM45 Peter Clifton
2011-01-30 20:50 ` Niccolò Belli
@ 2011-02-01 20:17 ` Niccolò Belli
1 sibling, 0 replies; 3+ messages in thread
From: Niccolò Belli @ 2011-02-01 20:17 UTC (permalink / raw)
To: intel-gfx
Il 28/01/2011 23:13, Peter Clifton ha scritto:
> Without this, querying the backlight value returns half of the value it
> has been set to. Hilarity ensues, as my user-space likes to query first
> before incrementing / decrementing brightness, leading to brightness
> collapsing to near as I try to adjust.
It works flawlessly, thank you! Unfortunately I have not been able to
apply the attached patch (for unknown reasons), so I modified the file
manually.
Will it ever be merged into drm-intel? Intel-drm-fixes is still bugged...
Darkbasic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-01 20:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-28 22:13 Patch to fix backlight on GM45 Peter Clifton
2011-01-30 20:50 ` Niccolò Belli
2011-02-01 20:17 ` Niccolò Belli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox