Re: [git pull] i915 fixes

[Jim Gettys <jg@freedesktop.org>]

On 03/07/2011 07:00 AM, Chris Wilson wrote:
> Dave, hopefully this completes the regression fixes for .38. There is
> still some doubt over eDP, with 011b9910bdaf failing for Jim Gettys but
> seeming required for other (currently working in .37) machines. And
> despite Linus's intervention, backlight controls are still broken for some
> users.

FWIW:

The failure is not so common for me as to claim the change should not go 
in; and my work around is to suspend/resume the system again.

It's mostly niggling discomfort that there is still something about eDP 
we still don't understand...

The remaining question, of course, is whether the other fixes in the 
final release will continue the fine year long tradition of completely 
breaking my laptop in Linus' releases yet again ;-).
			- Jim


>
> I've taken the conservative approach and disabled GPU semaphores by
> default since that prevents one cause of hangs, even though I think it is
> fixed by the earlier patch to prevent the FIFO overflow. The other patch
> addresses a bug introduced by the combination of relaxed fencing and fence
> pipelining infrastructure where to forgot to teardown a bound buffer if it
> invalidated its new alignment constraints. Hopefully this will fix the
> reported corruption for gen2/3 devices, though there is the possibility of
> further underlying bugs.
> -Chris
>
> The following changes since commit fb62c00a6d8942775abc23d1621db1252e2d93d1:
>
>    Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client (2011-03-05 10:43:22 -0800)
>
> are available in the git repository at:
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/ickle/drm-intel.git drm-intel-fixes
>
> Chris Wilson (4):
>        Revert "drm/i915: fix corruptions on i8xx due to relaxed fencing"
>        drm/i915: Do not overflow the MMADDR write FIFO
>        drm/i915: Disable GPU semaphores by default
>        drm/i915: Rebind the buffer if its alignment constraints changes with tiling
>
>   drivers/gpu/drm/i915/i915_debugfs.c        |    4 +-
>   drivers/gpu/drm/i915/i915_drv.c            |   17 +++++++++++-
>   drivers/gpu/drm/i915/i915_drv.h            |   24 ++++++++++++++----
>   drivers/gpu/drm/i915/i915_gem.c            |    2 +-
>   drivers/gpu/drm/i915/i915_gem_execbuffer.c |    4 +-
>   drivers/gpu/drm/i915/i915_gem_tiling.c     |   37 +++++++++++++--------------
>   drivers/gpu/drm/i915/i915_reg.h            |    2 +
>   drivers/gpu/drm/i915/intel_display.c       |    8 +++---
>   drivers/gpu/drm/i915/intel_ringbuffer.h    |   13 +++++----
>   9 files changed, 70 insertions(+), 41 deletions(-)
>