From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Gettys Subject: Re: [git pull] i915 fixes Date: Mon, 07 Mar 2011 23:08:25 -0500 Message-ID: <4D75ABB9.9030304@freedesktop.org> References: <0d30dc$lbt63o@orsmga001.jf.intel.com> <4D754DEC.6040301@freedesktop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from qmta03.emeryville.ca.mail.comcast.net (qmta03.emeryville.ca.mail.comcast.net [76.96.30.32]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F2A79E745 for ; Mon, 7 Mar 2011 20:16:38 -0800 (PST) In-Reply-To: <4D754DEC.6040301@freedesktop.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 03/07/2011 04:28 PM, Jim Gettys wrote: > On 03/07/2011 07:00 AM, Chris Wilson wrote: >> Dave, hopefully this completes the regression fixes for .38. There is >> still some doubt over eDP, with 011b9910bdaf failing for Jim Gettys but >> seeming required for other (currently working in .37) machines. And >> despite Linus's intervention, backlight controls are still broken for >> some >> users. > > FWIW: > > The failure is not so common for me as to claim the change should not go > in; and my work around is to suspend/resume the system again. > > It's mostly niggling discomfort that there is still something about eDP > we still don't understand... > > The remaining question, of course, is whether the other fixes in the > final release will continue the fine year long tradition of completely > breaking my laptop in Linus' releases yet again ;-). Well, Chris' tree with the last set of patches works about the same as Linus' rc7; still exhibits the flashing bug, but suspending again can get it to go away. So maybe we can avoid the completely broken Linus release this time (knock on wooden head); certainly we're well beyond the previous state where installation required serious gymnastics. - Jim > >> >> I've taken the conservative approach and disabled GPU semaphores by >> default since that prevents one cause of hangs, even though I think it is >> fixed by the earlier patch to prevent the FIFO overflow. The other patch >> addresses a bug introduced by the combination of relaxed fencing and >> fence >> pipelining infrastructure where to forgot to teardown a bound buffer >> if it >> invalidated its new alignment constraints. Hopefully this will fix the >> reported corruption for gen2/3 devices, though there is the >> possibility of >> further underlying bugs. >> -Chris >> >> The following changes since commit >> fb62c00a6d8942775abc23d1621db1252e2d93d1: >> >> Merge branch 'for-linus' of >> git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client >> (2011-03-05 10:43:22 -0800) >> >> are available in the git repository at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/ickle/drm-intel.git >> drm-intel-fixes >> >> Chris Wilson (4): >> Revert "drm/i915: fix corruptions on i8xx due to relaxed fencing" >> drm/i915: Do not overflow the MMADDR write FIFO >> drm/i915: Disable GPU semaphores by default >> drm/i915: Rebind the buffer if its alignment constraints changes with >> tiling >> >> drivers/gpu/drm/i915/i915_debugfs.c | 4 +- >> drivers/gpu/drm/i915/i915_drv.c | 17 +++++++++++- >> drivers/gpu/drm/i915/i915_drv.h | 24 ++++++++++++++---- >> drivers/gpu/drm/i915/i915_gem.c | 2 +- >> drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 +- >> drivers/gpu/drm/i915/i915_gem_tiling.c | 37 +++++++++++++-------------- >> drivers/gpu/drm/i915/i915_reg.h | 2 + >> drivers/gpu/drm/i915/intel_display.c | 8 +++--- >> drivers/gpu/drm/i915/intel_ringbuffer.h | 13 +++++---- >> 9 files changed, 70 insertions(+), 41 deletions(-) >> > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx >