From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places Date: Wed, 02 Nov 2011 11:29:53 -0400 Message-ID: <4EB161F1.5090003@redhat.com> References: <1320214830-12696-1-git-send-email-keithp@keithp.com> <1320214830-12696-4-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1320214830-12696-4-git-send-email-keithp@keithp.com> Sender: linux-kernel-owner@vger.kernel.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 11/2/11 2:20 AM, Keith Packard wrote: > + if (intel_dp->link_configuration [1] & DP_LANE_COUNT_ENHANCED_FRAME_EN) > + intel_dp->DP |= DP_ENHANCED_FRAMING; > + > + /* > + * Check for DPCD version> 1.1 and enhanced framing support > + */ > + if (intel_dp->dpcd[DP_DPCD_REV] >= 0x11 && > + (intel_dp->dpcd[DP_MAX_LANE_COUNT] & DP_ENHANCED_FRAME_CAP)) { > + intel_dp->link_configuration[1] |= DP_LANE_COUNT_ENHANCED_FRAME_EN; > + intel_dp->DP |= DP_ENHANCED_FRAMING; > + } Redundant. You've already done the link_configuration |= above in the common code. You can drop the second if chunk altogether. In related news, the corresponding section for this in TRANS_DP_CTL setup appears to turn on enhanced framing unconditionally. This is probably not a big deal, I don't think I've ever seen a display not support it, but. - ajax