From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Alexandre Salim Subject: Re: [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user Date: Wed, 09 Nov 2011 17:30:29 +0100 Message-ID: <4EBAAAA5.7030807@fedoraproject.org> References: <1320855178.5081.9.camel@fauix11.informatik.uni-erlangen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1320855178.5081.9.camel@fauix11.informatik.uni-erlangen.de> Sender: linux-kernel-owner@vger.kernel.org To: intel-gfx@lists.freedesktop.org Cc: Keith Packard , Jesse Barnes , Chris Wilson , linux-kernel List-Id: intel-gfx@lists.freedesktop.org Additional note: while I've not touched the line since it does not affect me, it seems that i915_panel_use_ssc *cannot* be less than 0 since that variable is declared as unsigned. So the last line (the value in dev_priv) will never be used to determin= e whether SSC is used anyway. Keith probably knows more since he introduces that check in the commit that my patch referred to. On 11/09/2011 05:12 PM, Michel Alexandre Salim wrote: > static inline bool intel_panel_use_ssc(struct drm_i915_private *dev_= priv) > { > + if (i915_panel_use_ssc =3D=3D 1) > + return true; > + if (dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE) > + return false; > if (i915_panel_use_ssc >=3D 0) > return i915_panel_use_ssc !=3D 0; > - return dev_priv->lvds_use_ssc > - && !(dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE); > + return dev_priv->lvds_use_ssc; > } > =20 > /** --=20 Michel Alexandre Salim =C2=B5blog: http://identi.ca/hircus http://twitter.com/hircus GPG key ID: 78884778 () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments