Re: [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user

Michel Alexandre Salim
2011-11-09T16:30:29Z

Additional note: while I've not touched the line since it does not
affect me, it seems that i915_panel_use_ssc *cannot* be less than 0
since that variable is declared as unsigned.

So the last line (the value in dev_priv) will never be used to determine
whether SSC is used anyway. Keith probably knows more since he
introduces that check in the commit that my patch referred to.

On 11/09/2011 05:12 PM, Michel Alexandre Salim wrote:
> static inline bool intel_panel_use_ssc(struct drm_i915_private *dev_priv)
> {
> + if (i915_panel_use_ssc == 1)
> + return true;
> + if (dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE)
> + return false;
> if (i915_panel_use_ssc >= 0)
> return i915_panel_use_ssc != 0;
> - return dev_priv->lvds_use_ssc
> - && !(dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE);
> + return dev_priv->lvds_use_ssc;
> }
>
> /**

--
Michel Alexandre Salim
µblog: http://identi.ca/hircus
http://twitter.com/hircus
GPG key ID: 78884778

() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments