From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeni Dodonov Subject: Re: [PATCH 02/10] drm/i915: rework dev->first_error locking Date: Fri, 04 May 2012 14:04:23 -0300 Message-ID: <4FA40C17.4020406@linux.intel.com> References: <1335532667-10597-1-git-send-email-daniel.vetter@ffwll.ch> <1335532667-10597-2-git-send-email-daniel.vetter@ffwll.ch> Reply-To: eugeni.dodonov@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EC1C9E968 for ; Fri, 4 May 2012 10:04:09 -0700 (PDT) In-Reply-To: <1335532667-10597-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On 04/27/2012 10:17 AM, Daniel Vetter wrote: > - reduce the irq disabled section, even for a debugfs file this was > way too long. > - always disable irqs when taking the lock. > > v2: Thou shalt not mistake locking for reference counting, so: > - reference count the error_state to protect from concurent freeeing. > This will be only really used in the next patch. > > Signed-Off-by: Daniel Vetter Reviewed-by: Eugeni Dodonov