From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH 09/25] drm/i915: enable power wells on
 Haswell init
Date: Thu, 10 May 2012 12:08:22 -0300
Message-ID: <4FABD9E6.6090909@linux.intel.com>
References: <20120509214229.GE4963@phenom.ffwll.local>
	<1336606197-7213-1-git-send-email-eugeni.dodonov@intel.com>
	<20120510144818.GB4912@phenom.ffwll.local>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8B7F79E791
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 10 May 2012 08:08:41 -0700 (PDT)
In-Reply-To: <20120510144818.GB4912@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On 05/10/2012 11:48 AM, Daniel Vetter wrote:
> On Wed, May 09, 2012 at 08:29:57PM -0300, Eugeni Dodonov wrote:
>> This attempts to enable all the available power wells during the
>> initialization.
>>
>> Those power wells can be enabled in parallel or on-demand, and disabled
>> when no longer needed, but this is out of scope of this initial
>> enablement. Proper tracking of who uses which power well will require
>> a considerable rework of our display handling, so we just leave them all
>> enabled when the driver is loaded for now.
>>
>> v2: use more generic and future-proof code
>>
>> v3: call intel_init_power_wells from within intel_modeset_init_hw, so it
>> would be called upon resume path as well.
>>
>> Signed-off-by: Eugeni Dodonov<eugeni.dodonov@intel.com>
>
> I've picked up everything up to this one here into dinq. Can you please
> double-check whether the power well enabling is still at the right place?
> I've somehow dropped Chris' patch to move around things for the rps stuff
> that I've merged yesterday, but now it's back as:
>
> commit 2e1352cf196094f44e73776f41087f4c489ab936
> Author: Chris Wilson<chris@chris-wilson.co.uk>
> Date:   Wed May 9 11:56:28 2012 +0100
>
>      drm/i915: gen6_enable_rps() wants to be called after ring
>      initialisation
>
> Cheers, Daniel

I re-tested with latest drm-intel-next-queued (with everything applied 
up to this patch), and applied the remaining patches on top of it - 
including this power wells patch - and confirmed that it still works.

I haven't tested suspend-resume yet (as this does not works yet anyway :)).