From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeni Dodonov Subject: Re: [PATCH 4/4] drm/i915: s/i915_wait_reqest/i915_wait_seqno/g Date: Fri, 11 May 2012 19:56:42 -0300 Message-ID: <4FAD992A.70402@linux.intel.com> References: <1336769652-11740-1-git-send-email-ben@bwidawsk.net> <1336769652-11740-4-git-send-email-ben@bwidawsk.net> Reply-To: eugeni.dodonov@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id AD56B9EB39 for ; Fri, 11 May 2012 15:56:10 -0700 (PDT) In-Reply-To: <1336769652-11740-4-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 05/11/2012 05:54 PM, Ben Widawsky wrote: > Wait request is poorly named IMO. After working with these functions for > some time, I feel it's much clearer to name the functions more > appropriately. > > Of course we must update the callers to use the new name as well. > > This leaves room within our namespace for a *real* wait request function > at some point. > > Note to maintainer: this patch is optional. > > Signed-off-by: Ben Widawsky My only bikeshedding is to 's/wait_reqest/wait_request' in patch title :). Eugeni