From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH] drm/i915: fix up ivb plane 3 pageflips
Date: Tue, 05 Jun 2012 15:52:48 -0300
Message-ID: <4FCE5580.5090106@linux.intel.com>
References: <1337772653_201033@CP5-2952>
	<1337774520-26572-1-git-send-email-daniel.vetter@ffwll.ch>
	<20120605085658.GA4704@phenom.ffwll.local>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
	by gabe.freedesktop.org (Postfix) with ESMTP id 74ECE9E75E
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  5 Jun 2012 11:51:33 -0700 (PDT)
In-Reply-To: <20120605085658.GA4704@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Ben Widawsky <ben@bwidawsk.net>, Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On 06/05/2012 05:56 AM, Daniel Vetter wrote:
> On Wed, May 23, 2012 at 02:02:00PM +0200, Daniel Vetter wrote:
>> Or at least plug another gapping hole. Apparrently hw desingers only
>> moved the bit field, but did not bother ot re-enumerate the planes
>> when adding support for a 3rd pipe.
>>
>> Discovered by i-g-t/flip_test.
>>
>> This may or may not fix the reference bugzilla, because that one
>> smells like we have still larger fish to fry.
>>
>> v2: Fixup the impossible case to catch programming errors, noticed by
>> Chris Wilson.
>>
>> References: https://bugs.freedesktop.org/show_bug.cgi?id=50069
>> Signed-Off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
>
> Ping for review and maybe a tested-by. This fixes i-g-t/tests/flip_test on
> my ivb, but for some strange reasons QA can't confirm that. Still, I'd
> like to push this patch to -fixes. Eugeni, Ben?

Although I don't get exact symptoms (I don't get any BUG in dmesg), 
without this patch the flip_test hangs when running on 3rd pipe, and 
with this patch it proceeds and finishes correctly.

So this patch fixes this test case, and as far I can see it is correct.

Tested-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

Eugeni