From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH] drm/i915: pch_irq_handler -> {ibx,
	cpt}_irq_handler
Date: Wed, 06 Jun 2012 17:39:41 -0300
Message-ID: <4FCFC00D.7070701@linux.intel.com>
References: <1339011944-31176-1-git-send-email-ajax@redhat.com>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id E67539E732
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  6 Jun 2012 13:38:22 -0700 (PDT)
In-Reply-To: <1339011944-31176-1-git-send-email-ajax@redhat.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Adam Jackson <ajax@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 06/06/2012 04:45 PM, Adam Jackson wrote:
> Cougar/Panther Point redefine the bits in SDEIIR pretty completely.
> This function is just debugging, but if we're debugging we probably want
> to be told accurate things instead of lies.
>
> I'm told Lynx Point changes this yet more, but I have no idea how...
>
> Signed-off-by: Adam Jackson <ajax@redhat.com>

Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

For the record and for future enabling efforts, for LPT, bits 28-31 and 
1-14 are gone since CPT/PPT (e.g., those must be zero). And there is the 
bit 15 as a new addition, but we are not using it yet and probably won't 
be using in foreseeable future.

Eugeni