From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH 4/4] drm/i915: allow pipe A for lvds on gen4
Date: Tue, 12 Jun 2012 12:35:17 -0300
Message-ID: <4FD761B5.10206@linux.intel.com>
References: <1338883631-3493-1-git-send-email-daniel.vetter@ffwll.ch>
	<1338883631-3493-4-git-send-email-daniel.vetter@ffwll.ch>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6A4C79E957
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 12 Jun 2012 08:33:46 -0700 (PDT)
In-Reply-To: <1338883631-3493-4-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On 06/05/2012 05:07 AM, Daniel Vetter wrote:
> Given the havoc the missing backlight pipe select code might have
> caused, let's try to re-enabled pipe A support for lvds on gen4 hw.
> Just to see what all blows up ...
> 
> Note though that
> 
> commit 4add75c43f39573edc884d46b7c2b7414f01171a
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Sat Dec 4 17:49:46 2010 +0000
> 
>     drm/i915: Allow LVDS to be on pipe A for Ironlake+
> 
> claims that this caused tons of spurious wakeups somehow.
> 
> More details can be found in the old revert:
> 
> commit 12e8ba25ef52f19e7a42e61aecb3c1fef83b2a82
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Tue Sep 7 23:39:28 2010 +0100
> 
>     Revert "drm/i915: Allow LVDS on pipe A on gen4+"
> 
>     Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=16307
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I think we'll notice soon enough if it breaks something, so why not
giving it a try?

Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

Eugeni